From 767d2416d8134b66a53f56ed70900526c6f0894d Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Wed, 22 Jul 2026 16:42:10 +0800 Subject: [PATCH] watchdog: cadence_wdt: Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Link: https://lore.kernel.org/r/20260722084218.79073-3-panchuang@vivo.com Signed-off-by: Guenter Roeck --- drivers/watchdog/cadence_wdt.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c index 23d41043863f..ad46b33ce5f2 100644 --- a/drivers/watchdog/cadence_wdt.c +++ b/drivers/watchdog/cadence_wdt.c @@ -312,12 +312,8 @@ static int cdns_wdt_probe(struct platform_device *pdev) if (!wdt->rst && irq >= 0) { ret = devm_request_irq(dev, irq, cdns_wdt_irq_handler, 0, pdev->name, pdev); - if (ret) { - dev_err(dev, - "cannot register interrupt handler err=%d\n", - ret); + if (ret) return ret; - } } /* Initialize the members of cdns_wdt structure */