mirror of
https://github.com/torvalds/linux.git
synced 2026-07-27 01:32:21 +02:00
Locking updates for v7.2:
Futex updates:
- Optimize futex hash bucket access patterns (Peter Zijlstra)
- Large series to address the robust futex unlock race for real,
by Thomas Gleixner:
"The robust futex unlock mechanism is racy in respect
to the clearing of the robust_list_head::list_op_pending
pointer because unlock and clearing the pointer are not
atomic. The race window is between the unlock and clearing the
pending op pointer. If the task is forced to exit in this
window, exit will access a potentially invalid pending op
pointer when cleaning up the robust list. That happens if
another task manages to unmap the object containing the lock
before the cleanup, which results in an UAF. In the worst case
this UAF can lead to memory corruption when unrelated content
has been mapped to the same address by the time the access
happens.
User space can't solve this problem without help from the kernel.
This series provides the kernel side infrastructure to help it
along:
1) Combined unlock, pointer clearing, wake-up for the
contended case
2) VDSO based unlock and pointer clearing helpers with a
fix-up function in the kernel when user space was interrupted
within the critical section.
... with help by André Almeida:
- Add a note about robust list race condition (André Almeida)
- Add self-tests for robust release operations (André Almeida)
Context analysis updates:
- Implement context analysis for 'struct rt_mutex'.
(Bart Van Assche)
- Bump required Clang version to 23 (Marco Elver)
Guard infrastructure updates:
- Series to remove NULL check from unconditional guards
(Dmitry Ilvokhin)
Lockdep updates:
- Restore self-test migrate_disable() and sched_rt_mutex
state on PREEMPT_RT (Karl Mehltretter)
Membarriers updates:
- Use per-CPU mutexes for targeted commands (Aniket Gattani)
- Modernize membarrier_global_expedited with cleanup guards
(Aniket Gattani)
- Add rseq stress test for CFS throttle interactions (Aniket Gattani)
percpu-rwsems updates:
- Extract __percpu_up_read() to optimize inlining overhead
(Dmitry Ilvokhin)
Seqlocks updates:
- Allow UBSAN_ALIGNMENT to fail optimizing (Heiko Carstens)
Lock tracing:
- Add contended_release tracepoint to sleepable locks
such as mutexes, percpu-rwsems, rtmutexes, rwsems
and semaphores. (Dmitry Ilvokhin)
MAINTAINERS updates:
- MAINTAINERS: Add RUST [SYNC] entry (Boqun Feng)
Misc updates and fixes by Randy Dunlap, YE WEI-HONG,
Fabricio Parra, Dmitry Ilvokhin and Peter Zijlstra.
Signed-off-by: Ingo Molnar <mingo@kernel.org>
-----BEGIN PGP SIGNATURE-----
iQJFBAABCgAvFiEEBpT5eoXrXCwVQwEKEnMQ0APhK1gFAmoujYURHG1pbmdvQGtl
cm5lbC5vcmcACgkQEnMQ0APhK1jQFw//SNo1zxqGJuVudIWTpk5hUbWO6La9dc2C
2RW4lMNM551AaGFK6V01u1hD7dBZkWBqER+f3+CMtkqi734pAevTfkYJOitnGOOX
YZicGqTufV+Q+hcEiHAY3ADF6384SiyvAGNHL5wk3eLqC+Raug0f0cNt4opzFvr7
I6vRcW02JQMRKBe50+Aoa5zg7ymmbqaH0KkiPvfY5UFl38MKABhkY1izA9o+/Q/S
1/joNo5iQ3Ciqf6tn76vTg4Xiz7napikHB5LfWxorgmQo7FEdUY54GGMaa8aBOPi
EfgIV9p+qOJhmWn4H1HgVSYlnUn3tJICYnVVCruXWXD+pzITS+F5qSQ3p25F3VIt
c3jh3NaVW71pR/Sbj4zGvf8QguJL340RGJs/e5qcj91pjOSCH5B75ruNgFgYK9Lv
iRi6dnHBBHxaN57YHTOrhphvjyfc0L7i6cGyJgHJWwyi0y3XBYlNuP/VLPuwquKl
anK86hlkl9W4kO0OOukD1xhfuRv7066EdJc3iWWlp9yz+yI5xDGuV4FhvEHRoy38
R9VY2bwzgZrW/NkodHIb95+W30qEmeq2z1W4wiBu+mf1JnyW2g/n8jKkc6AINMpI
VGcom3MdinxjUtmybZT9Fx0SzBYCc+aRPkh7lPV7eXdZAWufxUO/6eVKiHBQ2HUO
RFDkOZU0r+c=
=gpHw
-----END PGP SIGNATURE-----
Merge tag 'locking-core-2026-06-14' of gitolite.kernel.org:pub/scm/linux/kernel/git/tip/tip
Pull locking updates from Ingo Molnar:
"Futex updates:
- Optimize futex hash bucket access patterns (Peter Zijlstra)
- Large series to address the robust futex unlock race for real, by
Thomas Gleixner:
"The robust futex unlock mechanism is racy in respect to the
clearing of the robust_list_head::list_op_pending pointer because
unlock and clearing the pointer are not atomic.
The race window is between the unlock and clearing the pending op
pointer. If the task is forced to exit in this window, exit will
access a potentially invalid pending op pointer when cleaning up
the robust list.
That happens if another task manages to unmap the object
containing the lock before the cleanup, which results in an UAF.
In the worst case this UAF can lead to memory corruption when
unrelated content has been mapped to the same address by the time
the access happens.
User space can't solve this problem without help from the kernel.
This series provides the kernel side infrastructure to help it
along:
1) Combined unlock, pointer clearing, wake-up for the
contended case
2) VDSO based unlock and pointer clearing helpers with a
fix-up function in the kernel when user space was interrupted
within the critical section.
... with help by André Almeida:
- Add a note about robust list race condition (André Almeida)
- Add self-tests for robust release operations (André Almeida)
Context analysis updates:
- Implement context analysis for 'struct rt_mutex'. (Bart Van Assche)
- Bump required Clang version to 23 (Marco Elver)
Guard infrastructure updates:
- Series to remove NULL check from unconditional guards (Dmitry
Ilvokhin)
Lockdep updates:
- Restore self-test migrate_disable() and sched_rt_mutex state on
PREEMPT_RT (Karl Mehltretter)
Membarriers updates:
- Use per-CPU mutexes for targeted commands (Aniket Gattani)
- Modernize membarrier_global_expedited with cleanup guards (Aniket
Gattani)
- Add rseq stress test for CFS throttle interactions (Aniket Gattani)
percpu-rwsems updates:
- Extract __percpu_up_read() to optimize inlining overhead (Dmitry
Ilvokhin)
Seqlocks updates:
- Allow UBSAN_ALIGNMENT to fail optimizing (Heiko Carstens)
Lock tracing:
- Add contended_release tracepoint to sleepable locks such as
mutexes, percpu-rwsems, rtmutexes, rwsems and semaphores (Dmitry
Ilvokhin)
MAINTAINERS updates:
- MAINTAINERS: Add RUST [SYNC] entry (Boqun Feng)
Misc updates and fixes by Randy Dunlap, YE WEI-HONG, Fabricio Parra,
Dmitry Ilvokhin and Peter Zijlstra"
* tag 'locking-core-2026-06-14' of gitolite.kernel.org:pub/scm/linux/kernel/git/tip/tip: (36 commits)
locking: Add contended_release tracepoint to sleepable locks
locking/percpu-rwsem: Extract __percpu_up_read()
tracing/lock: Remove unnecessary linux/sched.h include
futex: Optimize futex hash bucket access patterns
rust: sync: completion: Mark inline complete_all and wait_for_completion
MAINTAINERS: Add RUST [SYNC] entry
cleanup: Specify nonnull argument index
selftests: futex: Add tests for robust release operations
Documentation: futex: Add a note about robust list race condition
x86/vdso: Implement __vdso_futex_robust_try_unlock()
x86/vdso: Prepare for robust futex unlock support
futex: Provide infrastructure to plug the non contended robust futex unlock race
futex: Add robust futex unlock IP range
futex: Add support for unlocking robust futexes
futex: Cleanup UAPI defines
x86: Select ARCH_MEMORY_ORDER_TSO
uaccess: Provide unsafe_atomic_store_release_user()
futex: Provide UABI defines for robust list entry modifiers
futex: Move futex related mm_struct data into a struct
futex: Make futex_mm_init() void
...
This commit is contained in:
commit
764e77d868
|
|
@ -17,7 +17,7 @@ features. To enable for Clang, configure the kernel with::
|
|||
|
||||
CONFIG_WARN_CONTEXT_ANALYSIS=y
|
||||
|
||||
The feature requires Clang 22 or later.
|
||||
The feature requires Clang 23 or later.
|
||||
|
||||
The analysis is *opt-in by default*, and requires declaring which modules and
|
||||
subsystems should be analyzed in the respective `Makefile`::
|
||||
|
|
|
|||
|
|
@ -153,6 +153,9 @@ On removal:
|
|||
3) release the futex lock, and
|
||||
4) clear the 'lock_op_pending' word.
|
||||
|
||||
Please note that the removal of a robust futex purely in userspace is
|
||||
racy. Refer to the next chapter to learn more and how to avoid this.
|
||||
|
||||
On exit, the kernel will consider the address stored in
|
||||
'list_op_pending' and the address of each 'lock word' found by walking
|
||||
the list starting at 'head'. For each such address, if the bottom 30
|
||||
|
|
@ -182,3 +185,44 @@ any point:
|
|||
When the kernel sees a list entry whose 'lock word' doesn't have the
|
||||
current threads TID in the lower 30 bits, it does nothing with that
|
||||
entry, and goes on to the next entry.
|
||||
|
||||
Robust release is racy
|
||||
----------------------
|
||||
|
||||
The removal of a robust futex from the list is racy when doing it solely in
|
||||
userspace. Quoting Thomas Gleixner for the explanation:
|
||||
|
||||
The robust futex unlock mechanism is racy in respect to the clearing of the
|
||||
robust_list_head::list_op_pending pointer because unlock and clearing the
|
||||
pointer are not atomic. The race window is between the unlock and clearing
|
||||
the pending op pointer. If the task is forced to exit in this window, exit
|
||||
will access a potentially invalid pending op pointer when cleaning up the
|
||||
robust list. That happens if another task manages to unmap the object
|
||||
containing the lock before the cleanup, which results in an UAF. In the
|
||||
worst case this UAF can lead to memory corruption when unrelated content
|
||||
has been mapped to the same address by the time the access happens.
|
||||
|
||||
A full in-depth analysis can be read at
|
||||
https://lore.kernel.org/lkml/20260316162316.356674433@kernel.org/
|
||||
|
||||
To overcome that, the kernel needs to participate in the lock release operation.
|
||||
This ensures that the release happens "atomically" with regard to releasing
|
||||
the lock and removing the address from ``list_op_pending``. If the release is
|
||||
interrupted by a signal, the kernel will also verify if it interrupted the
|
||||
release operation.
|
||||
|
||||
For the contended unlock case, where other threads are waiting for the lock
|
||||
release, there's the ``FUTEX_ROBUST_UNLOCK`` operation feature flag for the
|
||||
``futex()`` system call, which must be used with one of the following
|
||||
operations: ``FUTEX_WAKE``, ``FUTEX_WAKE_BITSET`` or ``FUTEX_UNLOCK_PI``.
|
||||
The kernel will release the lock (set the futex word to zero), clean the
|
||||
``list_op_pending`` field. Then, it will proceed with the normal wake path.
|
||||
|
||||
For the non-contended path, there's still a race between checking the futex word
|
||||
and clearing the ``list_op_pending`` field. To solve this without the need of a
|
||||
complete system call, userspace should call the virtual syscall
|
||||
``__vdso_futex_robust_listXX_try_unlock()`` (where XX is either 32 or 64,
|
||||
depending on the size of the pointer). If the vDSO call succeeds, it means that
|
||||
it released the lock and cleared ``list_op_pending``. If it fails, that means
|
||||
that there are waiters for this lock and a call to ``futex()`` syscall with
|
||||
``FUTEX_ROBUST_UNLOCK`` is needed.
|
||||
|
|
|
|||
|
|
@ -94,7 +94,7 @@ time, the kernel checks this user-space list: are there any robust futex
|
|||
locks to be cleaned up?
|
||||
|
||||
In the common case, at do_exit() time, there is no list registered, so
|
||||
the cost of robust futexes is just a simple current->robust_list != NULL
|
||||
the cost of robust futexes is just a current->futex.robust_list != NULL
|
||||
comparison. If the thread has registered a list, then normally the list
|
||||
is empty. If the thread/process crashed or terminated in some incorrect
|
||||
way then the list might be non-empty: in this case the kernel carefully
|
||||
|
|
@ -178,9 +178,9 @@ one to query the registered list pointer::
|
|||
size_t __user *len_ptr);
|
||||
|
||||
List registration is very fast: the pointer is simply stored in
|
||||
current->robust_list. [Note that in the future, if robust futexes become
|
||||
widespread, we could extend sys_clone() to register a robust-list head
|
||||
for new threads, without the need of another syscall.]
|
||||
current->futex.robust_list. [Note that in the future, if robust futexes
|
||||
become widespread, we could extend sys_clone() to register a robust-list
|
||||
head for new threads, without the need of another syscall.]
|
||||
|
||||
So there is virtually zero overhead for tasks not using robust futexes,
|
||||
and even for robust futex users, there is only one extra syscall per
|
||||
|
|
|
|||
14
MAINTAINERS
14
MAINTAINERS
|
|
@ -23482,6 +23482,20 @@ S: Maintained
|
|||
T: git https://github.com/Rust-for-Linux/linux.git rust-analyzer-next
|
||||
F: scripts/generate_rust_analyzer.py
|
||||
|
||||
RUST [SYNC]
|
||||
M: Boqun Feng <boqun@kernel.org>
|
||||
M: Gary Guo <gary@garyguo.net>
|
||||
M: Alice Ryhl <aliceryhl@google.com>
|
||||
R: Lyude Paul <lyude@redhat.com>
|
||||
R: Daniel Almeida <daniel.almeida@collabora.com>
|
||||
R: "Onur Özkan" <work@onurozkan.dev>
|
||||
L: linux-kernel@vger.kernel.org
|
||||
L: rust-for-linux@vger.kernel.org
|
||||
S: Maintained
|
||||
T: git git://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git rust-sync
|
||||
F: rust/kernel/sync.rs
|
||||
F: rust/kernel/sync/
|
||||
|
||||
RXRPC SOCKETS (AF_RXRPC)
|
||||
M: David Howells <dhowells@redhat.com>
|
||||
M: Marc Dionne <marc.dionne@auristor.com>
|
||||
|
|
|
|||
|
|
@ -403,6 +403,10 @@ config ARCH_32BIT_OFF_T
|
|||
config ARCH_32BIT_USTAT_F_TINODE
|
||||
bool
|
||||
|
||||
# Selected by architectures with Total Store Order (TSO)
|
||||
config ARCH_MEMORY_ORDER_TSO
|
||||
bool
|
||||
|
||||
config HAVE_ASM_MODVERSIONS
|
||||
bool
|
||||
help
|
||||
|
|
|
|||
|
|
@ -71,7 +71,8 @@ USER_CFLAGS = $(patsubst $(KERNEL_DEFINES),,$(patsubst -I%,,$(KBUILD_CFLAGS))) \
|
|||
-D_FILE_OFFSET_BITS=64 -idirafter $(srctree)/include \
|
||||
-idirafter $(objtree)/include -D__KERNEL__ -D__UM_HOST__ \
|
||||
-include $(srctree)/include/linux/compiler-version.h \
|
||||
-include $(srctree)/include/linux/kconfig.h
|
||||
-include $(srctree)/include/linux/kconfig.h \
|
||||
-idirafter $(ARCH_DIR)/include/generated
|
||||
|
||||
#This will adjust *FLAGS accordingly to the platform.
|
||||
include $(srctree)/$(ARCH_DIR)/Makefile-os-Linux
|
||||
|
|
|
|||
|
|
@ -16,6 +16,7 @@ generic-y += module.h
|
|||
generic-y += module.lds.h
|
||||
generic-y += parport.h
|
||||
generic-y += percpu.h
|
||||
generic-y += percpu_types.h
|
||||
generic-y += preempt.h
|
||||
generic-y += ring_buffer.h
|
||||
generic-y += runtime-const.h
|
||||
|
|
|
|||
|
|
@ -113,6 +113,7 @@ config X86
|
|||
select ARCH_HAS_ZONE_DMA_SET if EXPERT
|
||||
select ARCH_HAVE_NMI_SAFE_CMPXCHG
|
||||
select ARCH_HAVE_EXTRA_ELF_NOTES
|
||||
select ARCH_MEMORY_ORDER_TSO
|
||||
select ARCH_MHP_MEMMAP_ON_MEMORY_ENABLE
|
||||
select ARCH_MIGHT_HAVE_ACPI_PDC if ACPI
|
||||
select ARCH_MIGHT_HAVE_PC_PARPORT
|
||||
|
|
@ -235,6 +236,7 @@ config X86
|
|||
select HAVE_EFFICIENT_UNALIGNED_ACCESS
|
||||
select HAVE_EISA if X86_32
|
||||
select HAVE_EXIT_THREAD
|
||||
select HAVE_FUTEX_ROBUST_UNLOCK
|
||||
select HAVE_GENERIC_TIF_BITS
|
||||
select HAVE_GUP_FAST
|
||||
select HAVE_FENTRY if X86_64 || DYNAMIC_FTRACE
|
||||
|
|
|
|||
71
arch/x86/entry/vdso/common/vfutex.c
Normal file
71
arch/x86/entry/vdso/common/vfutex.c
Normal file
|
|
@ -0,0 +1,71 @@
|
|||
// SPDX-License-Identifier: GPL-2.0-only
|
||||
#include <vdso/futex.h>
|
||||
|
||||
/*
|
||||
* Assembly template for the try unlock functions. The basic functionality is:
|
||||
*
|
||||
* mov esi, %eax Move the TID into EAX
|
||||
* xor %ecx, %ecx Clear ECX
|
||||
* lock_cmpxchgl %ecx, (%rdi) Attempt the TID -> 0 transition
|
||||
* .Lcs_start: Start of the critical section
|
||||
* jnz .Lcs_end If cmpxchl failed jump to the end
|
||||
* .Lcs_success: Start of the success section
|
||||
* movq %rcx, (%rdx) Set the pending op pointer to 0
|
||||
* .Lcs_end: End of the critical section
|
||||
*
|
||||
* .Lcs_start and .Lcs_end establish the critical section range. .Lcs_success is
|
||||
* technically not required, but there for illustration, debugging and testing.
|
||||
*
|
||||
* When CONFIG_COMPAT is enabled then the 64-bit VDSO provides two functions.
|
||||
* One for the regular 64-bit sized pending operation pointer and one for a
|
||||
* 32-bit sized pointer to support gaming emulators.
|
||||
*
|
||||
* The 32-bit VDSO provides only the one for 32-bit sized pointers.
|
||||
*/
|
||||
#define __stringify_1(x...) #x
|
||||
#define __stringify(x...) __stringify_1(x)
|
||||
|
||||
#define LABEL(prefix, which) __stringify(prefix##_try_unlock_cs_##which:)
|
||||
|
||||
#define JNZ_END(prefix) "jnz " __stringify(prefix) "_try_unlock_cs_end\n"
|
||||
|
||||
#define CLEAR_POPQ "movq %[zero], %a[pop]\n"
|
||||
#define CLEAR_POPL "movl %k[zero], %a[pop]\n"
|
||||
|
||||
#define futex_robust_try_unlock(prefix, clear_pop, __lock, __tid, __pop)\
|
||||
({ \
|
||||
asm volatile ( \
|
||||
" \n" \
|
||||
" lock cmpxchgl %k[zero], %a[lock] \n" \
|
||||
" \n" \
|
||||
LABEL(prefix, start) \
|
||||
" \n" \
|
||||
JNZ_END(prefix) \
|
||||
" \n" \
|
||||
LABEL(prefix, success) \
|
||||
" \n" \
|
||||
clear_pop \
|
||||
" \n" \
|
||||
LABEL(prefix, end) \
|
||||
: [tid] "+&a" (__tid) \
|
||||
: [lock] "D" (__lock), \
|
||||
[pop] "d" (__pop), \
|
||||
[zero] "r" (0UL) \
|
||||
: "memory" \
|
||||
); \
|
||||
__tid; \
|
||||
})
|
||||
|
||||
#ifdef __x86_64__
|
||||
__u32 __vdso_futex_robust_list64_try_unlock(__u32 *lock, __u32 tid, __u64 *pop)
|
||||
{
|
||||
return futex_robust_try_unlock(__futex_list64, CLEAR_POPQ, lock, tid, pop);
|
||||
}
|
||||
#endif /* __x86_64__ */
|
||||
|
||||
#if defined(CONFIG_X86_32) || defined(CONFIG_COMPAT)
|
||||
__u32 __vdso_futex_robust_list32_try_unlock(__u32 *lock, __u32 tid, __u32 *pop)
|
||||
{
|
||||
return futex_robust_try_unlock(__futex_list32, CLEAR_POPL, lock, tid, pop);
|
||||
}
|
||||
#endif /* CONFIG_X86_32 || CONFIG_COMPAT */
|
||||
|
|
@ -7,8 +7,9 @@
|
|||
vdsos-y := 32
|
||||
|
||||
# Files to link into the vDSO:
|
||||
vobjs-y := note.o vclock_gettime.o vgetcpu.o
|
||||
vobjs-y += system_call.o sigreturn.o
|
||||
vobjs-y := note.o vclock_gettime.o vgetcpu.o
|
||||
vobjs-y += system_call.o sigreturn.o
|
||||
vobjs-$(CONFIG_FUTEX_ROBUST_UNLOCK) += vfutex.o
|
||||
|
||||
# Compilation flags
|
||||
flags-y := -DBUILD_VDSO32 -m32 -mregparm=0
|
||||
|
|
|
|||
|
|
@ -30,6 +30,9 @@ VERSION
|
|||
__vdso_clock_gettime64;
|
||||
__vdso_clock_getres_time64;
|
||||
__vdso_getcpu;
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
__vdso_futex_robust_list32_try_unlock;
|
||||
#endif
|
||||
};
|
||||
|
||||
LINUX_2.5 {
|
||||
|
|
|
|||
1
arch/x86/entry/vdso/vdso32/vfutex.c
Normal file
1
arch/x86/entry/vdso/vdso32/vfutex.c
Normal file
|
|
@ -0,0 +1 @@
|
|||
#include "common/vfutex.c"
|
||||
|
|
@ -8,9 +8,10 @@ vdsos-y := 64
|
|||
vdsos-$(CONFIG_X86_X32_ABI) += x32
|
||||
|
||||
# Files to link into the vDSO:
|
||||
vobjs-y := note.o vclock_gettime.o vgetcpu.o
|
||||
vobjs-y += vgetrandom.o vgetrandom-chacha.o
|
||||
vobjs-$(CONFIG_X86_SGX) += vsgx.o
|
||||
vobjs-y := note.o vclock_gettime.o vgetcpu.o
|
||||
vobjs-y += vgetrandom.o vgetrandom-chacha.o
|
||||
vobjs-$(CONFIG_X86_SGX) += vsgx.o
|
||||
vobjs-$(CONFIG_FUTEX_ROBUST_UNLOCK) += vfutex.o
|
||||
|
||||
# Compilation flags
|
||||
flags-y := -DBUILD_VDSO64 -m64 -mcmodel=small
|
||||
|
|
|
|||
|
|
@ -32,6 +32,13 @@ VERSION {
|
|||
#endif
|
||||
getrandom;
|
||||
__vdso_getrandom;
|
||||
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
__vdso_futex_robust_list64_try_unlock;
|
||||
#ifdef CONFIG_COMPAT
|
||||
__vdso_futex_robust_list32_try_unlock;
|
||||
#endif
|
||||
#endif
|
||||
local: *;
|
||||
};
|
||||
}
|
||||
|
|
|
|||
|
|
@ -22,6 +22,13 @@ VERSION {
|
|||
__vdso_getcpu;
|
||||
__vdso_time;
|
||||
__vdso_clock_getres;
|
||||
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
__vdso_futex_robust_list64_try_unlock;
|
||||
#ifdef CONFIG_COMPAT
|
||||
__vdso_futex_robust_list32_try_unlock;
|
||||
#endif
|
||||
#endif
|
||||
local: *;
|
||||
};
|
||||
}
|
||||
|
|
|
|||
1
arch/x86/entry/vdso/vdso64/vfutex.c
Normal file
1
arch/x86/entry/vdso/vdso64/vfutex.c
Normal file
|
|
@ -0,0 +1 @@
|
|||
#include "common/vfutex.c"
|
||||
|
|
@ -6,6 +6,7 @@
|
|||
*/
|
||||
#include <linux/mm.h>
|
||||
#include <linux/err.h>
|
||||
#include <linux/futex.h>
|
||||
#include <linux/sched.h>
|
||||
#include <linux/sched/task_stack.h>
|
||||
#include <linux/slab.h>
|
||||
|
|
@ -73,6 +74,31 @@ static void vdso_fix_landing(const struct vdso_image *image,
|
|||
regs->ip = new_vma->vm_start + ipoffset;
|
||||
}
|
||||
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
static void vdso_futex_robust_unlock_update_ips(void)
|
||||
{
|
||||
const struct vdso_image *image = current->mm->context.vdso_image;
|
||||
unsigned long vdso = (unsigned long) current->mm->context.vdso;
|
||||
struct futex_mm_data *fd = ¤t->mm->futex;
|
||||
unsigned int idx = 0;
|
||||
|
||||
futex_reset_cs_ranges(fd);
|
||||
|
||||
#ifdef CONFIG_X86_64
|
||||
futex_set_vdso_cs_range(fd, idx, vdso + image->sym___futex_list64_try_unlock_cs_start,
|
||||
vdso + image->sym___futex_list64_try_unlock_cs_end, false);
|
||||
idx++;
|
||||
#endif /* CONFIG_X86_64 */
|
||||
|
||||
#if defined(CONFIG_X86_32) || defined(CONFIG_COMPAT)
|
||||
futex_set_vdso_cs_range(fd, idx, vdso + image->sym___futex_list32_try_unlock_cs_start,
|
||||
vdso + image->sym___futex_list32_try_unlock_cs_end, true);
|
||||
#endif /* CONFIG_X86_32 || CONFIG_COMPAT */
|
||||
}
|
||||
#else
|
||||
static inline void vdso_futex_robust_unlock_update_ips(void) { }
|
||||
#endif
|
||||
|
||||
static int vdso_mremap(const struct vm_special_mapping *sm,
|
||||
struct vm_area_struct *new_vma)
|
||||
{
|
||||
|
|
@ -80,6 +106,7 @@ static int vdso_mremap(const struct vm_special_mapping *sm,
|
|||
|
||||
vdso_fix_landing(image, new_vma);
|
||||
current->mm->context.vdso = (void __user *)new_vma->vm_start;
|
||||
vdso_futex_robust_unlock_update_ips();
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
@ -185,6 +212,8 @@ static int map_vdso(const struct vdso_image *image, unsigned long addr)
|
|||
current->mm->context.vdso = (void __user *)text_start;
|
||||
current->mm->context.vdso_image = image;
|
||||
|
||||
vdso_futex_robust_unlock_update_ips();
|
||||
|
||||
up_fail:
|
||||
mmap_write_unlock(mm);
|
||||
return ret;
|
||||
|
|
|
|||
19
arch/x86/include/asm/futex_robust.h
Normal file
19
arch/x86/include/asm/futex_robust.h
Normal file
|
|
@ -0,0 +1,19 @@
|
|||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
#ifndef _ASM_X86_FUTEX_ROBUST_H
|
||||
#define _ASM_X86_FUTEX_ROBUST_H
|
||||
|
||||
#include <asm/ptrace.h>
|
||||
|
||||
static __always_inline void __user *x86_futex_robust_unlock_get_pop(struct pt_regs *regs)
|
||||
{
|
||||
/*
|
||||
* If ZF is set then the cmpxchg succeeded and the pending op pointer
|
||||
* needs to be cleared.
|
||||
*/
|
||||
return regs->flags & X86_EFLAGS_ZF ? (void __user *)regs->dx : NULL;
|
||||
}
|
||||
|
||||
#define arch_futex_robust_unlock_get_pop(regs) \
|
||||
x86_futex_robust_unlock_get_pop(regs)
|
||||
|
||||
#endif /* _ASM_X86_FUTEX_ROBUST_H */
|
||||
|
|
@ -40,12 +40,10 @@
|
|||
#endif
|
||||
|
||||
#define __percpu_prefix
|
||||
#define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg)
|
||||
|
||||
#else /* !CONFIG_CC_HAS_NAMED_AS: */
|
||||
|
||||
#define __percpu_prefix __force_percpu_prefix
|
||||
#define __percpu_seg_override
|
||||
|
||||
#endif /* CONFIG_CC_HAS_NAMED_AS */
|
||||
|
||||
|
|
@ -82,7 +80,6 @@
|
|||
|
||||
#define __force_percpu_prefix
|
||||
#define __percpu_prefix
|
||||
#define __percpu_seg_override
|
||||
|
||||
#define PER_CPU_VAR(var) (var)__percpu_rel
|
||||
|
||||
|
|
@ -92,8 +89,6 @@
|
|||
# define __my_cpu_type(var) typeof(var)
|
||||
# define __my_cpu_ptr(ptr) (ptr)
|
||||
# define __my_cpu_var(var) (var)
|
||||
|
||||
# define __percpu_qual __percpu_seg_override
|
||||
#else
|
||||
# define __my_cpu_type(var) typeof(var) __percpu_seg_override
|
||||
# define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr)
|
||||
|
|
|
|||
17
arch/x86/include/asm/percpu_types.h
Normal file
17
arch/x86/include/asm/percpu_types.h
Normal file
|
|
@ -0,0 +1,17 @@
|
|||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
#ifndef _ASM_X86_PERCPU_TYPES_H
|
||||
#define _ASM_X86_PERCPU_TYPES_H
|
||||
|
||||
#if defined(CONFIG_SMP) && defined(CONFIG_CC_HAS_NAMED_AS)
|
||||
#define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg)
|
||||
#else /* !CONFIG_CC_HAS_NAMED_AS: */
|
||||
#define __percpu_seg_override
|
||||
#endif
|
||||
|
||||
#if defined(CONFIG_USE_X86_SEG_SUPPORT) && defined(USE_TYPEOF_UNQUAL)
|
||||
#define __percpu_qual __percpu_seg_override
|
||||
#endif
|
||||
|
||||
#include <asm-generic/percpu_types.h>
|
||||
|
||||
#endif
|
||||
|
|
@ -24,6 +24,10 @@ struct vdso_image {
|
|||
long sym_int80_landing_pad;
|
||||
long sym_vdso32_sigreturn_landing_pad;
|
||||
long sym_vdso32_rt_sigreturn_landing_pad;
|
||||
long sym___futex_list64_try_unlock_cs_start;
|
||||
long sym___futex_list64_try_unlock_cs_end;
|
||||
long sym___futex_list32_try_unlock_cs_start;
|
||||
long sym___futex_list32_try_unlock_cs_end;
|
||||
};
|
||||
|
||||
extern const struct vdso_image vdso64_image;
|
||||
|
|
|
|||
|
|
@ -75,12 +75,16 @@ struct vdso_sym {
|
|||
};
|
||||
|
||||
struct vdso_sym required_syms[] = {
|
||||
{"__kernel_vsyscall", true},
|
||||
{"__kernel_sigreturn", true},
|
||||
{"__kernel_rt_sigreturn", true},
|
||||
{"int80_landing_pad", true},
|
||||
{"vdso32_rt_sigreturn_landing_pad", true},
|
||||
{"vdso32_sigreturn_landing_pad", true},
|
||||
{"__kernel_vsyscall", true},
|
||||
{"__kernel_sigreturn", true},
|
||||
{"__kernel_rt_sigreturn", true},
|
||||
{"int80_landing_pad", true},
|
||||
{"vdso32_rt_sigreturn_landing_pad", true},
|
||||
{"vdso32_sigreturn_landing_pad", true},
|
||||
{"__futex_list64_try_unlock_cs_start", true},
|
||||
{"__futex_list64_try_unlock_cs_end", true},
|
||||
{"__futex_list32_try_unlock_cs_start", true},
|
||||
{"__futex_list32_try_unlock_cs_end", true},
|
||||
};
|
||||
|
||||
__attribute__((format(printf, 1, 2))) __attribute__((noreturn))
|
||||
|
|
|
|||
|
|
@ -632,8 +632,11 @@ u64 nd_region_interleave_set_cookie(struct nd_region *nd_region,
|
|||
u64 nd_region_interleave_set_altcookie(struct nd_region *nd_region);
|
||||
void nvdimm_bus_lock(struct device *dev);
|
||||
void nvdimm_bus_unlock(struct device *dev);
|
||||
DEFINE_GUARD(nvdimm_bus, struct device *,
|
||||
if (_T) nvdimm_bus_lock(_T), if (_T) nvdimm_bus_unlock(_T));
|
||||
DEFINE_CLASS(nvdimm_bus, struct device *,
|
||||
if (_T) nvdimm_bus_unlock(_T),
|
||||
({ if (_T) nvdimm_bus_lock(_T); _T; }),
|
||||
struct device *_T);
|
||||
DEFINE_CLASS_IS_GUARD(nvdimm_bus);
|
||||
|
||||
bool is_nvdimm_bus_locked(struct device *dev);
|
||||
void nvdimm_check_and_set_ro(struct gendisk *disk);
|
||||
|
|
|
|||
|
|
@ -44,6 +44,7 @@ mandatory-y += module.lds.h
|
|||
mandatory-y += msi.h
|
||||
mandatory-y += pci.h
|
||||
mandatory-y += percpu.h
|
||||
mandatory-y += percpu_types.h
|
||||
mandatory-y += pgalloc.h
|
||||
mandatory-y += preempt.h
|
||||
mandatory-y += rqspinlock.h
|
||||
|
|
|
|||
|
|
@ -235,7 +235,7 @@ do { \
|
|||
/**
|
||||
* smp_cond_load_relaxed() - (Spin) wait for cond with no ordering guarantees
|
||||
* @ptr: pointer to the variable to wait on
|
||||
* @cond: boolean expression to wait for
|
||||
* @cond_expr: boolean expression to wait for
|
||||
*
|
||||
* Equivalent to using READ_ONCE() on the condition variable.
|
||||
*
|
||||
|
|
@ -259,7 +259,7 @@ do { \
|
|||
/**
|
||||
* smp_cond_load_acquire() - (Spin) wait for cond with ACQUIRE ordering
|
||||
* @ptr: pointer to the variable to wait on
|
||||
* @cond: boolean expression to wait for
|
||||
* @cond_expr: boolean expression to wait for
|
||||
*
|
||||
* Equivalent to using smp_load_acquire() on the condition variable but employs
|
||||
* the control dependency of the wait to reduce the barrier on many platforms.
|
||||
|
|
|
|||
19
include/asm-generic/percpu_types.h
Normal file
19
include/asm-generic/percpu_types.h
Normal file
|
|
@ -0,0 +1,19 @@
|
|||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
#ifndef _ASM_GENERIC_PERCPU_TYPES_H_
|
||||
#define _ASM_GENERIC_PERCPU_TYPES_H_
|
||||
|
||||
#ifndef __ASSEMBLER__
|
||||
/*
|
||||
* __percpu_qual is the qualifier for the percpu named address space.
|
||||
*
|
||||
* Most architectures use generic named address space for percpu variables but
|
||||
* some architectures define percpu variables in different named address space.
|
||||
* E.g. on x86, percpu variable may be declared as being relative to the %fs or
|
||||
* %gs segments using __seg_fs or __seg_gs named address space qualifier.
|
||||
*/
|
||||
#ifndef __percpu_qual
|
||||
# define __percpu_qual
|
||||
#endif
|
||||
|
||||
#endif /* __ASSEMBLER__ */
|
||||
#endif /* _ASM_GENERIC_PERCPU_TYPES_H_ */
|
||||
|
|
@ -53,8 +53,7 @@ typedef struct qspinlock {
|
|||
*
|
||||
* When NR_CPUS < 16K
|
||||
* 0- 7: locked byte
|
||||
* 8: pending
|
||||
* 9-15: not used
|
||||
* 8-15: pending byte
|
||||
* 16-17: tail index
|
||||
* 18-31: tail cpu (+1)
|
||||
*
|
||||
|
|
|
|||
|
|
@ -397,7 +397,8 @@ static __maybe_unused const bool class_##_name##_is_conditional = _is_cond
|
|||
__DEFINE_GUARD_LOCK_PTR(_name, _T)
|
||||
|
||||
#define DEFINE_GUARD(_name, _type, _lock, _unlock) \
|
||||
DEFINE_CLASS(_name, _type, if (_T) { _unlock; }, ({ _lock; _T; }), _type _T); \
|
||||
static __always_inline __nonnull_args(1) _type class_##_name##_constructor(_type _T); \
|
||||
DEFINE_CLASS(_name, _type, _unlock, ({ _lock; _T; }), _type _T); \
|
||||
DEFINE_CLASS_IS_GUARD(_name)
|
||||
|
||||
#define DEFINE_GUARD_COND_4(_name, _ext, _lock, _cond) \
|
||||
|
|
@ -491,13 +492,14 @@ typedef struct { \
|
|||
static __always_inline void class_##_name##_destructor(class_##_name##_t *_T) \
|
||||
__no_context_analysis \
|
||||
{ \
|
||||
if (_T->lock) { _unlock; } \
|
||||
_unlock; \
|
||||
} \
|
||||
\
|
||||
__DEFINE_GUARD_LOCK_PTR(_name, &_T->lock)
|
||||
|
||||
#define __DEFINE_LOCK_GUARD_1(_name, _type, ...) \
|
||||
static __always_inline class_##_name##_t class_##_name##_constructor(_type *l) \
|
||||
static __always_inline __nonnull_args(1) \
|
||||
class_##_name##_t class_##_name##_constructor(_type *l) \
|
||||
__no_context_analysis \
|
||||
{ \
|
||||
class_##_name##_t _t = { .lock = l }, *_T = &_t; \
|
||||
|
|
|
|||
|
|
@ -39,12 +39,14 @@
|
|||
# define __assumes_shared_ctx_lock(...) __attribute__((assert_shared_capability(__VA_ARGS__)))
|
||||
|
||||
/**
|
||||
* __guarded_by - struct member and globals attribute, declares variable
|
||||
* only accessible within active context
|
||||
* __guarded_by() - struct member and globals attribute, declares variable
|
||||
* only accessible within active context
|
||||
* @...: context lock instance pointer(s)
|
||||
*
|
||||
* Declares that the struct member or global variable is only accessible within
|
||||
* the context entered by the given context lock. Read operations on the data
|
||||
* require shared access, while write operations require exclusive access.
|
||||
* the context entered by the given context lock(s). Read operations on the data
|
||||
* require shared access to at least one of the context locks, while write
|
||||
* operations require exclusive access to all listed context locks.
|
||||
*
|
||||
* .. code-block:: c
|
||||
*
|
||||
|
|
@ -52,17 +54,24 @@
|
|||
* spinlock_t lock;
|
||||
* long counter __guarded_by(&lock);
|
||||
* };
|
||||
*
|
||||
* struct some_state {
|
||||
* spinlock_t lock1, lock2;
|
||||
* long counter __guarded_by(&lock1, &lock2);
|
||||
* };
|
||||
*/
|
||||
# define __guarded_by(...) __attribute__((guarded_by(__VA_ARGS__)))
|
||||
|
||||
/**
|
||||
* __pt_guarded_by - struct member and globals attribute, declares pointed-to
|
||||
* data only accessible within active context
|
||||
* __pt_guarded_by() - struct member and globals attribute, declares pointed-to
|
||||
* data only accessible within active context
|
||||
* @...: context lock instance pointer(s)
|
||||
*
|
||||
* Declares that the data pointed to by the struct member pointer or global
|
||||
* pointer is only accessible within the context entered by the given context
|
||||
* lock. Read operations on the data require shared access, while write
|
||||
* operations require exclusive access.
|
||||
* lock(s). Read operations on the data require shared access to at least one
|
||||
* of the context locks, while write operations require exclusive access to all
|
||||
* listed context locks.
|
||||
*
|
||||
* .. code-block:: c
|
||||
*
|
||||
|
|
@ -70,6 +79,11 @@
|
|||
* spinlock_t lock;
|
||||
* long *counter __pt_guarded_by(&lock);
|
||||
* };
|
||||
*
|
||||
* struct some_state {
|
||||
* spinlock_t lock1, lock2;
|
||||
* long *counter __pt_guarded_by(&lock1, &lock2);
|
||||
* };
|
||||
*/
|
||||
# define __pt_guarded_by(...) __attribute__((pt_guarded_by(__VA_ARGS__)))
|
||||
|
||||
|
|
|
|||
|
|
@ -230,6 +230,15 @@
|
|||
*/
|
||||
#define noinline __attribute__((__noinline__))
|
||||
|
||||
/*
|
||||
* Note: deliberately not named '__nonnull', to avoid clashing with glibc's
|
||||
* __nonnull() when kernel and userspace headers are combined.
|
||||
*
|
||||
* gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Attributes.html#index-nonnull
|
||||
* clang: https://clang.llvm.org/docs/AttributeReference.html#nonnull
|
||||
*/
|
||||
#define __nonnull_args(x...) __attribute__((__nonnull__(x)))
|
||||
|
||||
/*
|
||||
* Optional: only supported since gcc >= 8
|
||||
* Optional: not supported by clang
|
||||
|
|
|
|||
|
|
@ -634,6 +634,9 @@ struct ftrace_likely_data {
|
|||
#else
|
||||
#define __unqual_scalar_typeof(x) __typeof_unqual__(x)
|
||||
#endif
|
||||
|
||||
#include <asm/percpu_types.h>
|
||||
|
||||
#endif /* !__ASSEMBLY__ */
|
||||
|
||||
/*
|
||||
|
|
|
|||
|
|
@ -64,14 +64,10 @@ enum {
|
|||
|
||||
static inline void futex_init_task(struct task_struct *tsk)
|
||||
{
|
||||
tsk->robust_list = NULL;
|
||||
#ifdef CONFIG_COMPAT
|
||||
tsk->compat_robust_list = NULL;
|
||||
#endif
|
||||
INIT_LIST_HEAD(&tsk->pi_state_list);
|
||||
tsk->pi_state_cache = NULL;
|
||||
tsk->futex_state = FUTEX_STATE_OK;
|
||||
mutex_init(&tsk->futex_exit_mutex);
|
||||
memset(&tsk->futex, 0, sizeof(tsk->futex));
|
||||
INIT_LIST_HEAD(&tsk->futex.pi_state_list);
|
||||
tsk->futex.state = FUTEX_STATE_OK;
|
||||
mutex_init(&tsk->futex.exit_mutex);
|
||||
}
|
||||
|
||||
void futex_exit_recursive(struct task_struct *tsk);
|
||||
|
|
@ -85,22 +81,18 @@ int futex_hash_prctl(unsigned long arg2, unsigned long arg3, unsigned long arg4)
|
|||
#ifdef CONFIG_FUTEX_PRIVATE_HASH
|
||||
int futex_hash_allocate_default(void);
|
||||
void futex_hash_free(struct mm_struct *mm);
|
||||
int futex_mm_init(struct mm_struct *mm);
|
||||
|
||||
#else /* !CONFIG_FUTEX_PRIVATE_HASH */
|
||||
#else /* CONFIG_FUTEX_PRIVATE_HASH */
|
||||
static inline int futex_hash_allocate_default(void) { return 0; }
|
||||
static inline int futex_hash_free(struct mm_struct *mm) { return 0; }
|
||||
static inline int futex_mm_init(struct mm_struct *mm) { return 0; }
|
||||
#endif /* CONFIG_FUTEX_PRIVATE_HASH */
|
||||
#endif /* !CONFIG_FUTEX_PRIVATE_HASH */
|
||||
|
||||
#else /* !CONFIG_FUTEX */
|
||||
#else /* CONFIG_FUTEX */
|
||||
static inline void futex_init_task(struct task_struct *tsk) { }
|
||||
static inline void futex_exit_recursive(struct task_struct *tsk) { }
|
||||
static inline void futex_exit_release(struct task_struct *tsk) { }
|
||||
static inline void futex_exec_release(struct task_struct *tsk) { }
|
||||
static inline long do_futex(u32 __user *uaddr, int op, u32 val,
|
||||
ktime_t *timeout, u32 __user *uaddr2,
|
||||
u32 val2, u32 val3)
|
||||
static inline long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
|
||||
u32 __user *uaddr2, u32 val2, u32 val3)
|
||||
{
|
||||
return -EINVAL;
|
||||
}
|
||||
|
|
@ -108,13 +100,63 @@ static inline int futex_hash_prctl(unsigned long arg2, unsigned long arg3, unsig
|
|||
{
|
||||
return -EINVAL;
|
||||
}
|
||||
static inline int futex_hash_allocate_default(void)
|
||||
{
|
||||
return 0;
|
||||
}
|
||||
static inline int futex_hash_allocate_default(void) { return 0; }
|
||||
static inline int futex_hash_free(struct mm_struct *mm) { return 0; }
|
||||
static inline int futex_mm_init(struct mm_struct *mm) { return 0; }
|
||||
#endif /* !CONFIG_FUTEX */
|
||||
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
#include <asm/futex_robust.h>
|
||||
|
||||
void futex_reset_cs_ranges(struct futex_mm_data *fd);
|
||||
void __futex_fixup_robust_unlock(struct pt_regs *regs, struct futex_unlock_cs_range *csr);
|
||||
|
||||
static inline bool futex_within_robust_unlock(struct pt_regs *regs,
|
||||
struct futex_unlock_cs_range *csr)
|
||||
{
|
||||
unsigned long ip = instruction_pointer(regs);
|
||||
|
||||
return ip >= csr->start_ip && ip < csr->start_ip + csr->len;
|
||||
}
|
||||
|
||||
static inline void futex_fixup_robust_unlock(struct pt_regs *regs)
|
||||
{
|
||||
struct futex_unlock_cs_range *csr;
|
||||
|
||||
/*
|
||||
* Avoid dereferencing current->mm if not returning from interrupt.
|
||||
* current->rseq.event is going to be used subsequently, so bringing the
|
||||
* cache line in is not a big deal.
|
||||
*/
|
||||
if (!current->rseq.event.user_irq)
|
||||
return;
|
||||
|
||||
csr = current->mm->futex.unlock.cs_ranges;
|
||||
|
||||
/* The loop is optimized out for !COMPAT */
|
||||
for (int r = 0; r < FUTEX_ROBUST_MAX_CS_RANGES; r++, csr++) {
|
||||
if (unlikely(futex_within_robust_unlock(regs, csr))) {
|
||||
__futex_fixup_robust_unlock(regs, csr);
|
||||
return;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
static inline void futex_set_vdso_cs_range(struct futex_mm_data *fd, unsigned int idx,
|
||||
unsigned long start, unsigned long end, bool sz32)
|
||||
{
|
||||
fd->unlock.cs_ranges[idx].start_ip = start;
|
||||
fd->unlock.cs_ranges[idx].len = end - start;
|
||||
fd->unlock.cs_ranges[idx].pop_size32 = sz32;
|
||||
}
|
||||
#else /* CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
static inline void futex_fixup_robust_unlock(struct pt_regs *regs) { }
|
||||
#endif /* !CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
|
||||
|
||||
#if defined(CONFIG_FUTEX_PRIVATE_HASH) || defined(CONFIG_FUTEX_ROBUST_UNLOCK)
|
||||
void futex_mm_init(struct mm_struct *mm);
|
||||
#else
|
||||
static inline void futex_mm_init(struct mm_struct *mm) { }
|
||||
#endif
|
||||
|
||||
#endif
|
||||
#endif /* _LINUX_FUTEX_H */
|
||||
|
|
|
|||
98
include/linux/futex_types.h
Normal file
98
include/linux/futex_types.h
Normal file
|
|
@ -0,0 +1,98 @@
|
|||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
#ifndef _LINUX_FUTEX_TYPES_H
|
||||
#define _LINUX_FUTEX_TYPES_H
|
||||
|
||||
#ifdef CONFIG_FUTEX
|
||||
#include <linux/compiler_types.h>
|
||||
#include <linux/mutex_types.h>
|
||||
#include <linux/types.h>
|
||||
|
||||
struct compat_robust_list_head;
|
||||
struct futex_pi_state;
|
||||
struct robust_list_head;
|
||||
|
||||
/**
|
||||
* struct futex_sched_data - Futex related per task data
|
||||
* @robust_list: User space registered robust list pointer
|
||||
* @compat_robust_list: User space registered robust list pointer for compat tasks
|
||||
* @pi_state_list: List head for Priority Inheritance (PI) state management
|
||||
* @pi_state_cache: Pointer to cache one PI state object per task
|
||||
* @exit_mutex: Mutex for serializing exit
|
||||
* @state: Futex handling state to handle exit races correctly
|
||||
*/
|
||||
struct futex_sched_data {
|
||||
struct robust_list_head __user *robust_list;
|
||||
#ifdef CONFIG_COMPAT
|
||||
struct compat_robust_list_head __user *compat_robust_list;
|
||||
#endif
|
||||
struct list_head pi_state_list;
|
||||
struct futex_pi_state *pi_state_cache;
|
||||
struct mutex exit_mutex;
|
||||
unsigned int state;
|
||||
};
|
||||
|
||||
#ifdef CONFIG_FUTEX_PRIVATE_HASH
|
||||
/**
|
||||
* struct futex_mm_phash - Futex private hash related per MM data
|
||||
* @lock: Mutex to protect the private hash operations
|
||||
* @hash: RCU managed pointer to the private hash
|
||||
* @hash_new: Pointer to a newly allocated private hash
|
||||
* @batches: Batch state for RCU synchronization
|
||||
* @rcu: RCU head for call_rcu()
|
||||
* @atomic: Aggregate value for @hash_ref
|
||||
* @ref: Per CPU reference counter for a private hash
|
||||
*/
|
||||
struct futex_mm_phash {
|
||||
struct mutex lock;
|
||||
struct futex_private_hash __rcu *hash;
|
||||
struct futex_private_hash *hash_new;
|
||||
unsigned long batches;
|
||||
struct rcu_head rcu;
|
||||
atomic_long_t atomic;
|
||||
unsigned int __percpu *ref;
|
||||
};
|
||||
#else /* CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
struct futex_mm_phash { };
|
||||
#endif /* !CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
|
||||
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
|
||||
/**
|
||||
* struct futex_unlock_cs_range - Range for the VDSO unlock critical section
|
||||
* @start_ip: The start IP of the robust futex unlock critical section (inclusive)
|
||||
* @len: The length of the robust futex unlock critical section
|
||||
* @pop_size32: Pending OP pointer size indicator. 0 == 64-bit, 1 == 32-bit
|
||||
*/
|
||||
struct futex_unlock_cs_range {
|
||||
unsigned long start_ip;
|
||||
unsigned int len;
|
||||
unsigned int pop_size32;
|
||||
};
|
||||
|
||||
#define FUTEX_ROBUST_MAX_CS_RANGES (1 + IS_ENABLED(CONFIG_COMPAT))
|
||||
|
||||
/**
|
||||
* struct futex_unlock_cs_ranges - Futex unlock VSDO critical sections
|
||||
* @cs_ranges: Array of critical section ranges
|
||||
*/
|
||||
struct futex_unlock_cs_ranges {
|
||||
struct futex_unlock_cs_range cs_ranges[FUTEX_ROBUST_MAX_CS_RANGES];
|
||||
};
|
||||
#else /* CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
struct futex_unlock_cs_ranges { };
|
||||
#endif /* !CONFIG_FUTEX_ROBUST_UNLOCK */
|
||||
|
||||
/**
|
||||
* struct futex_mm_data - Futex related per MM data
|
||||
* @phash: Futex private hash related data
|
||||
* @unlock: Futex unlock VDSO critical sections
|
||||
*/
|
||||
struct futex_mm_data {
|
||||
struct futex_mm_phash phash;
|
||||
struct futex_unlock_cs_ranges unlock;
|
||||
};
|
||||
#else /* CONFIG_FUTEX */
|
||||
struct futex_sched_data { };
|
||||
struct futex_mm_data { };
|
||||
#endif /* !CONFIG_FUTEX */
|
||||
|
||||
#endif /* _LINUX_FUTEX_TYPES_H */
|
||||
|
|
@ -20,6 +20,7 @@
|
|||
#include <linux/seqlock.h>
|
||||
#include <linux/percpu_counter.h>
|
||||
#include <linux/types.h>
|
||||
#include <linux/futex_types.h>
|
||||
#include <linux/rseq_types.h>
|
||||
#include <linux/bitmap.h>
|
||||
|
||||
|
|
@ -1270,16 +1271,7 @@ struct mm_struct {
|
|||
*/
|
||||
seqcount_t mm_lock_seq;
|
||||
#endif
|
||||
#ifdef CONFIG_FUTEX_PRIVATE_HASH
|
||||
struct mutex futex_hash_lock;
|
||||
struct futex_private_hash __rcu *futex_phash;
|
||||
struct futex_private_hash *futex_phash_new;
|
||||
/* futex-ref */
|
||||
unsigned long futex_batches;
|
||||
struct rcu_head futex_rcu;
|
||||
atomic_long_t futex_atomic;
|
||||
unsigned int __percpu *futex_ref;
|
||||
#endif
|
||||
struct futex_mm_data futex;
|
||||
|
||||
unsigned long hiwater_rss; /* High-watermark of RSS usage */
|
||||
unsigned long hiwater_vm; /* High-water virtual memory usage */
|
||||
|
|
|
|||
|
|
@ -107,6 +107,8 @@ static inline bool percpu_down_read_trylock(struct percpu_rw_semaphore *sem)
|
|||
return ret;
|
||||
}
|
||||
|
||||
extern void __percpu_up_read(struct percpu_rw_semaphore *sem);
|
||||
|
||||
static inline void percpu_up_read(struct percpu_rw_semaphore *sem)
|
||||
{
|
||||
rwsem_release(&sem->dep_map, _RET_IP_);
|
||||
|
|
@ -118,18 +120,7 @@ static inline void percpu_up_read(struct percpu_rw_semaphore *sem)
|
|||
if (likely(rcu_sync_is_idle(&sem->rss))) {
|
||||
this_cpu_dec(*sem->read_count);
|
||||
} else {
|
||||
/*
|
||||
* slowpath; reader will only ever wake a single blocked
|
||||
* writer.
|
||||
*/
|
||||
smp_mb(); /* B matches C */
|
||||
/*
|
||||
* In other words, if they see our decrement (presumably to
|
||||
* aggregate zero, as that is the only time it matters) they
|
||||
* will also see our critical section.
|
||||
*/
|
||||
this_cpu_dec(*sem->read_count);
|
||||
rcuwait_wake_up(&sem->writer);
|
||||
__percpu_up_read(sem);
|
||||
}
|
||||
preempt_enable();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -3,13 +3,14 @@
|
|||
#define __LINUX_PERCPU_H
|
||||
|
||||
#include <linux/alloc_tag.h>
|
||||
#include <linux/mmdebug.h>
|
||||
#include <linux/preempt.h>
|
||||
#include <linux/smp.h>
|
||||
#include <linux/pfn.h>
|
||||
#include <linux/init.h>
|
||||
#include <linux/cleanup.h>
|
||||
#include <linux/compiler_types.h>
|
||||
#include <linux/init.h>
|
||||
#include <linux/mmdebug.h>
|
||||
#include <linux/pfn.h>
|
||||
#include <linux/preempt.h>
|
||||
#include <linux/sched.h>
|
||||
#include <linux/smp.h>
|
||||
|
||||
#include <asm/percpu.h>
|
||||
|
||||
|
|
|
|||
|
|
@ -56,6 +56,8 @@ static inline struct task_struct *rt_mutex_owner(struct rt_mutex_base *lock)
|
|||
#endif
|
||||
extern void rt_mutex_base_init(struct rt_mutex_base *rtb);
|
||||
|
||||
context_lock_struct(rt_mutex);
|
||||
|
||||
/**
|
||||
* The rt_mutex structure
|
||||
*
|
||||
|
|
@ -108,8 +110,10 @@ do { \
|
|||
extern void __rt_mutex_init(struct rt_mutex *lock, const char *name, struct lock_class_key *key);
|
||||
|
||||
#ifdef CONFIG_DEBUG_LOCK_ALLOC
|
||||
extern void rt_mutex_lock_nested(struct rt_mutex *lock, unsigned int subclass);
|
||||
extern void _rt_mutex_lock_nest_lock(struct rt_mutex *lock, struct lockdep_map *nest_lock);
|
||||
extern void rt_mutex_lock_nested(struct rt_mutex *lock, unsigned int subclass)
|
||||
__acquires(lock);
|
||||
extern void _rt_mutex_lock_nest_lock(struct rt_mutex *lock, struct lockdep_map *nest_lock)
|
||||
__acquires(lock);
|
||||
#define rt_mutex_lock(lock) rt_mutex_lock_nested(lock, 0)
|
||||
#define rt_mutex_lock_nest_lock(lock, nest_lock) \
|
||||
do { \
|
||||
|
|
@ -118,15 +122,19 @@ extern void _rt_mutex_lock_nest_lock(struct rt_mutex *lock, struct lockdep_map *
|
|||
} while (0)
|
||||
|
||||
#else
|
||||
extern void rt_mutex_lock(struct rt_mutex *lock);
|
||||
extern void rt_mutex_lock(struct rt_mutex *lock) __acquires(lock);
|
||||
#define rt_mutex_lock_nested(lock, subclass) rt_mutex_lock(lock)
|
||||
#define rt_mutex_lock_nest_lock(lock, nest_lock) rt_mutex_lock(lock)
|
||||
#endif
|
||||
|
||||
extern int rt_mutex_lock_interruptible(struct rt_mutex *lock);
|
||||
extern int rt_mutex_lock_killable(struct rt_mutex *lock);
|
||||
extern int rt_mutex_trylock(struct rt_mutex *lock);
|
||||
extern int rt_mutex_lock_interruptible(struct rt_mutex *lock)
|
||||
__cond_acquires(0, lock);
|
||||
extern int rt_mutex_lock_killable(struct rt_mutex *lock)
|
||||
__cond_acquires(0, lock);
|
||||
extern int rt_mutex_trylock(struct rt_mutex *lock)
|
||||
__cond_acquires(true, lock);
|
||||
|
||||
extern void rt_mutex_unlock(struct rt_mutex *lock);
|
||||
extern void rt_mutex_unlock(struct rt_mutex *lock)
|
||||
__releases(lock);
|
||||
|
||||
#endif
|
||||
|
|
|
|||
|
|
@ -16,6 +16,7 @@
|
|||
#include <linux/cpumask_types.h>
|
||||
|
||||
#include <linux/cache.h>
|
||||
#include <linux/futex_types.h>
|
||||
#include <linux/irqflags_types.h>
|
||||
#include <linux/smp_types.h>
|
||||
#include <linux/pid_types.h>
|
||||
|
|
@ -64,7 +65,6 @@ struct bpf_net_context;
|
|||
struct capture_control;
|
||||
struct cfs_rq;
|
||||
struct fs_struct;
|
||||
struct futex_pi_state;
|
||||
struct io_context;
|
||||
struct io_uring_task;
|
||||
struct mempolicy;
|
||||
|
|
@ -76,7 +76,6 @@ struct pid_namespace;
|
|||
struct pipe_inode_info;
|
||||
struct rcu_node;
|
||||
struct reclaim_state;
|
||||
struct robust_list_head;
|
||||
struct root_domain;
|
||||
struct rq;
|
||||
struct sched_attr;
|
||||
|
|
@ -1334,16 +1333,9 @@ struct task_struct {
|
|||
u32 closid;
|
||||
u32 rmid;
|
||||
#endif
|
||||
#ifdef CONFIG_FUTEX
|
||||
struct robust_list_head __user *robust_list;
|
||||
#ifdef CONFIG_COMPAT
|
||||
struct compat_robust_list_head __user *compat_robust_list;
|
||||
#endif
|
||||
struct list_head pi_state_list;
|
||||
struct futex_pi_state *pi_state_cache;
|
||||
struct mutex futex_exit_mutex;
|
||||
unsigned int futex_state;
|
||||
#endif
|
||||
|
||||
struct futex_sched_data futex;
|
||||
|
||||
#ifdef CONFIG_PERF_EVENTS
|
||||
u8 perf_recursion[PERF_NR_CONTEXTS];
|
||||
struct perf_event_context *perf_event_ctxp;
|
||||
|
|
|
|||
|
|
@ -1259,14 +1259,15 @@ static __always_inline void __scoped_seqlock_cleanup(struct ss_tmp *sst)
|
|||
|
||||
extern void __scoped_seqlock_invalid_target(void);
|
||||
|
||||
#if (defined(CONFIG_CC_IS_GCC) && CONFIG_GCC_VERSION < 90000) || defined(CONFIG_KASAN)
|
||||
#if (defined(CONFIG_CC_IS_GCC) && CONFIG_GCC_VERSION < 90000) || \
|
||||
defined(CONFIG_KASAN) || defined(CONFIG_UBSAN_ALIGNMENT)
|
||||
/*
|
||||
* For some reason some GCC-8 architectures (nios2, alpha) have trouble
|
||||
* determining that the ss_done state is impossible in __scoped_seqlock_next()
|
||||
* below.
|
||||
*
|
||||
* Similarly KASAN is known to confuse compilers enough to break this. But we
|
||||
* don't care about code quality for KASAN builds anyway.
|
||||
* Similarly KASAN and UBSAN_ALIGNMENT are known to confuse compilers enough
|
||||
* to break this. But we don't care about code quality for such builds anyway.
|
||||
*/
|
||||
static inline void __scoped_seqlock_bug(void) { }
|
||||
#else
|
||||
|
|
|
|||
|
|
@ -712,6 +712,17 @@ static inline void user_access_restore(unsigned long flags) { }
|
|||
#define user_read_access_end user_access_end
|
||||
#endif
|
||||
|
||||
#ifndef unsafe_atomic_store_release_user
|
||||
# define unsafe_atomic_store_release_user(val, uptr, elbl) \
|
||||
do { \
|
||||
if (!IS_ENABLED(CONFIG_ARCH_MEMORY_ORDER_TSO)) \
|
||||
smp_mb(); \
|
||||
else \
|
||||
barrier(); \
|
||||
unsafe_put_user(val, uptr, elbl); \
|
||||
} while (0)
|
||||
#endif
|
||||
|
||||
/* Define RW variant so the below _mode macro expansion works */
|
||||
#define masked_user_rw_access_begin(u) masked_user_access_begin(u)
|
||||
#define user_rw_access_begin(u, s) user_access_begin(u, s)
|
||||
|
|
|
|||
|
|
@ -5,7 +5,6 @@
|
|||
#if !defined(_TRACE_LOCK_H) || defined(TRACE_HEADER_MULTI_READ)
|
||||
#define _TRACE_LOCK_H
|
||||
|
||||
#include <linux/sched.h>
|
||||
#include <linux/tracepoint.h>
|
||||
|
||||
/* flags for lock:contention_begin */
|
||||
|
|
@ -138,6 +137,23 @@ TRACE_EVENT(contention_end,
|
|||
TP_printk("%p (ret=%d)", __entry->lock_addr, __entry->ret)
|
||||
);
|
||||
|
||||
TRACE_EVENT(contended_release,
|
||||
|
||||
TP_PROTO(void *lock),
|
||||
|
||||
TP_ARGS(lock),
|
||||
|
||||
TP_STRUCT__entry(
|
||||
__field(void *, lock_addr)
|
||||
),
|
||||
|
||||
TP_fast_assign(
|
||||
__entry->lock_addr = lock;
|
||||
),
|
||||
|
||||
TP_printk("%p", __entry->lock_addr)
|
||||
);
|
||||
|
||||
#endif /* _TRACE_LOCK_H */
|
||||
|
||||
/* This part must be outside protection */
|
||||
|
|
|
|||
|
|
@ -25,23 +25,49 @@
|
|||
|
||||
#define FUTEX_PRIVATE_FLAG 128
|
||||
#define FUTEX_CLOCK_REALTIME 256
|
||||
#define FUTEX_CMD_MASK ~(FUTEX_PRIVATE_FLAG | FUTEX_CLOCK_REALTIME)
|
||||
#define FUTEX_ROBUST_UNLOCK 512
|
||||
#define FUTEX_ROBUST_LIST32 1024
|
||||
|
||||
#define FUTEX_WAIT_PRIVATE (FUTEX_WAIT | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAKE_PRIVATE (FUTEX_WAKE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_REQUEUE_PRIVATE (FUTEX_REQUEUE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_CMP_REQUEUE_PRIVATE (FUTEX_CMP_REQUEUE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAKE_OP_PRIVATE (FUTEX_WAKE_OP | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_LOCK_PI_PRIVATE (FUTEX_LOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_LOCK_PI2_PRIVATE (FUTEX_LOCK_PI2 | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_UNLOCK_PI_PRIVATE (FUTEX_UNLOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_TRYLOCK_PI_PRIVATE (FUTEX_TRYLOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_CMD_MASK ~(FUTEX_PRIVATE_FLAG | FUTEX_CLOCK_REALTIME | \
|
||||
FUTEX_ROBUST_UNLOCK | FUTEX_ROBUST_LIST32)
|
||||
|
||||
#define FUTEX_WAIT_PRIVATE (FUTEX_WAIT | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAKE_PRIVATE (FUTEX_WAKE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_REQUEUE_PRIVATE (FUTEX_REQUEUE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_CMP_REQUEUE_PRIVATE (FUTEX_CMP_REQUEUE | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAKE_OP_PRIVATE (FUTEX_WAKE_OP | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_LOCK_PI_PRIVATE (FUTEX_LOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_LOCK_PI2_PRIVATE (FUTEX_LOCK_PI2 | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_UNLOCK_PI_PRIVATE (FUTEX_UNLOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_TRYLOCK_PI_PRIVATE (FUTEX_TRYLOCK_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAIT_BITSET_PRIVATE (FUTEX_WAIT_BITSET | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAKE_BITSET_PRIVATE (FUTEX_WAKE_BITSET | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAIT_REQUEUE_PI_PRIVATE (FUTEX_WAIT_REQUEUE_PI | \
|
||||
FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_CMP_REQUEUE_PI_PRIVATE (FUTEX_CMP_REQUEUE_PI | \
|
||||
FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_WAIT_REQUEUE_PI_PRIVATE (FUTEX_WAIT_REQUEUE_PI | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_CMP_REQUEUE_PI_PRIVATE (FUTEX_CMP_REQUEUE_PI | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
/*
|
||||
* Operations to unlock a futex, clear the robust list pending op pointer and
|
||||
* wake waiters.
|
||||
*/
|
||||
#define FUTEX_UNLOCK_PI_LIST64 (FUTEX_UNLOCK_PI | FUTEX_ROBUST_UNLOCK)
|
||||
#define FUTEX_UNLOCK_PI_LIST64_PRIVATE (FUTEX_UNLOCK_PI_LIST64 | FUTEX_PRIVATE_FLAG)
|
||||
#define FUTEX_UNLOCK_PI_LIST32 (FUTEX_UNLOCK_PI | FUTEX_ROBUST_UNLOCK | \
|
||||
FUTEX_ROBUST_LIST32)
|
||||
#define FUTEX_UNLOCK_PI_LIST32_PRIVATE (FUTEX_UNLOCK_PI_LIST32 | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
#define FUTEX_UNLOCK_WAKE_LIST64 (FUTEX_WAKE | FUTEX_ROBUST_UNLOCK)
|
||||
#define FUTEX_UNLOCK_WAKE_LIST64_PRIVATE (FUTEX_UNLOCK_WAKE_LIST64 | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
#define FUTEX_UNLOCK_WAKE_LIST32 (FUTEX_WAKE | FUTEX_ROBUST_UNLOCK | \
|
||||
FUTEX_ROBUST_LIST32)
|
||||
#define FUTEX_UNLOCK_WAKE_LIST32_PRIVATE (FUTEX_UNLOCK_WAKE_LIST32 | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
#define FUTEX_UNLOCK_BITSET_LIST64 (FUTEX_WAKE_BITSET | FUTEX_ROBUST_UNLOCK)
|
||||
#define FUTEX_UNLOCK_BITSET_LIST64_PRIVATE (FUTEX_UNLOCK_BITSET_LIST64 | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
#define FUTEX_UNLOCK_BITSET_LIST32 (FUTEX_WAKE_BITSET | FUTEX_ROBUST_UNLOCK | \
|
||||
FUTEX_ROBUST_LIST32)
|
||||
#define FUTEX_UNLOCK_BITSET_LIST32_PRIVATE (FUTEX_UNLOCK_BITSET_LIST32 | FUTEX_PRIVATE_FLAG)
|
||||
|
||||
/*
|
||||
* Flags for futex2 syscalls.
|
||||
|
|
@ -177,6 +203,10 @@ struct robust_list_head {
|
|||
*/
|
||||
#define ROBUST_LIST_LIMIT 2048
|
||||
|
||||
/* Modifiers for robust_list_head::list_op_pending */
|
||||
#define FUTEX_ROBUST_MOD_PI (0x1UL)
|
||||
#define FUTEX_ROBUST_MOD_MASK (FUTEX_ROBUST_MOD_PI)
|
||||
|
||||
/*
|
||||
* bitset with all bits set for the FUTEX_xxx_BITSET OPs to request a
|
||||
* match of any bit.
|
||||
|
|
|
|||
52
include/vdso/futex.h
Normal file
52
include/vdso/futex.h
Normal file
|
|
@ -0,0 +1,52 @@
|
|||
/* SPDX-License-Identifier: GPL-2.0 */
|
||||
#ifndef _VDSO_FUTEX_H
|
||||
#define _VDSO_FUTEX_H
|
||||
|
||||
#include <uapi/linux/types.h>
|
||||
|
||||
/**
|
||||
* __vdso_futex_robust_list64_try_unlock - Try to unlock an uncontended robust futex
|
||||
* with a 64-bit pending op pointer
|
||||
* @lock: Pointer to the futex lock object
|
||||
* @tid: The TID of the calling task
|
||||
* @pop: Pointer to the task's robust_list_head::list_pending_op
|
||||
*
|
||||
* Return: The content of *@lock. On success this is the same as @tid.
|
||||
*
|
||||
* The function implements:
|
||||
* if (atomic_try_cmpxchg(lock, &tid, 0))
|
||||
* *op = NULL;
|
||||
* return tid;
|
||||
*
|
||||
* There is a race between a successful unlock and clearing the pending op
|
||||
* pointer in the robust list head. If the calling task is interrupted in the
|
||||
* race window and has to handle a (fatal) signal on return to user space then
|
||||
* the kernel handles the clearing of @pending_op before attempting to deliver
|
||||
* the signal. That ensures that a task cannot exit with a potentially invalid
|
||||
* pending op pointer.
|
||||
*
|
||||
* User space uses it in the following way:
|
||||
*
|
||||
* if (__vdso_futex_robust_list64_try_unlock(lock, tid, &pending_op) != tid)
|
||||
* err = sys_futex($OP | FUTEX_ROBUST_UNLOCK,....);
|
||||
*
|
||||
* If the unlock attempt fails due to the FUTEX_WAITERS bit set in the lock,
|
||||
* then the syscall does the unlock, clears the pending op pointer and wakes the
|
||||
* requested number of waiters.
|
||||
*/
|
||||
__u32 __vdso_futex_robust_list64_try_unlock(__u32 *lock, __u32 tid, __u64 *pop);
|
||||
|
||||
/**
|
||||
* __vdso_futex_robust_list32_try_unlock - Try to unlock an uncontended robust futex
|
||||
* with a 32-bit pending op pointer
|
||||
* @lock: Pointer to the futex lock object
|
||||
* @tid: The TID of the calling task
|
||||
* @pop: Pointer to the task's robust_list_head::list_pending_op
|
||||
*
|
||||
* Return: The content of *@lock. On success this is the same as @tid.
|
||||
*
|
||||
* Same as __vdso_futex_robust_list64_try_unlock() just with a 32-bit @pop pointer.
|
||||
*/
|
||||
__u32 __vdso_futex_robust_list32_try_unlock(__u32 *lock, __u32 tid, __u32 *pop);
|
||||
|
||||
#endif
|
||||
|
|
@ -1839,6 +1839,12 @@ config FUTEX_MPOL
|
|||
depends on FUTEX && NUMA
|
||||
default y
|
||||
|
||||
config HAVE_FUTEX_ROBUST_UNLOCK
|
||||
bool
|
||||
|
||||
config FUTEX_ROBUST_UNLOCK
|
||||
def_bool FUTEX && HAVE_GENERIC_VDSO && GENERIC_IRQ_ENTRY && RSEQ && HAVE_FUTEX_ROBUST_UNLOCK
|
||||
|
||||
config EPOLL
|
||||
bool "Enable eventpoll support" if EXPERT
|
||||
default y
|
||||
|
|
|
|||
|
|
@ -327,7 +327,7 @@ int io_futex_wake(struct io_kiocb *req, unsigned int issue_flags)
|
|||
* Strict flags - ensure that waking 0 futexes yields a 0 result.
|
||||
* See commit 43adf8449510 ("futex: FLAGS_STRICT") for details.
|
||||
*/
|
||||
ret = futex_wake(iof->uaddr, FLAGS_STRICT | iof->futex_flags,
|
||||
ret = futex_wake(iof->uaddr, FLAGS_STRICT | iof->futex_flags, NULL,
|
||||
iof->futex_val, iof->futex_mask);
|
||||
if (ret < 0)
|
||||
req_set_fail(req);
|
||||
|
|
|
|||
|
|
@ -1,11 +1,12 @@
|
|||
// SPDX-License-Identifier: GPL-2.0
|
||||
|
||||
#include <linux/irq-entry-common.h>
|
||||
#include <linux/resume_user_mode.h>
|
||||
#include <linux/futex.h>
|
||||
#include <linux/highmem.h>
|
||||
#include <linux/irq-entry-common.h>
|
||||
#include <linux/jump_label.h>
|
||||
#include <linux/kmsan.h>
|
||||
#include <linux/livepatch.h>
|
||||
#include <linux/resume_user_mode.h>
|
||||
#include <linux/tick.h>
|
||||
|
||||
/* Workaround to allow gradual conversion of architecture code */
|
||||
|
|
@ -60,8 +61,10 @@ static __always_inline unsigned long __exit_to_user_mode_loop(struct pt_regs *re
|
|||
if (ti_work & _TIF_PATCH_PENDING)
|
||||
klp_update_patch_state(current);
|
||||
|
||||
if (ti_work & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
|
||||
if (ti_work & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL)) {
|
||||
futex_fixup_robust_unlock(regs);
|
||||
arch_do_signal_or_restart(regs);
|
||||
}
|
||||
|
||||
if (ti_work & _TIF_NOTIFY_RESUME)
|
||||
resume_user_mode_work(regs);
|
||||
|
|
|
|||
|
|
@ -988,8 +988,8 @@ void __noreturn do_exit(long code)
|
|||
proc_exit_connector(tsk);
|
||||
mpol_put_task_policy(tsk);
|
||||
#ifdef CONFIG_FUTEX
|
||||
if (unlikely(current->pi_state_cache))
|
||||
kfree(current->pi_state_cache);
|
||||
if (unlikely(current->futex.pi_state_cache))
|
||||
kfree(current->futex.pi_state_cache);
|
||||
#endif
|
||||
/*
|
||||
* Make sure we are holding no locks:
|
||||
|
|
|
|||
|
|
@ -1103,6 +1103,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p)
|
|||
#endif
|
||||
mm_init_uprobes_state(mm);
|
||||
hugetlb_count_init(mm);
|
||||
futex_mm_init(mm);
|
||||
|
||||
mm_flags_clear_all(mm);
|
||||
if (current->mm) {
|
||||
|
|
@ -1115,11 +1116,8 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p)
|
|||
mm->def_flags = 0;
|
||||
}
|
||||
|
||||
if (futex_mm_init(mm))
|
||||
goto fail_mm_init;
|
||||
|
||||
if (mm_alloc_pgd(mm))
|
||||
goto fail_nopgd;
|
||||
goto fail_mm_init;
|
||||
|
||||
if (mm_alloc_id(mm))
|
||||
goto fail_noid;
|
||||
|
|
@ -1145,8 +1143,6 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p)
|
|||
mm_free_id(mm);
|
||||
fail_noid:
|
||||
mm_free_pgd(mm);
|
||||
fail_nopgd:
|
||||
futex_hash_free(mm);
|
||||
fail_mm_init:
|
||||
free_mm(mm);
|
||||
return NULL;
|
||||
|
|
|
|||
File diff suppressed because it is too large
Load Diff
|
|
@ -40,6 +40,8 @@
|
|||
#define FLAGS_NUMA 0x0080
|
||||
#define FLAGS_STRICT 0x0100
|
||||
#define FLAGS_MPOL 0x0200
|
||||
#define FLAGS_ROBUST_UNLOCK 0x0400
|
||||
#define FLAGS_ROBUST_LIST32 0x0800
|
||||
|
||||
/* FUTEX_ to FLAGS_ */
|
||||
static inline unsigned int futex_to_flags(unsigned int op)
|
||||
|
|
@ -52,6 +54,12 @@ static inline unsigned int futex_to_flags(unsigned int op)
|
|||
if (op & FUTEX_CLOCK_REALTIME)
|
||||
flags |= FLAGS_CLOCKRT;
|
||||
|
||||
if (op & FUTEX_ROBUST_UNLOCK)
|
||||
flags |= FLAGS_ROBUST_UNLOCK;
|
||||
|
||||
if (op & FUTEX_ROBUST_LIST32)
|
||||
flags |= FLAGS_ROBUST_LIST32;
|
||||
|
||||
return flags;
|
||||
}
|
||||
|
||||
|
|
@ -126,6 +134,15 @@ static inline bool should_fail_futex(bool fshared)
|
|||
}
|
||||
#endif
|
||||
|
||||
static inline bool futex_key_is_private(union futex_key *key)
|
||||
{
|
||||
/*
|
||||
* Relies on get_futex_key() to set either bit for shared
|
||||
* futexes -- see comment with union futex_key.
|
||||
*/
|
||||
return !(key->both.offset & (FUT_OFF_INODE | FUT_OFF_MMSHARED));
|
||||
}
|
||||
|
||||
/*
|
||||
* Hash buckets are shared by all the futex_keys that hash to the same
|
||||
* location. Each key may have multiple futex_q structures, one for each task
|
||||
|
|
@ -135,7 +152,6 @@ struct futex_hash_bucket {
|
|||
atomic_t waiters;
|
||||
spinlock_t lock;
|
||||
struct plist_head chain;
|
||||
struct futex_private_hash *priv;
|
||||
} ____cacheline_aligned_in_smp;
|
||||
|
||||
/*
|
||||
|
|
@ -175,7 +191,7 @@ typedef void (futex_wake_fn)(struct wake_q_head *wake_q, struct futex_q *q);
|
|||
* @requeue_pi_key: the requeue_pi target futex key
|
||||
* @bitset: bitset for the optional bitmasked wakeup
|
||||
* @requeue_state: State field for futex_requeue_pi()
|
||||
* @drop_hb_ref: Waiter should drop the extra hash bucket reference if true
|
||||
* @drop_fph: Waiter should drop the extra private hash reference when set
|
||||
* @requeue_wait: RCU wait for futex_requeue_pi() (RT only)
|
||||
*
|
||||
* We use this hashed waitqueue, instead of a normal wait_queue_entry_t, so
|
||||
|
|
@ -202,7 +218,7 @@ struct futex_q {
|
|||
union futex_key *requeue_pi_key;
|
||||
u32 bitset;
|
||||
atomic_t requeue_state;
|
||||
bool drop_hb_ref;
|
||||
struct futex_private_hash *drop_fph;
|
||||
#ifdef CONFIG_PREEMPT_RT
|
||||
struct rcuwait requeue_wait;
|
||||
#endif
|
||||
|
|
@ -222,28 +238,29 @@ extern struct hrtimer_sleeper *
|
|||
futex_setup_timer(ktime_t *time, struct hrtimer_sleeper *timeout,
|
||||
int flags, u64 range_ns);
|
||||
|
||||
extern struct futex_hash_bucket *futex_hash(union futex_key *key);
|
||||
#ifdef CONFIG_FUTEX_PRIVATE_HASH
|
||||
extern void futex_hash_get(struct futex_hash_bucket *hb);
|
||||
extern void futex_hash_put(struct futex_hash_bucket *hb);
|
||||
struct futex_bucket_ref {
|
||||
struct futex_hash_bucket *hb;
|
||||
struct futex_private_hash *fph;
|
||||
};
|
||||
|
||||
extern struct futex_private_hash *futex_private_hash(void);
|
||||
#ifdef CONFIG_FUTEX_PRIVATE_HASH
|
||||
extern struct futex_private_hash *futex_private_hash(struct mm_struct *mm);
|
||||
extern void futex_private_hash_put(struct futex_private_hash *fph);
|
||||
|
||||
#else /* !CONFIG_FUTEX_PRIVATE_HASH */
|
||||
static inline void futex_hash_get(struct futex_hash_bucket *hb) { }
|
||||
static inline void futex_hash_put(struct futex_hash_bucket *hb) { }
|
||||
static inline struct futex_private_hash *futex_private_hash(void) { return NULL; }
|
||||
static inline struct futex_private_hash *futex_private_hash(struct mm_struct *mm) { return NULL; }
|
||||
static inline void futex_private_hash_put(struct futex_private_hash *fph) { }
|
||||
#endif
|
||||
|
||||
DEFINE_CLASS(hb, struct futex_hash_bucket *,
|
||||
if (_T) futex_hash_put(_T),
|
||||
extern struct futex_bucket_ref futex_hash(union futex_key *key);
|
||||
|
||||
DEFINE_CLASS(hbr, struct futex_bucket_ref,
|
||||
if (_T.fph) futex_private_hash_put(_T.fph),
|
||||
futex_hash(key), union futex_key *key);
|
||||
|
||||
DEFINE_CLASS(private_hash, struct futex_private_hash *,
|
||||
if (_T) futex_private_hash_put(_T),
|
||||
futex_private_hash(), void);
|
||||
futex_private_hash(mm), struct mm_struct *mm);
|
||||
|
||||
/**
|
||||
* futex_match - Check whether two futex keys are equal
|
||||
|
|
@ -449,13 +466,16 @@ extern int futex_unqueue_multiple(struct futex_vector *v, int count);
|
|||
extern int futex_wait_multiple(struct futex_vector *vs, unsigned int count,
|
||||
struct hrtimer_sleeper *to);
|
||||
|
||||
extern int futex_wake(u32 __user *uaddr, unsigned int flags, int nr_wake, u32 bitset);
|
||||
extern int futex_wake(u32 __user *uaddr, unsigned int flags, void __user *pop,
|
||||
int nr_wake, u32 bitset);
|
||||
|
||||
extern int futex_wake_op(u32 __user *uaddr1, unsigned int flags,
|
||||
u32 __user *uaddr2, int nr_wake, int nr_wake2, int op);
|
||||
|
||||
extern int futex_unlock_pi(u32 __user *uaddr, unsigned int flags);
|
||||
extern int futex_unlock_pi(u32 __user *uaddr, unsigned int flags, void __user *pop);
|
||||
|
||||
extern int futex_lock_pi(u32 __user *uaddr, unsigned int flags, ktime_t *time, int trylock);
|
||||
|
||||
bool futex_robust_list_clear_pending(void __user *pop, unsigned int flags);
|
||||
|
||||
#endif /* _FUTEX_H */
|
||||
|
|
|
|||
|
|
@ -14,7 +14,7 @@ int refill_pi_state_cache(void)
|
|||
{
|
||||
struct futex_pi_state *pi_state;
|
||||
|
||||
if (likely(current->pi_state_cache))
|
||||
if (likely(current->futex.pi_state_cache))
|
||||
return 0;
|
||||
|
||||
pi_state = kzalloc_obj(*pi_state);
|
||||
|
|
@ -28,17 +28,17 @@ int refill_pi_state_cache(void)
|
|||
refcount_set(&pi_state->refcount, 1);
|
||||
pi_state->key = FUTEX_KEY_INIT;
|
||||
|
||||
current->pi_state_cache = pi_state;
|
||||
current->futex.pi_state_cache = pi_state;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct futex_pi_state *alloc_pi_state(void)
|
||||
{
|
||||
struct futex_pi_state *pi_state = current->pi_state_cache;
|
||||
struct futex_pi_state *pi_state = current->futex.pi_state_cache;
|
||||
|
||||
WARN_ON(!pi_state);
|
||||
current->pi_state_cache = NULL;
|
||||
current->futex.pi_state_cache = NULL;
|
||||
|
||||
return pi_state;
|
||||
}
|
||||
|
|
@ -60,7 +60,7 @@ static void pi_state_update_owner(struct futex_pi_state *pi_state,
|
|||
if (new_owner) {
|
||||
raw_spin_lock(&new_owner->pi_lock);
|
||||
WARN_ON(!list_empty(&pi_state->list));
|
||||
list_add(&pi_state->list, &new_owner->pi_state_list);
|
||||
list_add(&pi_state->list, &new_owner->futex.pi_state_list);
|
||||
pi_state->owner = new_owner;
|
||||
raw_spin_unlock(&new_owner->pi_lock);
|
||||
}
|
||||
|
|
@ -96,7 +96,7 @@ void put_pi_state(struct futex_pi_state *pi_state)
|
|||
raw_spin_unlock_irqrestore(&pi_state->pi_mutex.wait_lock, flags);
|
||||
}
|
||||
|
||||
if (current->pi_state_cache) {
|
||||
if (current->futex.pi_state_cache) {
|
||||
kfree(pi_state);
|
||||
} else {
|
||||
/*
|
||||
|
|
@ -106,7 +106,7 @@ void put_pi_state(struct futex_pi_state *pi_state)
|
|||
*/
|
||||
pi_state->owner = NULL;
|
||||
refcount_set(&pi_state->refcount, 1);
|
||||
current->pi_state_cache = pi_state;
|
||||
current->futex.pi_state_cache = pi_state;
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -179,7 +179,7 @@ void put_pi_state(struct futex_pi_state *pi_state)
|
|||
*
|
||||
* p->pi_lock:
|
||||
*
|
||||
* p->pi_state_list -> pi_state->list, relation
|
||||
* p->futex.pi_state_list -> pi_state->list, relation
|
||||
* pi_mutex->owner -> pi_state->owner, relation
|
||||
*
|
||||
* pi_state->refcount:
|
||||
|
|
@ -327,7 +327,7 @@ static int handle_exit_race(u32 __user *uaddr, u32 uval,
|
|||
* If the futex exit state is not yet FUTEX_STATE_DEAD, tell the
|
||||
* caller that the alleged owner is busy.
|
||||
*/
|
||||
if (tsk && tsk->futex_state != FUTEX_STATE_DEAD)
|
||||
if (tsk && tsk->futex.state != FUTEX_STATE_DEAD)
|
||||
return -EBUSY;
|
||||
|
||||
/*
|
||||
|
|
@ -346,8 +346,8 @@ static int handle_exit_race(u32 __user *uaddr, u32 uval,
|
|||
* *uaddr = 0xC0000000; tsk = get_task(PID);
|
||||
* } if (!tsk->flags & PF_EXITING) {
|
||||
* ... attach();
|
||||
* tsk->futex_state = } else {
|
||||
* FUTEX_STATE_DEAD; if (tsk->futex_state !=
|
||||
* tsk->futex.state = } else {
|
||||
* FUTEX_STATE_DEAD; if (tsk->futex.state !=
|
||||
* FUTEX_STATE_DEAD)
|
||||
* return -EAGAIN;
|
||||
* return -ESRCH; <--- FAIL
|
||||
|
|
@ -396,7 +396,7 @@ static void __attach_to_pi_owner(struct task_struct *p, union futex_key *key,
|
|||
pi_state->key = *key;
|
||||
|
||||
WARN_ON(!list_empty(&pi_state->list));
|
||||
list_add(&pi_state->list, &p->pi_state_list);
|
||||
list_add(&pi_state->list, &p->futex.pi_state_list);
|
||||
/*
|
||||
* Assignment without holding pi_state->pi_mutex.wait_lock is safe
|
||||
* because there is no concurrency as the object is not published yet.
|
||||
|
|
@ -440,7 +440,7 @@ static int attach_to_pi_owner(u32 __user *uaddr, u32 uval, union futex_key *key,
|
|||
* in futex_exit_release(), we do this protected by p->pi_lock:
|
||||
*/
|
||||
raw_spin_lock_irq(&p->pi_lock);
|
||||
if (unlikely(p->futex_state != FUTEX_STATE_OK)) {
|
||||
if (unlikely(p->futex.state != FUTEX_STATE_OK)) {
|
||||
/*
|
||||
* The task is on the way out. When the futex state is
|
||||
* FUTEX_STATE_DEAD, we know that the task has finished
|
||||
|
|
@ -945,7 +945,8 @@ int futex_lock_pi(u32 __user *uaddr, unsigned int flags, ktime_t *time, int tryl
|
|||
|
||||
retry_private:
|
||||
if (1) {
|
||||
CLASS(hb, hb)(&q.key);
|
||||
CLASS(hbr, hbr)(&q.key);
|
||||
auto hb = hbr.hb;
|
||||
|
||||
futex_q_lock(&q, hb);
|
||||
|
||||
|
|
@ -1009,7 +1010,7 @@ int futex_lock_pi(u32 __user *uaddr, unsigned int flags, ktime_t *time, int tryl
|
|||
* the thread, performing resize, will block on hb->lock during
|
||||
* the requeue.
|
||||
*/
|
||||
futex_hash_put(no_free_ptr(hb));
|
||||
futex_private_hash_put(no_free_ptr(hbr.fph));
|
||||
/*
|
||||
* Must be done before we enqueue the waiter, here is unfortunately
|
||||
* under the hb lock, but that *should* work because it does nothing.
|
||||
|
|
@ -1100,11 +1101,9 @@ int futex_lock_pi(u32 __user *uaddr, unsigned int flags, ktime_t *time, int tryl
|
|||
__release(&hb->lock);
|
||||
futex_unqueue_pi(&q);
|
||||
spin_unlock(q.lock_ptr);
|
||||
if (q.drop_hb_ref) {
|
||||
CLASS(hb, hb)(&q.key);
|
||||
/* Additional reference from futex_unlock_pi() */
|
||||
futex_hash_put(hb);
|
||||
}
|
||||
|
||||
/* Additional reference from futex_unlock_pi() */
|
||||
futex_private_hash_put(q.drop_fph);
|
||||
goto out;
|
||||
|
||||
out_unlock_put_key:
|
||||
|
|
@ -1139,7 +1138,7 @@ int futex_lock_pi(u32 __user *uaddr, unsigned int flags, ktime_t *time, int tryl
|
|||
* This is the in-kernel slowpath: we look up the PI state (if any),
|
||||
* and do the rt-mutex unlock.
|
||||
*/
|
||||
int futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
||||
static int __futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
||||
{
|
||||
u32 curval, uval, vpid = task_pid_vnr(current);
|
||||
union futex_key key = FUTEX_KEY_INIT;
|
||||
|
|
@ -1148,7 +1147,6 @@ int futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
|||
|
||||
if (!IS_ENABLED(CONFIG_FUTEX_PI))
|
||||
return -ENOSYS;
|
||||
|
||||
retry:
|
||||
if (get_user(uval, uaddr))
|
||||
return -EFAULT;
|
||||
|
|
@ -1162,7 +1160,8 @@ int futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
|||
if (ret)
|
||||
return ret;
|
||||
|
||||
CLASS(hb, hb)(&key);
|
||||
CLASS(hbr, hbr)(&key);
|
||||
auto hb = hbr.hb;
|
||||
spin_lock(&hb->lock);
|
||||
retry_hb:
|
||||
|
||||
|
|
@ -1219,8 +1218,9 @@ int futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
|||
* Acquire a reference for the leaving waiter to ensure
|
||||
* valid futex_q::lock_ptr.
|
||||
*/
|
||||
futex_hash_get(hb);
|
||||
top_waiter->drop_hb_ref = true;
|
||||
if (futex_key_is_private(&key))
|
||||
top_waiter->drop_fph = futex_private_hash(key.private.mm);
|
||||
|
||||
__futex_unqueue(top_waiter);
|
||||
raw_spin_unlock_irq(&pi_state->pi_mutex.wait_lock);
|
||||
goto retry_hb;
|
||||
|
|
@ -1302,3 +1302,15 @@ int futex_unlock_pi(u32 __user *uaddr, unsigned int flags)
|
|||
return ret;
|
||||
}
|
||||
|
||||
int futex_unlock_pi(u32 __user *uaddr, unsigned int flags, void __user *pop)
|
||||
{
|
||||
int ret = __futex_unlock_pi(uaddr, flags);
|
||||
|
||||
if (ret || !(flags & FLAGS_ROBUST_UNLOCK))
|
||||
return ret;
|
||||
|
||||
if (!futex_robust_list_clear_pending(pop, flags))
|
||||
return -EFAULT;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -241,8 +241,8 @@ void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key,
|
|||
* Acquire a reference for the waiter to ensure valid
|
||||
* futex_q::lock_ptr.
|
||||
*/
|
||||
futex_hash_get(hb);
|
||||
q->drop_hb_ref = true;
|
||||
if (futex_key_is_private(key))
|
||||
q->drop_fph = futex_private_hash(key->private.mm);
|
||||
q->lock_ptr = &hb->lock;
|
||||
task = READ_ONCE(q->task);
|
||||
|
||||
|
|
@ -459,8 +459,10 @@ int futex_requeue(u32 __user *uaddr1, unsigned int flags1,
|
|||
|
||||
retry_private:
|
||||
if (1) {
|
||||
CLASS(hb, hb1)(&key1);
|
||||
CLASS(hb, hb2)(&key2);
|
||||
CLASS(hbr, hbr1)(&key1);
|
||||
CLASS(hbr, hbr2)(&key2);
|
||||
auto hb1 = hbr1.hb;
|
||||
auto hb2 = hbr2.hb;
|
||||
|
||||
futex_hb_waiters_inc(hb2);
|
||||
double_lock_hb(hb1, hb2);
|
||||
|
|
@ -838,7 +840,8 @@ int futex_wait_requeue_pi(u32 __user *uaddr, unsigned int flags,
|
|||
switch (futex_requeue_pi_wakeup_sync(&q)) {
|
||||
case Q_REQUEUE_PI_IGNORE:
|
||||
{
|
||||
CLASS(hb, hb)(&q.key);
|
||||
CLASS(hbr, hbr)(&q.key);
|
||||
auto hb = hbr.hb;
|
||||
/* The waiter is still on uaddr1 */
|
||||
spin_lock(&hb->lock);
|
||||
ret = handle_early_requeue_pi_wakeup(hb, &q, to);
|
||||
|
|
@ -908,11 +911,8 @@ int futex_wait_requeue_pi(u32 __user *uaddr, unsigned int flags,
|
|||
default:
|
||||
BUG();
|
||||
}
|
||||
if (q.drop_hb_ref) {
|
||||
CLASS(hb, hb)(&q.key);
|
||||
/* Additional reference from requeue_pi_wake_futex() */
|
||||
futex_hash_put(hb);
|
||||
}
|
||||
/* Additional reference from requeue_pi_wake_futex() */
|
||||
futex_private_hash_put(q.drop_fph);
|
||||
|
||||
out:
|
||||
if (to) {
|
||||
|
|
|
|||
|
|
@ -25,17 +25,13 @@
|
|||
* @head: pointer to the list-head
|
||||
* @len: length of the list-head, as userspace expects
|
||||
*/
|
||||
SYSCALL_DEFINE2(set_robust_list, struct robust_list_head __user *, head,
|
||||
size_t, len)
|
||||
SYSCALL_DEFINE2(set_robust_list, struct robust_list_head __user *, head, size_t, len)
|
||||
{
|
||||
/*
|
||||
* The kernel knows only one size for now:
|
||||
*/
|
||||
/* The kernel knows only one size for now. */
|
||||
if (unlikely(len != sizeof(*head)))
|
||||
return -EINVAL;
|
||||
|
||||
current->robust_list = head;
|
||||
|
||||
current->futex.robust_list = head;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
@ -43,9 +39,9 @@ static inline void __user *futex_task_robust_list(struct task_struct *p, bool co
|
|||
{
|
||||
#ifdef CONFIG_COMPAT
|
||||
if (compat)
|
||||
return p->compat_robust_list;
|
||||
return p->futex.compat_robust_list;
|
||||
#endif
|
||||
return p->robust_list;
|
||||
return p->futex.robust_list;
|
||||
}
|
||||
|
||||
static void __user *futex_get_robust_list_common(int pid, bool compat)
|
||||
|
|
@ -122,6 +118,13 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
|
|||
return -ENOSYS;
|
||||
}
|
||||
|
||||
if (flags & FLAGS_ROBUST_UNLOCK) {
|
||||
if (cmd != FUTEX_WAKE &&
|
||||
cmd != FUTEX_WAKE_BITSET &&
|
||||
cmd != FUTEX_UNLOCK_PI)
|
||||
return -ENOSYS;
|
||||
}
|
||||
|
||||
switch (cmd) {
|
||||
case FUTEX_WAIT:
|
||||
val3 = FUTEX_BITSET_MATCH_ANY;
|
||||
|
|
@ -132,7 +135,7 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
|
|||
val3 = FUTEX_BITSET_MATCH_ANY;
|
||||
fallthrough;
|
||||
case FUTEX_WAKE_BITSET:
|
||||
return futex_wake(uaddr, flags, val, val3);
|
||||
return futex_wake(uaddr, flags, uaddr2, val, val3);
|
||||
case FUTEX_REQUEUE:
|
||||
return futex_requeue(uaddr, flags, uaddr2, flags, val, val2, NULL, 0);
|
||||
case FUTEX_CMP_REQUEUE:
|
||||
|
|
@ -145,7 +148,7 @@ long do_futex(u32 __user *uaddr, int op, u32 val, ktime_t *timeout,
|
|||
case FUTEX_LOCK_PI2:
|
||||
return futex_lock_pi(uaddr, flags, timeout, 0);
|
||||
case FUTEX_UNLOCK_PI:
|
||||
return futex_unlock_pi(uaddr, flags);
|
||||
return futex_unlock_pi(uaddr, flags, uaddr2);
|
||||
case FUTEX_TRYLOCK_PI:
|
||||
return futex_lock_pi(uaddr, flags, NULL, 1);
|
||||
case FUTEX_WAIT_REQUEUE_PI:
|
||||
|
|
@ -379,7 +382,7 @@ SYSCALL_DEFINE4(futex_wake,
|
|||
if (!futex_validate_input(flags, mask))
|
||||
return -EINVAL;
|
||||
|
||||
return futex_wake(uaddr, FLAGS_STRICT | flags, nr, mask);
|
||||
return futex_wake(uaddr, FLAGS_STRICT | flags, NULL, nr, mask);
|
||||
}
|
||||
|
||||
/*
|
||||
|
|
@ -475,15 +478,13 @@ SYSCALL_DEFINE4(futex_requeue,
|
|||
}
|
||||
|
||||
#ifdef CONFIG_COMPAT
|
||||
COMPAT_SYSCALL_DEFINE2(set_robust_list,
|
||||
struct compat_robust_list_head __user *, head,
|
||||
compat_size_t, len)
|
||||
COMPAT_SYSCALL_DEFINE2(set_robust_list, struct compat_robust_list_head __user *, head,
|
||||
compat_size_t, len)
|
||||
{
|
||||
if (unlikely(len != sizeof(*head)))
|
||||
return -EINVAL;
|
||||
|
||||
current->compat_robust_list = head;
|
||||
|
||||
current->futex.compat_robust_list = head;
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
@ -523,4 +524,3 @@ SYSCALL_DEFINE6(futex_time32, u32 __user *, uaddr, int, op, u32, val,
|
|||
return do_futex(uaddr, op, val, tp, uaddr2, (unsigned long)utime, val3);
|
||||
}
|
||||
#endif /* CONFIG_COMPAT_32BIT_TIME */
|
||||
|
||||
|
|
|
|||
|
|
@ -149,13 +149,36 @@ void futex_wake_mark(struct wake_q_head *wake_q, struct futex_q *q)
|
|||
wake_q_add_safe(wake_q, p);
|
||||
}
|
||||
|
||||
/*
|
||||
* If requested, clear the robust list pending op and unlock the futex
|
||||
*/
|
||||
static bool futex_robust_unlock(u32 __user *uaddr, unsigned int flags, void __user *pop)
|
||||
{
|
||||
if (!(flags & FLAGS_ROBUST_UNLOCK))
|
||||
return true;
|
||||
|
||||
/* First unlock the futex, which requires release semantics. */
|
||||
scoped_user_write_access(uaddr, efault)
|
||||
unsafe_atomic_store_release_user(0, uaddr, efault);
|
||||
|
||||
/*
|
||||
* Clear the pending list op now. If that fails, then the task is in
|
||||
* deeper trouble as the robust list head is usually part of the TLS.
|
||||
* The chance of survival is close to zero.
|
||||
*/
|
||||
return futex_robust_list_clear_pending(pop, flags);
|
||||
|
||||
efault:
|
||||
return false;
|
||||
}
|
||||
|
||||
/*
|
||||
* Wake up waiters matching bitset queued on this futex (uaddr).
|
||||
*/
|
||||
int futex_wake(u32 __user *uaddr, unsigned int flags, int nr_wake, u32 bitset)
|
||||
int futex_wake(u32 __user *uaddr, unsigned int flags, void __user *pop, int nr_wake, u32 bitset)
|
||||
{
|
||||
struct futex_q *this, *next;
|
||||
union futex_key key = FUTEX_KEY_INIT;
|
||||
struct futex_q *this, *next;
|
||||
DEFINE_WAKE_Q(wake_q);
|
||||
int ret;
|
||||
|
||||
|
|
@ -166,10 +189,14 @@ int futex_wake(u32 __user *uaddr, unsigned int flags, int nr_wake, u32 bitset)
|
|||
if (unlikely(ret != 0))
|
||||
return ret;
|
||||
|
||||
if (!futex_robust_unlock(uaddr, flags, pop))
|
||||
return -EFAULT;
|
||||
|
||||
if ((flags & FLAGS_STRICT) && !nr_wake)
|
||||
return 0;
|
||||
|
||||
CLASS(hb, hb)(&key);
|
||||
CLASS(hbr, hbr)(&key);
|
||||
auto hb = hbr.hb;
|
||||
|
||||
/* Make sure we really have tasks to wakeup */
|
||||
if (!futex_hb_waiters_pending(hb))
|
||||
|
|
@ -266,8 +293,10 @@ int futex_wake_op(u32 __user *uaddr1, unsigned int flags, u32 __user *uaddr2,
|
|||
|
||||
retry_private:
|
||||
if (1) {
|
||||
CLASS(hb, hb1)(&key1);
|
||||
CLASS(hb, hb2)(&key2);
|
||||
CLASS(hbr, hbr1)(&key1);
|
||||
CLASS(hbr, hbr2)(&key2);
|
||||
auto hb1 = hbr1.hb;
|
||||
auto hb2 = hbr2.hb;
|
||||
|
||||
double_lock_hb(hb1, hb2);
|
||||
op_ret = futex_atomic_op_inuser(op, uaddr2);
|
||||
|
|
@ -409,7 +438,7 @@ int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *woken)
|
|||
* Make sure to have a reference on the private_hash such that we
|
||||
* don't block on rehash after changing the task state below.
|
||||
*/
|
||||
guard(private_hash)();
|
||||
guard(private_hash)(current->mm);
|
||||
|
||||
/*
|
||||
* Enqueuing multiple futexes is tricky, because we need to enqueue
|
||||
|
|
@ -446,7 +475,8 @@ int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *woken)
|
|||
u32 val = vs[i].w.val;
|
||||
|
||||
if (1) {
|
||||
CLASS(hb, hb)(&q->key);
|
||||
CLASS(hbr, hbr)(&q->key);
|
||||
auto hb = hbr.hb;
|
||||
|
||||
futex_q_lock(q, hb);
|
||||
ret = futex_get_value_locked(&uval, uaddr);
|
||||
|
|
@ -621,7 +651,8 @@ int futex_wait_setup(u32 __user *uaddr, u32 val, unsigned int flags,
|
|||
|
||||
retry_private:
|
||||
if (1) {
|
||||
CLASS(hb, hb)(&q->key);
|
||||
CLASS(hbr, hbr)(&q->key);
|
||||
auto hb = hbr.hb;
|
||||
|
||||
futex_q_lock(q, hb);
|
||||
|
||||
|
|
|
|||
|
|
@ -194,7 +194,7 @@ void __irq_put_desc_unlock(struct irq_desc *desc, unsigned long flags, bool bus)
|
|||
|
||||
__DEFINE_CLASS_IS_CONDITIONAL(irqdesc_lock, true);
|
||||
__DEFINE_UNLOCK_GUARD(irqdesc_lock, struct irq_desc,
|
||||
__irq_put_desc_unlock(_T->lock, _T->flags, _T->bus),
|
||||
if (_T->lock) __irq_put_desc_unlock(_T->lock, _T->flags, _T->bus),
|
||||
unsigned long flags; bool bus);
|
||||
|
||||
static inline class_irqdesc_lock_t class_irqdesc_lock_constructor(unsigned int irq, bool bus,
|
||||
|
|
|
|||
|
|
@ -1023,6 +1023,9 @@ static noinline void __sched __mutex_unlock_slowpath(struct mutex *lock, unsigne
|
|||
wake_q_add(&wake_q, next);
|
||||
}
|
||||
|
||||
if (trace_contended_release_enabled() && waiter)
|
||||
trace_call__contended_release(lock);
|
||||
|
||||
if (owner & MUTEX_FLAG_HANDOFF)
|
||||
__mutex_handoff(lock, next);
|
||||
|
||||
|
|
@ -1220,6 +1223,7 @@ EXPORT_SYMBOL(ww_mutex_lock_interruptible);
|
|||
|
||||
EXPORT_TRACEPOINT_SYMBOL_GPL(contention_begin);
|
||||
EXPORT_TRACEPOINT_SYMBOL_GPL(contention_end);
|
||||
EXPORT_TRACEPOINT_SYMBOL_GPL(contended_release);
|
||||
|
||||
/**
|
||||
* atomic_dec_and_mutex_lock - return holding mutex if we dec to 0
|
||||
|
|
|
|||
|
|
@ -263,6 +263,9 @@ void percpu_up_write(struct percpu_rw_semaphore *sem)
|
|||
{
|
||||
rwsem_release(&sem->dep_map, _RET_IP_);
|
||||
|
||||
if (trace_contended_release_enabled() && wq_has_sleeper(&sem->waiters))
|
||||
trace_call__contended_release(sem);
|
||||
|
||||
/*
|
||||
* Signal the writer is done, no fast path yet.
|
||||
*
|
||||
|
|
@ -288,3 +291,29 @@ void percpu_up_write(struct percpu_rw_semaphore *sem)
|
|||
rcu_sync_exit(&sem->rss);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(percpu_up_write);
|
||||
|
||||
void __percpu_up_read(struct percpu_rw_semaphore *sem)
|
||||
{
|
||||
lockdep_assert_preemption_disabled();
|
||||
/*
|
||||
* After percpu_up_write() completes, rcu_sync_is_idle() can still
|
||||
* return false during the grace period, forcing readers into this
|
||||
* slowpath. Only trace when a writer is actually waiting for
|
||||
* readers to drain.
|
||||
*/
|
||||
if (trace_contended_release_enabled() && rcuwait_active(&sem->writer))
|
||||
trace_call__contended_release(sem);
|
||||
/*
|
||||
* slowpath; reader will only ever wake a single blocked
|
||||
* writer.
|
||||
*/
|
||||
smp_mb(); /* B matches C */
|
||||
/*
|
||||
* In other words, if they see our decrement (presumably to
|
||||
* aggregate zero, as that is the only time it matters) they
|
||||
* will also see our critical section.
|
||||
*/
|
||||
this_cpu_dec(*sem->read_count);
|
||||
rcuwait_wake_up(&sem->writer);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(__percpu_up_read);
|
||||
|
|
|
|||
|
|
@ -484,6 +484,7 @@ static __always_inline bool __waiter_less(struct rb_node *a, const struct rb_nod
|
|||
|
||||
static __always_inline void
|
||||
rt_mutex_enqueue(struct rt_mutex_base *lock, struct rt_mutex_waiter *waiter)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
lockdep_assert_held(&lock->wait_lock);
|
||||
|
||||
|
|
@ -492,6 +493,7 @@ rt_mutex_enqueue(struct rt_mutex_base *lock, struct rt_mutex_waiter *waiter)
|
|||
|
||||
static __always_inline void
|
||||
rt_mutex_dequeue(struct rt_mutex_base *lock, struct rt_mutex_waiter *waiter)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
lockdep_assert_held(&lock->wait_lock);
|
||||
|
||||
|
|
@ -1092,6 +1094,7 @@ static int __sched rt_mutex_adjust_prio_chain(struct task_struct *task,
|
|||
static int __sched
|
||||
try_to_take_rt_mutex(struct rt_mutex_base *lock, struct task_struct *task,
|
||||
struct rt_mutex_waiter *waiter)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
lockdep_assert_held(&lock->wait_lock);
|
||||
|
||||
|
|
@ -1319,6 +1322,7 @@ static int __sched task_blocks_on_rt_mutex(struct rt_mutex_base *lock,
|
|||
*/
|
||||
static void __sched mark_wakeup_next_waiter(struct rt_wake_q_head *wqh,
|
||||
struct rt_mutex_base *lock)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
struct rt_mutex_waiter *waiter;
|
||||
|
||||
|
|
@ -1466,6 +1470,7 @@ static void __sched rt_mutex_slowunlock(struct rt_mutex_base *lock)
|
|||
raw_spin_lock_irqsave(&lock->wait_lock, flags);
|
||||
}
|
||||
|
||||
trace_contended_release(lock);
|
||||
/*
|
||||
* The wakeup next waiter path does not suffer from the above
|
||||
* race. See the comments there.
|
||||
|
|
|
|||
|
|
@ -41,6 +41,7 @@ static __always_inline int __rt_mutex_lock_common(struct rt_mutex *lock,
|
|||
unsigned int state,
|
||||
struct lockdep_map *nest_lock,
|
||||
unsigned int subclass)
|
||||
__cond_acquires(0, lock)
|
||||
{
|
||||
int ret;
|
||||
|
||||
|
|
@ -67,13 +68,27 @@ EXPORT_SYMBOL(rt_mutex_base_init);
|
|||
*/
|
||||
void __sched rt_mutex_lock_nested(struct rt_mutex *lock, unsigned int subclass)
|
||||
{
|
||||
__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, NULL, subclass);
|
||||
if (__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, NULL, subclass) == 0)
|
||||
return;
|
||||
/*
|
||||
* The code below is never reached because __rt_mutex_lock_common() only
|
||||
* returns an error code if interrupted by a signal or upon a timeout.
|
||||
*/
|
||||
WARN_ON_ONCE(true);
|
||||
__acquire(lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(rt_mutex_lock_nested);
|
||||
|
||||
void __sched _rt_mutex_lock_nest_lock(struct rt_mutex *lock, struct lockdep_map *nest_lock)
|
||||
{
|
||||
__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, nest_lock, 0);
|
||||
if (__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, nest_lock, 0) == 0)
|
||||
return;
|
||||
/*
|
||||
* The code below is never reached because __rt_mutex_lock_common() only
|
||||
* returns an error code if interrupted by a signal or upon a timeout.
|
||||
*/
|
||||
WARN_ON_ONCE(true);
|
||||
__acquire(lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(_rt_mutex_lock_nest_lock);
|
||||
|
||||
|
|
@ -86,7 +101,14 @@ EXPORT_SYMBOL_GPL(_rt_mutex_lock_nest_lock);
|
|||
*/
|
||||
void __sched rt_mutex_lock(struct rt_mutex *lock)
|
||||
{
|
||||
__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, NULL, 0);
|
||||
if (__rt_mutex_lock_common(lock, TASK_UNINTERRUPTIBLE, NULL, 0) == 0)
|
||||
return;
|
||||
/*
|
||||
* The code below is never reached because __rt_mutex_lock_common() only
|
||||
* returns an error code if interrupted by a signal or upon a timeout.
|
||||
*/
|
||||
WARN_ON_ONCE(true);
|
||||
__acquire(lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(rt_mutex_lock);
|
||||
#endif
|
||||
|
|
@ -157,6 +179,7 @@ void __sched rt_mutex_unlock(struct rt_mutex *lock)
|
|||
{
|
||||
mutex_release(&lock->dep_map, _RET_IP_);
|
||||
__rt_mutex_unlock(&lock->rtmutex);
|
||||
__release(lock);
|
||||
}
|
||||
EXPORT_SYMBOL_GPL(rt_mutex_unlock);
|
||||
|
||||
|
|
@ -182,6 +205,7 @@ int __sched __rt_mutex_futex_trylock(struct rt_mutex_base *lock)
|
|||
*/
|
||||
bool __sched __rt_mutex_futex_unlock(struct rt_mutex_base *lock,
|
||||
struct rt_wake_q_head *wqh)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
lockdep_assert_held(&lock->wait_lock);
|
||||
|
||||
|
|
@ -312,6 +336,7 @@ int __sched __rt_mutex_start_proxy_lock(struct rt_mutex_base *lock,
|
|||
struct rt_mutex_waiter *waiter,
|
||||
struct task_struct *task,
|
||||
struct wake_q_head *wake_q)
|
||||
__must_hold(&lock->wait_lock)
|
||||
{
|
||||
int ret;
|
||||
|
||||
|
|
|
|||
|
|
@ -174,6 +174,8 @@ static void __sched __rwbase_read_unlock(struct rwbase_rt *rwb,
|
|||
static __always_inline void rwbase_read_unlock(struct rwbase_rt *rwb,
|
||||
unsigned int state)
|
||||
{
|
||||
if (trace_contended_release_enabled() && rt_mutex_owner(&rwb->rtmutex))
|
||||
trace_call__contended_release(rwb);
|
||||
/*
|
||||
* rwb->readers can only hit 0 when a writer is waiting for the
|
||||
* active readers to leave the critical section.
|
||||
|
|
@ -205,6 +207,8 @@ static inline void rwbase_write_unlock(struct rwbase_rt *rwb)
|
|||
unsigned long flags;
|
||||
|
||||
raw_spin_lock_irqsave(&rtm->wait_lock, flags);
|
||||
if (trace_contended_release_enabled() && rt_mutex_has_waiters(rtm))
|
||||
trace_call__contended_release(rwb);
|
||||
__rwbase_write_unlock(rwb, WRITER_BIAS, flags);
|
||||
}
|
||||
|
||||
|
|
@ -214,6 +218,8 @@ static inline void rwbase_write_downgrade(struct rwbase_rt *rwb)
|
|||
unsigned long flags;
|
||||
|
||||
raw_spin_lock_irqsave(&rtm->wait_lock, flags);
|
||||
if (trace_contended_release_enabled() && rt_mutex_has_waiters(rtm))
|
||||
trace_call__contended_release(rwb);
|
||||
/* Release it and account current as reader */
|
||||
__rwbase_write_unlock(rwb, WRITER_BIAS - 1, flags);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1387,6 +1387,8 @@ static inline void __up_read(struct rw_semaphore *sem)
|
|||
rwsem_clear_reader_owned(sem);
|
||||
tmp = atomic_long_add_return_release(-RWSEM_READER_BIAS, &sem->count);
|
||||
DEBUG_RWSEMS_WARN_ON(tmp < 0, sem);
|
||||
if (trace_contended_release_enabled() && (tmp & RWSEM_FLAG_WAITERS))
|
||||
trace_call__contended_release(sem);
|
||||
if (unlikely((tmp & (RWSEM_LOCK_MASK|RWSEM_FLAG_WAITERS)) ==
|
||||
RWSEM_FLAG_WAITERS)) {
|
||||
clear_nonspinnable(sem);
|
||||
|
|
@ -1413,8 +1415,10 @@ static inline void __up_write(struct rw_semaphore *sem)
|
|||
preempt_disable();
|
||||
rwsem_clear_owner(sem);
|
||||
tmp = atomic_long_fetch_add_release(-RWSEM_WRITER_LOCKED, &sem->count);
|
||||
if (unlikely(tmp & RWSEM_FLAG_WAITERS))
|
||||
if (unlikely(tmp & RWSEM_FLAG_WAITERS)) {
|
||||
trace_contended_release(sem);
|
||||
rwsem_wake(sem);
|
||||
}
|
||||
preempt_enable();
|
||||
}
|
||||
|
||||
|
|
@ -1437,8 +1441,10 @@ static inline void __downgrade_write(struct rw_semaphore *sem)
|
|||
tmp = atomic_long_fetch_add_release(
|
||||
-RWSEM_WRITER_LOCKED+RWSEM_READER_BIAS, &sem->count);
|
||||
rwsem_set_reader_owned(sem);
|
||||
if (tmp & RWSEM_FLAG_WAITERS)
|
||||
if (tmp & RWSEM_FLAG_WAITERS) {
|
||||
trace_contended_release(sem);
|
||||
rwsem_downgrade_wake(sem);
|
||||
}
|
||||
preempt_enable();
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -230,6 +230,10 @@ void __sched up(struct semaphore *sem)
|
|||
sem->count++;
|
||||
else
|
||||
__up(sem, &wake_q);
|
||||
|
||||
if (trace_contended_release_enabled() && !wake_q_empty(&wake_q))
|
||||
trace_call__contended_release(sem);
|
||||
|
||||
raw_spin_unlock_irqrestore(&sem->lock, flags);
|
||||
if (!wake_q_empty(&wake_q))
|
||||
wake_up_q(&wake_q);
|
||||
|
|
|
|||
|
|
@ -164,8 +164,26 @@
|
|||
| MEMBARRIER_PRIVATE_EXPEDITED_RSEQ_BITMASK \
|
||||
| MEMBARRIER_CMD_GET_REGISTRATIONS)
|
||||
|
||||
/*
|
||||
* Scoped guard for memory barriers on entry and exit.
|
||||
* Matches memory barriers before & after rq->curr modification in scheduler.
|
||||
*/
|
||||
DEFINE_LOCK_GUARD_0(mb, smp_mb(), smp_mb())
|
||||
static DEFINE_MUTEX(membarrier_ipi_mutex);
|
||||
static DEFINE_PER_CPU(struct mutex, membarrier_cpu_mutexes);
|
||||
|
||||
#define SERIALIZE_IPI() guard(mutex)(&membarrier_ipi_mutex)
|
||||
#define SERIALIZE_IPI_CPU(cpu_id) guard(mutex)(&per_cpu(membarrier_cpu_mutexes, cpu_id))
|
||||
|
||||
static int __init membarrier_init(void)
|
||||
{
|
||||
int i;
|
||||
|
||||
for_each_possible_cpu(i)
|
||||
mutex_init(&per_cpu(membarrier_cpu_mutexes, i));
|
||||
return 0;
|
||||
}
|
||||
core_initcall(membarrier_init);
|
||||
|
||||
static void ipi_mb(void *info)
|
||||
{
|
||||
|
|
@ -258,23 +276,19 @@ void membarrier_update_current_mm(struct mm_struct *next_mm)
|
|||
|
||||
static int membarrier_global_expedited(void)
|
||||
{
|
||||
cpumask_var_t __free(free_cpumask_var) tmpmask = CPUMASK_VAR_NULL;
|
||||
int cpu;
|
||||
cpumask_var_t tmpmask;
|
||||
|
||||
if (num_online_cpus() == 1)
|
||||
return 0;
|
||||
|
||||
/*
|
||||
* Matches memory barriers after rq->curr modification in
|
||||
* scheduler.
|
||||
*/
|
||||
smp_mb(); /* system call entry is not a mb. */
|
||||
|
||||
if (!zalloc_cpumask_var(&tmpmask, GFP_KERNEL))
|
||||
return -ENOMEM;
|
||||
|
||||
guard(mb)();
|
||||
SERIALIZE_IPI();
|
||||
cpus_read_lock();
|
||||
guard(cpus_read_lock)();
|
||||
|
||||
rcu_read_lock();
|
||||
for_each_online_cpu(cpu) {
|
||||
struct task_struct *p;
|
||||
|
|
@ -310,21 +324,11 @@ static int membarrier_global_expedited(void)
|
|||
smp_call_function_many(tmpmask, ipi_mb, NULL, 1);
|
||||
preempt_enable();
|
||||
|
||||
free_cpumask_var(tmpmask);
|
||||
cpus_read_unlock();
|
||||
|
||||
/*
|
||||
* Memory barrier on the caller thread _after_ we finished
|
||||
* waiting for the last IPI. Matches memory barriers before
|
||||
* rq->curr modification in scheduler.
|
||||
*/
|
||||
smp_mb(); /* exit from system call is not a mb */
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int membarrier_private_expedited(int flags, int cpu_id)
|
||||
{
|
||||
cpumask_var_t tmpmask;
|
||||
struct mm_struct *mm = current->mm;
|
||||
smp_call_func_t ipi_func = ipi_mb;
|
||||
|
||||
|
|
@ -361,30 +365,45 @@ static int membarrier_private_expedited(int flags, int cpu_id)
|
|||
* On RISC-V, this barrier pairing is also needed for the
|
||||
* SYNC_CORE command when switching between processes, cf.
|
||||
* the inline comments in membarrier_arch_switch_mm().
|
||||
*
|
||||
* Memory barrier on the caller thread _after_ we finished
|
||||
* waiting for the last IPI. Matches memory barriers before
|
||||
* rq->curr modification in scheduler.
|
||||
*/
|
||||
smp_mb(); /* system call entry is not a mb. */
|
||||
|
||||
if (cpu_id < 0 && !zalloc_cpumask_var(&tmpmask, GFP_KERNEL))
|
||||
return -ENOMEM;
|
||||
|
||||
SERIALIZE_IPI();
|
||||
cpus_read_lock();
|
||||
|
||||
guard(mb)();
|
||||
if (cpu_id >= 0) {
|
||||
if (cpu_id >= nr_cpu_ids || !cpu_possible(cpu_id))
|
||||
return 0;
|
||||
|
||||
SERIALIZE_IPI_CPU(cpu_id);
|
||||
guard(cpus_read_lock)();
|
||||
struct task_struct *p;
|
||||
|
||||
if (cpu_id >= nr_cpu_ids || !cpu_online(cpu_id))
|
||||
goto out;
|
||||
if (!cpu_online(cpu_id))
|
||||
return 0;
|
||||
|
||||
rcu_read_lock();
|
||||
p = rcu_dereference(cpu_rq(cpu_id)->curr);
|
||||
if (!p || p->mm != mm) {
|
||||
rcu_read_unlock();
|
||||
goto out;
|
||||
return 0;
|
||||
}
|
||||
rcu_read_unlock();
|
||||
/*
|
||||
* smp_call_function_single() will call ipi_func() if cpu_id
|
||||
* is the calling CPU.
|
||||
*/
|
||||
smp_call_function_single(cpu_id, ipi_func, NULL, 1);
|
||||
} else {
|
||||
cpumask_var_t __free(free_cpumask_var) tmpmask = CPUMASK_VAR_NULL;
|
||||
int cpu;
|
||||
|
||||
if (!zalloc_cpumask_var(&tmpmask, GFP_KERNEL))
|
||||
return -ENOMEM;
|
||||
|
||||
SERIALIZE_IPI();
|
||||
guard(cpus_read_lock)();
|
||||
|
||||
rcu_read_lock();
|
||||
for_each_online_cpu(cpu) {
|
||||
struct task_struct *p;
|
||||
|
|
@ -394,15 +413,6 @@ static int membarrier_private_expedited(int flags, int cpu_id)
|
|||
__cpumask_set_cpu(cpu, tmpmask);
|
||||
}
|
||||
rcu_read_unlock();
|
||||
}
|
||||
|
||||
if (cpu_id >= 0) {
|
||||
/*
|
||||
* smp_call_function_single() will call ipi_func() if cpu_id
|
||||
* is the calling CPU.
|
||||
*/
|
||||
smp_call_function_single(cpu_id, ipi_func, NULL, 1);
|
||||
} else {
|
||||
/*
|
||||
* For regular membarrier, we can save a few cycles by
|
||||
* skipping the current cpu -- we're about to do smp_mb()
|
||||
|
|
@ -429,18 +439,6 @@ static int membarrier_private_expedited(int flags, int cpu_id)
|
|||
}
|
||||
}
|
||||
|
||||
out:
|
||||
if (cpu_id < 0)
|
||||
free_cpumask_var(tmpmask);
|
||||
cpus_read_unlock();
|
||||
|
||||
/*
|
||||
* Memory barrier on the caller thread _after_ we finished
|
||||
* waiting for the last IPI. Matches memory barriers before
|
||||
* rq->curr modification in scheduler.
|
||||
*/
|
||||
smp_mb(); /* exit from system call is not a mb */
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
|
|||
|
|
@ -630,7 +630,7 @@ config DEBUG_FORCE_WEAK_PER_CPU
|
|||
|
||||
config WARN_CONTEXT_ANALYSIS
|
||||
bool "Compiler context-analysis warnings"
|
||||
depends on CC_IS_CLANG && CLANG_VERSION >= 220100
|
||||
depends on CC_IS_CLANG && CLANG_VERSION >= 230000
|
||||
# Branch profiling re-defines "if", which messes with the compiler's
|
||||
# ability to analyze __cond_acquires(..), resulting in false positives.
|
||||
depends on !TRACE_BRANCH_PROFILING
|
||||
|
|
@ -641,7 +641,7 @@ config WARN_CONTEXT_ANALYSIS
|
|||
and releasing user-definable "context locks".
|
||||
|
||||
Clang's name of the feature is "Thread Safety Analysis". Requires
|
||||
Clang 22.1.0 or later.
|
||||
Clang 23 or later.
|
||||
|
||||
Produces warnings by default. Select CONFIG_WERROR if you wish to
|
||||
turn these warnings into errors.
|
||||
|
|
|
|||
|
|
@ -1431,10 +1431,9 @@ static void dotest(void (*testcase_fn)(void), int expected, int lockclass_mask)
|
|||
{
|
||||
int saved_preempt_count = preempt_count();
|
||||
#ifdef CONFIG_PREEMPT_RT
|
||||
#ifdef CONFIG_SMP
|
||||
int saved_mgd_count = current->migration_disabled;
|
||||
#endif
|
||||
int saved_rcu_count = current->rcu_read_lock_nesting;
|
||||
int saved_sched_rt_mutex = current->sched_rt_mutex;
|
||||
#endif
|
||||
|
||||
WARN_ON(irqs_disabled());
|
||||
|
|
@ -1471,10 +1470,10 @@ static void dotest(void (*testcase_fn)(void), int expected, int lockclass_mask)
|
|||
preempt_count_set(saved_preempt_count);
|
||||
|
||||
#ifdef CONFIG_PREEMPT_RT
|
||||
#ifdef CONFIG_SMP
|
||||
current->sched_rt_mutex = saved_sched_rt_mutex;
|
||||
|
||||
while (current->migration_disabled > saved_mgd_count)
|
||||
migrate_enable();
|
||||
#endif
|
||||
|
||||
while (current->rcu_read_lock_nesting > saved_rcu_count)
|
||||
rcu_read_unlock();
|
||||
|
|
|
|||
|
|
@ -159,6 +159,10 @@ TEST_SPINLOCK_COMMON(read_lock,
|
|||
struct test_mutex_data {
|
||||
struct mutex mtx;
|
||||
int counter __guarded_by(&mtx);
|
||||
|
||||
struct mutex mtx2;
|
||||
int anyread __guarded_by(&mtx, &mtx2);
|
||||
int *anyptr __pt_guarded_by(&mtx, &mtx2);
|
||||
};
|
||||
|
||||
static void __used test_mutex_init(struct test_mutex_data *d)
|
||||
|
|
@ -219,6 +223,26 @@ static void __used test_mutex_cond_guard(struct test_mutex_data *d)
|
|||
}
|
||||
}
|
||||
|
||||
static void __used test_mutex_multiguard(struct test_mutex_data *d)
|
||||
{
|
||||
mutex_lock(&d->mtx);
|
||||
(void)d->anyread;
|
||||
(void)*d->anyptr;
|
||||
mutex_unlock(&d->mtx);
|
||||
|
||||
mutex_lock(&d->mtx2);
|
||||
(void)d->anyread;
|
||||
(void)*d->anyptr;
|
||||
mutex_unlock(&d->mtx2);
|
||||
|
||||
mutex_lock(&d->mtx);
|
||||
mutex_lock(&d->mtx2);
|
||||
d->anyread++;
|
||||
(*d->anyptr)++;
|
||||
mutex_unlock(&d->mtx2);
|
||||
mutex_unlock(&d->mtx);
|
||||
}
|
||||
|
||||
struct test_seqlock_data {
|
||||
seqlock_t sl;
|
||||
int counter __guarded_by(&sl);
|
||||
|
|
|
|||
|
|
@ -94,6 +94,7 @@ fn as_raw(&self) -> *mut bindings::completion {
|
|||
///
|
||||
/// This method wakes up all tasks waiting on this completion; after this operation the
|
||||
/// completion is permanently done, i.e. signals all current and future waiters.
|
||||
#[inline]
|
||||
pub fn complete_all(&self) {
|
||||
// SAFETY: `self.as_raw()` is a pointer to a valid `struct completion`.
|
||||
unsafe { bindings::complete_all(self.as_raw()) };
|
||||
|
|
@ -105,6 +106,7 @@ pub fn complete_all(&self) {
|
|||
/// timeout.
|
||||
///
|
||||
/// See also [`Completion::complete_all`].
|
||||
#[inline]
|
||||
pub fn wait_for_completion(&self) {
|
||||
// SAFETY: `self.as_raw()` is a pointer to a valid `struct completion`.
|
||||
unsafe { bindings::wait_for_completion(self.as_raw()) };
|
||||
|
|
|
|||
|
|
@ -27,12 +27,15 @@
|
|||
#include "futextest.h"
|
||||
#include "../../kselftest_harness.h"
|
||||
|
||||
#include <dlfcn.h>
|
||||
#include <errno.h>
|
||||
#include <pthread.h>
|
||||
#include <signal.h>
|
||||
#include <stdint.h>
|
||||
#include <stdatomic.h>
|
||||
#include <stdbool.h>
|
||||
#include <stddef.h>
|
||||
#include <sys/auxv.h>
|
||||
#include <sys/mman.h>
|
||||
#include <sys/wait.h>
|
||||
|
||||
|
|
@ -42,6 +45,10 @@
|
|||
|
||||
#define SLEEP_US 100
|
||||
|
||||
#if __SIZEOF_LONG__ == 8
|
||||
# define BUILD_64
|
||||
#endif
|
||||
|
||||
static pthread_barrier_t barrier, barrier2;
|
||||
|
||||
static int set_robust_list(struct robust_list_head *head, size_t len)
|
||||
|
|
@ -54,6 +61,12 @@ static int get_robust_list(int pid, struct robust_list_head **head, size_t *len_
|
|||
return syscall(SYS_get_robust_list, pid, head, len_ptr);
|
||||
}
|
||||
|
||||
static int sys_futex_robust_unlock(_Atomic(uint32_t) *uaddr, unsigned int op, int val,
|
||||
void *list_op_pending, unsigned int val3)
|
||||
{
|
||||
return syscall(SYS_futex, uaddr, op, val, NULL, list_op_pending, val3, 0);
|
||||
}
|
||||
|
||||
/*
|
||||
* Basic lock struct, contains just the futex word and the robust list element
|
||||
* Real implementations have also a *prev to easily walk in the list
|
||||
|
|
@ -549,4 +562,230 @@ TEST(test_circular_list)
|
|||
ksft_test_result_pass("%s\n", __func__);
|
||||
}
|
||||
|
||||
/*
|
||||
* Below are tests for the fix of robust release race condition. Please read the following
|
||||
* thread to learn more about the issue in the first place and why the following functions fix it:
|
||||
* https://lore.kernel.org/lkml/20260316162316.356674433@kernel.org/
|
||||
*/
|
||||
|
||||
/*
|
||||
* Auxiliary code for binding the vDSO functions
|
||||
*/
|
||||
static void *get_vdso_func_addr(const char *function)
|
||||
{
|
||||
const char *vdso_names[] = {
|
||||
"linux-vdso.so.1", "linux-gate.so.1", "linux-vdso32.so.1", "linux-vdso64.so.1",
|
||||
};
|
||||
|
||||
for (int i = 0; i < ARRAY_SIZE(vdso_names); i++) {
|
||||
void *vdso = dlopen(vdso_names[i], RTLD_LAZY | RTLD_LOCAL | RTLD_NOLOAD);
|
||||
|
||||
if (vdso)
|
||||
return dlsym(vdso, function);
|
||||
}
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/*
|
||||
* These are the real vDSO function signatures:
|
||||
*
|
||||
* __vdso_futex_robust_list64_try_unlock(__u32 *lock, __u32 tid, __u64 *pop)
|
||||
* __vdso_futex_robust_list32_try_unlock(__u32 *lock, __u32 tid, __u32 *pop)
|
||||
*
|
||||
* So for the generic entry point we need to use a void pointer as the last argument
|
||||
*/
|
||||
FIXTURE(vdso_unlock)
|
||||
{
|
||||
uint32_t (*vdso)(_Atomic(uint32_t) *lock, uint32_t tid, void *pop);
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT(vdso_unlock)
|
||||
{
|
||||
bool is_32;
|
||||
char func_name[];
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(vdso_unlock)
|
||||
{
|
||||
self->vdso = get_vdso_func_addr(variant->func_name);
|
||||
}
|
||||
|
||||
FIXTURE_TEARDOWN(vdso_unlock) {}
|
||||
|
||||
FIXTURE_VARIANT_ADD(vdso_unlock, 32)
|
||||
{
|
||||
.func_name = "__vdso_futex_robust_list32_try_unlock",
|
||||
.is_32 = true,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(vdso_unlock, 64)
|
||||
{
|
||||
.func_name = "__vdso_futex_robust_list64_try_unlock",
|
||||
.is_32 = false,
|
||||
};
|
||||
|
||||
/*
|
||||
* Test the vDSO robust_listXX_try_unlock() for the uncontended case. The virtual syscall should
|
||||
* return the thread ID of the lock owner, the lock word must be 0 and the list_op_pending should
|
||||
* be NULL.
|
||||
*/
|
||||
TEST_F(vdso_unlock, test_robust_try_unlock_uncontended)
|
||||
{
|
||||
struct lock_struct lock = { .futex = 0 };
|
||||
_Atomic(unsigned int) *futex = &lock.futex;
|
||||
struct robust_list_head head;
|
||||
uintptr_t exp = (uintptr_t) NULL;
|
||||
pid_t tid = gettid();
|
||||
int ret;
|
||||
|
||||
if (!self->vdso) {
|
||||
ksft_test_result_skip("%s not found\n", variant->func_name);
|
||||
return;
|
||||
}
|
||||
|
||||
*futex = tid;
|
||||
|
||||
ret = set_list(&head);
|
||||
if (ret)
|
||||
ksft_test_result_fail("set_robust_list error\n");
|
||||
|
||||
head.list_op_pending = &lock.list;
|
||||
|
||||
ret = self->vdso(futex, tid, &head.list_op_pending);
|
||||
|
||||
ASSERT_EQ(ret, tid);
|
||||
ASSERT_EQ(*futex, 0);
|
||||
|
||||
/* Check only the lower 32 bits for the 32-bit entry point */
|
||||
if (variant->is_32) {
|
||||
exp = (uintptr_t)(unsigned long)&lock.list;
|
||||
exp &= ~0xFFFFFFFFULL;
|
||||
}
|
||||
|
||||
ASSERT_EQ((uintptr_t)(unsigned long)head.list_op_pending, exp);
|
||||
}
|
||||
|
||||
/*
|
||||
* If the lock is contended, the operation fails. The return value is the value found at the
|
||||
* futex word (tid | FUTEX_WAITERS), the futex word is not modified and the list_op_pending is_32
|
||||
* not cleared.
|
||||
*/
|
||||
TEST_F(vdso_unlock, test_robust_try_unlock_contended)
|
||||
{
|
||||
struct lock_struct lock = { .futex = 0 };
|
||||
_Atomic(unsigned int) *futex = &lock.futex;
|
||||
struct robust_list_head head;
|
||||
pid_t tid = gettid();
|
||||
int ret;
|
||||
|
||||
if (!self->vdso) {
|
||||
ksft_test_result_skip("%s not found\n", variant->func_name);
|
||||
return;
|
||||
}
|
||||
|
||||
*futex = tid | FUTEX_WAITERS;
|
||||
|
||||
ret = set_list(&head);
|
||||
if (ret)
|
||||
ksft_test_result_fail("set_robust_list error\n");
|
||||
|
||||
head.list_op_pending = &lock.list;
|
||||
|
||||
ret = self->vdso(futex, tid, &head.list_op_pending);
|
||||
|
||||
ASSERT_EQ(ret, tid | FUTEX_WAITERS);
|
||||
ASSERT_EQ(*futex, tid | FUTEX_WAITERS);
|
||||
ASSERT_EQ(head.list_op_pending, &lock.list);
|
||||
}
|
||||
|
||||
FIXTURE(futex_op) {};
|
||||
|
||||
FIXTURE_VARIANT(futex_op)
|
||||
{
|
||||
unsigned int op;
|
||||
unsigned int val3;
|
||||
};
|
||||
|
||||
FIXTURE_SETUP(futex_op) {}
|
||||
|
||||
FIXTURE_TEARDOWN(futex_op) {}
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, wake)
|
||||
{
|
||||
.op = FUTEX_WAKE,
|
||||
.val3 = 0,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, wake_bitset)
|
||||
{
|
||||
.op = FUTEX_WAKE_BITSET,
|
||||
.val3 = FUTEX_BITSET_MATCH_ANY,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, unlock_pi)
|
||||
{
|
||||
.op = FUTEX_UNLOCK_PI,
|
||||
.val3 = 0,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, wake32)
|
||||
{
|
||||
.op = FUTEX_WAKE | FUTEX_ROBUST_LIST32,
|
||||
.val3 = 0,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, wake_bitset32)
|
||||
{
|
||||
.op = FUTEX_WAKE_BITSET | FUTEX_ROBUST_LIST32,
|
||||
.val3 = FUTEX_BITSET_MATCH_ANY,
|
||||
};
|
||||
|
||||
FIXTURE_VARIANT_ADD(futex_op, unlock_pi32)
|
||||
{
|
||||
.op = FUTEX_UNLOCK_PI | FUTEX_ROBUST_LIST32,
|
||||
.val3 = 0,
|
||||
};
|
||||
|
||||
/*
|
||||
* The syscall should return the number of tasks waken (for this test, 0), clear the futex word and
|
||||
* clear list_op_pending
|
||||
*/
|
||||
TEST_F(futex_op, test_futex_robust_unlock)
|
||||
{
|
||||
struct lock_struct lock = { .futex = 0 };
|
||||
_Atomic(unsigned int) *futex = &lock.futex;
|
||||
uintptr_t exp = (uintptr_t) NULL;
|
||||
struct robust_list_head head;
|
||||
pid_t tid = gettid();
|
||||
int ret;
|
||||
|
||||
#ifndef BUILD_64
|
||||
if (!(variant->op & FUTEX_ROBUST_LIST32)) {
|
||||
ksft_test_result_skip("Not supported for 32 bit build\n");
|
||||
return;
|
||||
}
|
||||
#endif
|
||||
|
||||
*futex = tid | FUTEX_WAITERS;
|
||||
|
||||
ret = set_list(&head);
|
||||
if (ret)
|
||||
ksft_test_result_fail("set_robust_list error\n");
|
||||
|
||||
head.list_op_pending = &lock.list;
|
||||
|
||||
ret = sys_futex_robust_unlock(futex, FUTEX_ROBUST_UNLOCK | variant->op, tid,
|
||||
&head.list_op_pending, variant->val3);
|
||||
|
||||
ASSERT_EQ(ret, 0);
|
||||
ASSERT_EQ(*futex, 0);
|
||||
|
||||
if (variant->op & FUTEX_ROBUST_LIST32) {
|
||||
exp = (uint64_t)(unsigned long)&lock.list;
|
||||
exp &= ~0xFFFFFFFFULL;
|
||||
}
|
||||
|
||||
ASSERT_EQ((uintptr_t)(unsigned long)head.list_op_pending, exp);
|
||||
}
|
||||
|
||||
TEST_HARNESS_MAIN
|
||||
|
|
|
|||
|
|
@ -38,6 +38,12 @@ typedef volatile u_int32_t futex_t;
|
|||
#ifndef FUTEX_CMP_REQUEUE_PI
|
||||
#define FUTEX_CMP_REQUEUE_PI 12
|
||||
#endif
|
||||
#ifndef FUTEX_ROBUST_UNLOCK
|
||||
#define FUTEX_ROBUST_UNLOCK 512
|
||||
#endif
|
||||
#ifndef FUTEX_ROBUST_LIST32
|
||||
#define FUTEX_ROBUST_LIST32 1024
|
||||
#endif
|
||||
#ifndef FUTEX_WAIT_REQUEUE_PI_PRIVATE
|
||||
#define FUTEX_WAIT_REQUEUE_PI_PRIVATE (FUTEX_WAIT_REQUEUE_PI | \
|
||||
FUTEX_PRIVATE_FLAG)
|
||||
|
|
|
|||
|
|
@ -1,8 +1,9 @@
|
|||
# SPDX-License-Identifier: GPL-2.0-only
|
||||
CFLAGS += -g $(KHDR_INCLUDES)
|
||||
CFLAGS += -g $(KHDR_INCLUDES) -pthread -I../../../../tools/include
|
||||
LDLIBS += -lpthread
|
||||
|
||||
TEST_GEN_PROGS := membarrier_test_single_thread \
|
||||
membarrier_test_multi_thread
|
||||
membarrier_test_multi_thread \
|
||||
membarrier_rseq_stress
|
||||
|
||||
include ../lib.mk
|
||||
|
|
|
|||
951
tools/testing/selftests/membarrier/membarrier_rseq_stress.c
Normal file
951
tools/testing/selftests/membarrier/membarrier_rseq_stress.c
Normal file
|
|
@ -0,0 +1,951 @@
|
|||
// SPDX-License-Identifier: GPL-2.0
|
||||
/*
|
||||
* Membarrier stress test for CFS throttle interactions.
|
||||
*
|
||||
* Reproducer for the interaction between CFS throttle and expedited membarrier.
|
||||
*/
|
||||
|
||||
#ifndef _GNU_SOURCE
|
||||
#define _GNU_SOURCE
|
||||
#endif
|
||||
#include <stdio.h>
|
||||
#include <stdlib.h>
|
||||
#include <string.h>
|
||||
#include <unistd.h>
|
||||
#include <pthread.h>
|
||||
#include <syscall.h>
|
||||
#include <sys/stat.h>
|
||||
#include <sys/types.h>
|
||||
#include <sys/wait.h>
|
||||
#include <fcntl.h>
|
||||
#include <stdint.h>
|
||||
#include <errno.h>
|
||||
#include <sched.h>
|
||||
#include <time.h>
|
||||
#include <signal.h>
|
||||
#include <stdatomic.h>
|
||||
#include <dirent.h>
|
||||
#include <sys/prctl.h>
|
||||
#include <sys/mman.h>
|
||||
|
||||
#include "../kselftest.h"
|
||||
|
||||
/* -- Architecture-specific rseq signature -- */
|
||||
#if defined(__x86_64__) || defined(__i386__)
|
||||
# define RSEQ_SIG 0x53053053U
|
||||
#elif defined(__aarch64__)
|
||||
# define RSEQ_SIG 0xd428bc00U
|
||||
#elif defined(__powerpc__) || defined(__powerpc64__)
|
||||
# define RSEQ_SIG 0x0f000000U
|
||||
#elif defined(__s390__) || defined(__s390x__)
|
||||
# define RSEQ_SIG 0x0c000000U
|
||||
#else
|
||||
# define RSEQ_SIG 0
|
||||
# define UNSUPPORTED_ARCH 1
|
||||
#endif
|
||||
|
||||
/* -- rseq ABI (kernel uapi; define locally for portability) -- */
|
||||
#define RSEQ_CPU_ID_UNINITIALIZED ((__u32)-1)
|
||||
|
||||
#include <linux/compiler.h>
|
||||
|
||||
struct rseq_abi {
|
||||
__u32 cpu_id_start;
|
||||
__u32 cpu_id;
|
||||
__u64 rseq_cs;
|
||||
__u32 flags;
|
||||
__u32 node_id;
|
||||
__u32 mm_cid;
|
||||
char end[0];
|
||||
} __aligned(32);
|
||||
|
||||
/* -- membarrier constants (not in all distro headers) -- */
|
||||
#ifndef MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ
|
||||
# define MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ (1 << 7)
|
||||
#endif
|
||||
#ifndef MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ
|
||||
# define MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ (1 << 8)
|
||||
#endif
|
||||
#ifndef MEMBARRIER_CMD_FLAG_CPU
|
||||
# define MEMBARRIER_CMD_FLAG_CPU (1 << 0)
|
||||
#endif
|
||||
|
||||
/* -- Test parameters -- */
|
||||
#define N_SIBLINGS 2000
|
||||
#define NEST_DEPTH 5
|
||||
static char g_cgroup_path[4096];
|
||||
static int use_cgroup_v2;
|
||||
|
||||
#define CFS_QUOTA_US 1000
|
||||
#define CFS_PERIOD_US 5000
|
||||
#define N_HAMMER_PER_CPU 25
|
||||
#define N_BURNER_PER_CPU 50
|
||||
#define MAX_STRESS_CPUS 1024
|
||||
#define TEST_DURATION_SEC 20
|
||||
|
||||
/* Latency thresholds for the sentinel */
|
||||
#define LATENCY_WARN_MS 50
|
||||
#define LATENCY_CRITICAL_MS 200
|
||||
|
||||
/* Sentinel sampling interval */
|
||||
#define SENTINEL_INTERVAL_US 500
|
||||
|
||||
/* -- Shared globals -- */
|
||||
static atomic_int g_stop;
|
||||
static atomic_int g_stop_sentinel;
|
||||
static atomic_long g_max_latency_us;
|
||||
static atomic_long g_interval_max_latency_us;
|
||||
static atomic_long g_mb_ok;
|
||||
static atomic_long g_mb_err;
|
||||
static int g_ncpus_stress;
|
||||
static int *g_stress_cpus;
|
||||
|
||||
static atomic_int g_test_ready;
|
||||
|
||||
/* Per-thread rseq ABI block registered with the kernel */
|
||||
static __thread struct rseq_abi tls_rseq
|
||||
__attribute__((tls_model("initial-exec"))) __aligned(32) = {
|
||||
.cpu_id = RSEQ_CPU_ID_UNINITIALIZED,
|
||||
};
|
||||
|
||||
/* -- Utility -- */
|
||||
static int write_file(const char *path, const char *val)
|
||||
{
|
||||
int fd = open(path, O_WRONLY | O_CLOEXEC);
|
||||
|
||||
if (fd < 0)
|
||||
return -errno;
|
||||
|
||||
size_t len = strlen(val);
|
||||
ssize_t r = write(fd, val, len);
|
||||
|
||||
close(fd);
|
||||
if (r < 0)
|
||||
return -errno;
|
||||
if ((size_t)r != len)
|
||||
return -EIO;
|
||||
return 0;
|
||||
}
|
||||
|
||||
static uint64_t monotonic_us(void)
|
||||
{
|
||||
struct timespec ts;
|
||||
|
||||
clock_gettime(CLOCK_MONOTONIC, &ts);
|
||||
return (uint64_t)ts.tv_sec * 1000000ULL + ts.tv_nsec / 1000ULL;
|
||||
}
|
||||
|
||||
static void update_max_latency(long lat)
|
||||
{
|
||||
long old = atomic_load_explicit(&g_max_latency_us, memory_order_relaxed);
|
||||
|
||||
while (lat > old) {
|
||||
if (atomic_compare_exchange_weak_explicit(&g_max_latency_us, &old, lat,
|
||||
memory_order_relaxed, memory_order_relaxed))
|
||||
break;
|
||||
}
|
||||
|
||||
old = atomic_load_explicit(&g_interval_max_latency_us, memory_order_relaxed);
|
||||
while (lat > old) {
|
||||
if (atomic_compare_exchange_weak_explicit(&g_interval_max_latency_us, &old, lat,
|
||||
memory_order_relaxed, memory_order_relaxed))
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
static void init_stress_cpus(void)
|
||||
{
|
||||
cpu_set_t set;
|
||||
int capacity = MAX_STRESS_CPUS;
|
||||
|
||||
g_stress_cpus = malloc(capacity * sizeof(int));
|
||||
if (!g_stress_cpus)
|
||||
ksft_exit_fail_msg("malloc failed for g_stress_cpus\n");
|
||||
|
||||
if (sched_getaffinity(0, sizeof(set), &set) < 0)
|
||||
ksft_exit_fail_msg("sched_getaffinity failed\n");
|
||||
|
||||
for (int i = 0; i < CPU_SETSIZE && g_ncpus_stress < capacity; i++) {
|
||||
if (CPU_ISSET(i, &set))
|
||||
g_stress_cpus[g_ncpus_stress++] = i;
|
||||
}
|
||||
|
||||
if (g_ncpus_stress == 0)
|
||||
ksft_exit_skip("No CPUs available for stress test\n");
|
||||
|
||||
ksft_print_msg("Stressing %d CPUs discovered via affinity\n", g_ncpus_stress);
|
||||
}
|
||||
|
||||
/* -- rseq / membarrier helpers -- */
|
||||
static int rseq_register_thread(void)
|
||||
{
|
||||
int r = syscall(SYS_rseq, &tls_rseq, sizeof(tls_rseq), 0, RSEQ_SIG);
|
||||
|
||||
return (r == 0 || errno == EBUSY || errno == EINVAL) ? 0 : -1;
|
||||
}
|
||||
|
||||
static int rseq_register_thread_at(struct rseq_abi *rseq)
|
||||
{
|
||||
int r = syscall(SYS_rseq, rseq, sizeof(*rseq), 0, RSEQ_SIG);
|
||||
|
||||
return (r == 0 || errno == EBUSY || errno == EINVAL) ? 0 : -1;
|
||||
}
|
||||
|
||||
static int membarrier_register_rseq_mm(void)
|
||||
{
|
||||
return syscall(SYS_membarrier,
|
||||
MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ, 0, 0);
|
||||
}
|
||||
|
||||
/* -- cgroup helpers -- */
|
||||
static void rm_cgroup_recursive(const char *path)
|
||||
{
|
||||
DIR *dir = opendir(path);
|
||||
|
||||
if (!dir)
|
||||
return;
|
||||
struct dirent *entry;
|
||||
|
||||
while ((entry = readdir(dir)) != NULL) {
|
||||
if (strcmp(entry->d_name, ".") == 0 || strcmp(entry->d_name, "..") == 0)
|
||||
continue;
|
||||
if (entry->d_type == DT_DIR) {
|
||||
char sub_path[4096];
|
||||
|
||||
snprintf(sub_path, sizeof(sub_path), "%s/%s", path, entry->d_name);
|
||||
rm_cgroup_recursive(sub_path);
|
||||
}
|
||||
}
|
||||
closedir(dir);
|
||||
rmdir(path);
|
||||
}
|
||||
|
||||
static void cgroup_teardown(void);
|
||||
|
||||
static int cgroup_setup(void)
|
||||
{
|
||||
struct stat st;
|
||||
|
||||
if (stat("/sys/fs/cgroup/cpu", &st) == 0) {
|
||||
use_cgroup_v2 = 0;
|
||||
snprintf(g_cgroup_path, sizeof(g_cgroup_path),
|
||||
"/sys/fs/cgroup/cpu/membarrier_stress_test");
|
||||
} else if (stat("/dev/cgroup/cpu", &st) == 0) {
|
||||
use_cgroup_v2 = 0;
|
||||
snprintf(g_cgroup_path, sizeof(g_cgroup_path),
|
||||
"/dev/cgroup/cpu/membarrier_stress_test");
|
||||
} else if (stat("/cgroup/cpu", &st) == 0) {
|
||||
use_cgroup_v2 = 0;
|
||||
snprintf(g_cgroup_path, sizeof(g_cgroup_path),
|
||||
"/cgroup/cpu/membarrier_stress_test");
|
||||
} else if (stat("/sys/fs/cgroup/cgroup.controllers", &st) == 0) {
|
||||
use_cgroup_v2 = 1;
|
||||
snprintf(g_cgroup_path, sizeof(g_cgroup_path),
|
||||
"/sys/fs/cgroup/membarrier_stress_test");
|
||||
} else {
|
||||
ksft_print_msg("WARN: cgroup mount not found. Using v2 at /sys/fs/cgroup\n");
|
||||
use_cgroup_v2 = 1;
|
||||
snprintf(g_cgroup_path, sizeof(g_cgroup_path),
|
||||
"/sys/fs/cgroup/membarrier_stress_test");
|
||||
}
|
||||
|
||||
/* Robust cleanup before setup */
|
||||
cgroup_teardown();
|
||||
|
||||
if (use_cgroup_v2) {
|
||||
/* Enable cpu controller in root cgroup */
|
||||
if (write_file("/sys/fs/cgroup/cgroup.subtree_control", "+cpu") < 0)
|
||||
ksft_print_msg("WARN: failed to enable cpu controller in /sys/fs/cgroup\n");
|
||||
}
|
||||
|
||||
if (mkdir(g_cgroup_path, 0755) < 0 && errno != EEXIST) {
|
||||
ksft_print_msg("mkdir base %s failed: %s\n", g_cgroup_path, strerror(errno));
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (use_cgroup_v2) {
|
||||
char ctrl_path[4096];
|
||||
|
||||
snprintf(ctrl_path, sizeof(ctrl_path), "%s/cgroup.subtree_control", g_cgroup_path);
|
||||
if (write_file(ctrl_path, "+cpu") < 0)
|
||||
ksft_print_msg("WARN: failed to enable cpu controller in %s\n",
|
||||
g_cgroup_path);
|
||||
}
|
||||
|
||||
for (int i = 0; i < N_SIBLINGS; i++) {
|
||||
char sibling_path[4096];
|
||||
|
||||
snprintf(sibling_path, sizeof(sibling_path), "%s/n%d", g_cgroup_path, i);
|
||||
if (mkdir(sibling_path, 0755) < 0 && errno != EEXIST) {
|
||||
ksft_print_msg("mkdir wide %s failed: %s\n", sibling_path, strerror(errno));
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (use_cgroup_v2) {
|
||||
char ctrl_path[4096];
|
||||
|
||||
snprintf(ctrl_path, sizeof(ctrl_path),
|
||||
"%s/cgroup.subtree_control", sibling_path);
|
||||
if (write_file(ctrl_path, "+cpu") < 0)
|
||||
ksft_print_msg("WARN: failed to enable cpu controller in %s\n",
|
||||
sibling_path);
|
||||
}
|
||||
|
||||
char current_path[4096];
|
||||
|
||||
snprintf(current_path, sizeof(current_path), "%s", sibling_path);
|
||||
for (int j = 0; j < NEST_DEPTH; j++) {
|
||||
snprintf(current_path + strlen(current_path),
|
||||
sizeof(current_path) - strlen(current_path), "/d%d", j);
|
||||
if (mkdir(current_path, 0755) < 0 && errno != EEXIST) {
|
||||
ksft_print_msg("mkdir deep %s failed: %s\n",
|
||||
current_path, strerror(errno));
|
||||
return -1;
|
||||
}
|
||||
|
||||
/* Enable for all but the leaf */
|
||||
if (use_cgroup_v2 && j < NEST_DEPTH - 1) {
|
||||
char ctrl_path[4096];
|
||||
|
||||
snprintf(ctrl_path, sizeof(ctrl_path), "%s/cgroup.subtree_control",
|
||||
current_path);
|
||||
if (write_file(ctrl_path, "+cpu") < 0)
|
||||
ksft_print_msg("WARN: cannot enable cpu controller in %s\n",
|
||||
current_path);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
char quota[64], period[64], max_str[128];
|
||||
|
||||
snprintf(quota, sizeof(quota), "%d", CFS_QUOTA_US);
|
||||
snprintf(period, sizeof(period), "%d", CFS_PERIOD_US);
|
||||
snprintf(max_str, sizeof(max_str), "%d %d", CFS_QUOTA_US, CFS_PERIOD_US);
|
||||
|
||||
if (use_cgroup_v2) {
|
||||
char max_path[4096];
|
||||
|
||||
snprintf(max_path, sizeof(max_path), "%s/cpu.max", g_cgroup_path);
|
||||
if (write_file(max_path, max_str) < 0) {
|
||||
ksft_print_msg("ERROR: cannot write cpu.max at %s\n", max_path);
|
||||
return -1;
|
||||
}
|
||||
ksft_print_msg("cgroup (v2) %s: cpu.max=%s\n", g_cgroup_path, max_str);
|
||||
} else {
|
||||
char quota_path[4096], period_path[4096];
|
||||
|
||||
snprintf(quota_path, sizeof(quota_path), "%s/cpu.cfs_quota_us", g_cgroup_path);
|
||||
snprintf(period_path, sizeof(period_path), "%s/cpu.cfs_period_us", g_cgroup_path);
|
||||
|
||||
if (write_file(period_path, period) < 0) {
|
||||
ksft_print_msg("ERROR: cannot write cpu.cfs_period_us at %s\n",
|
||||
period_path);
|
||||
return -1;
|
||||
}
|
||||
if (write_file(quota_path, quota) < 0) {
|
||||
ksft_print_msg("ERROR: cannot write cpu.cfs_quota_us at %s\n", quota_path);
|
||||
return -1;
|
||||
}
|
||||
ksft_print_msg("cgroup (v1) %s: cpu.cfs_quota_us=%d cpu.cfs_period_us=%d\n",
|
||||
g_cgroup_path, CFS_QUOTA_US, CFS_PERIOD_US);
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int cgroup_add_pid_to_path(pid_t pid, const char *path)
|
||||
{
|
||||
char buf[32], file_path[4096];
|
||||
|
||||
snprintf(buf, sizeof(buf), "%d", (int)pid);
|
||||
if (use_cgroup_v2) {
|
||||
snprintf(file_path, sizeof(file_path), "%s/cgroup.procs", path);
|
||||
return write_file(file_path, buf);
|
||||
}
|
||||
/* In v1, try tasks first, fallback to cgroup.procs */
|
||||
snprintf(file_path, sizeof(file_path), "%s/tasks", path);
|
||||
int r = write_file(file_path, buf);
|
||||
|
||||
if (r < 0) {
|
||||
snprintf(file_path, sizeof(file_path), "%s/cgroup.procs", path);
|
||||
r = write_file(file_path, buf);
|
||||
}
|
||||
return r;
|
||||
}
|
||||
|
||||
static void cgroup_teardown(void)
|
||||
{
|
||||
rm_cgroup_recursive(g_cgroup_path);
|
||||
}
|
||||
|
||||
static void cgroup_unthrottle(void)
|
||||
{
|
||||
if (use_cgroup_v2) {
|
||||
char max_path[4096];
|
||||
|
||||
snprintf(max_path, sizeof(max_path), "%s/cpu.max", g_cgroup_path);
|
||||
write_file(max_path, "max");
|
||||
} else {
|
||||
char quota_path[4096];
|
||||
|
||||
snprintf(quota_path, sizeof(quota_path), "%s/cpu.cfs_quota_us", g_cgroup_path);
|
||||
write_file(quota_path, "-1");
|
||||
}
|
||||
}
|
||||
|
||||
/* -- CPU burner (inside throttled child process) -- */
|
||||
static void *burner_thread_fn(void *arg)
|
||||
{
|
||||
struct rseq_abi my_rseq;
|
||||
int cpu = (int)(uintptr_t)arg;
|
||||
|
||||
memset(&my_rseq, 0, sizeof(my_rseq));
|
||||
my_rseq.cpu_id = RSEQ_CPU_ID_UNINITIALIZED;
|
||||
|
||||
if (rseq_register_thread_at(&my_rseq) < 0) {
|
||||
perror("rseq_register (burner)");
|
||||
return NULL;
|
||||
}
|
||||
|
||||
cpu_set_t set;
|
||||
|
||||
CPU_ZERO(&set);
|
||||
CPU_SET(cpu, &set);
|
||||
if (sched_setaffinity(0, sizeof(set), &set) < 0)
|
||||
perror("sched_setaffinity (burner)");
|
||||
|
||||
unsigned long sink = 0;
|
||||
|
||||
while (!atomic_load_explicit(&g_stop, memory_order_relaxed)) {
|
||||
sink++;
|
||||
/* Prevent compiler from optimizing the loop away */
|
||||
asm volatile("" : "+g"(sink));
|
||||
}
|
||||
|
||||
return NULL;
|
||||
}
|
||||
|
||||
static int burner_thread_fn_wrapper(void *arg)
|
||||
{
|
||||
burner_thread_fn(arg);
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int leaf_child_fn(void *arg)
|
||||
{
|
||||
int i = (int)(uintptr_t)arg;
|
||||
int total_burners = g_ncpus_stress * N_BURNER_PER_CPU;
|
||||
int n_threads_per_leaf = total_burners / N_SIBLINGS;
|
||||
|
||||
if (i < (total_burners % N_SIBLINGS))
|
||||
n_threads_per_leaf++;
|
||||
|
||||
prctl(PR_SET_PDEATHSIG, SIGTERM);
|
||||
if (getppid() == 1)
|
||||
_exit(1);
|
||||
|
||||
char leaf_path[4096];
|
||||
|
||||
snprintf(leaf_path, sizeof(leaf_path), "%s/n%d", g_cgroup_path, i);
|
||||
for (int j = 0; j < NEST_DEPTH; j++)
|
||||
snprintf(leaf_path + strlen(leaf_path),
|
||||
sizeof(leaf_path) - strlen(leaf_path), "/d%d", j);
|
||||
|
||||
int r = cgroup_add_pid_to_path(getpid(), leaf_path);
|
||||
|
||||
if (r < 0) {
|
||||
char buf[512];
|
||||
int len = snprintf(buf, sizeof(buf),
|
||||
"[leaf child %d] failed to join cgroup %s: err %d\n",
|
||||
i, leaf_path, -r);
|
||||
(void)!write(2, buf, len);
|
||||
_exit(1);
|
||||
}
|
||||
|
||||
for (int j = 0; j < n_threads_per_leaf; j++) {
|
||||
int cpu = g_stress_cpus[(i * n_threads_per_leaf + j) % g_ncpus_stress];
|
||||
|
||||
/* Allocate stack via mmap (bypasses heap) */
|
||||
size_t stack_size = 64 * 1024;
|
||||
void *stack = mmap(NULL, stack_size, PROT_READ | PROT_WRITE,
|
||||
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
|
||||
if (stack == MAP_FAILED) {
|
||||
const char *msg = "mmap stack failed\n";
|
||||
(void)!write(2, msg, strlen(msg));
|
||||
_exit(1);
|
||||
}
|
||||
|
||||
/* Use raw clone to create a thread sharing the VM and thread group */
|
||||
pid_t pid = clone(burner_thread_fn_wrapper, stack + stack_size,
|
||||
CLONE_VM | CLONE_THREAD | CLONE_SIGHAND,
|
||||
(void *)(uintptr_t)cpu);
|
||||
if (pid < 0) {
|
||||
const char *msg = "clone burner failed\n";
|
||||
(void)!write(2, msg, strlen(msg));
|
||||
_exit(1);
|
||||
}
|
||||
}
|
||||
|
||||
// Wait for SIGTERM
|
||||
sigset_t mask;
|
||||
|
||||
sigemptyset(&mask);
|
||||
sigaddset(&mask, SIGTERM);
|
||||
int sig;
|
||||
|
||||
sigwait(&mask, &sig);
|
||||
|
||||
_exit(0);
|
||||
}
|
||||
|
||||
struct leaf_info {
|
||||
pid_t pid;
|
||||
void *stack;
|
||||
};
|
||||
|
||||
static int run_throttle_child(void *arg)
|
||||
{
|
||||
(void)arg;
|
||||
prctl(PR_SET_PDEATHSIG, SIGTERM);
|
||||
if (getppid() == 1)
|
||||
_exit(1);
|
||||
|
||||
int n_leafs = N_SIBLINGS;
|
||||
|
||||
/* Block signals before spawning to avoid missing early failures */
|
||||
sigset_t mask;
|
||||
|
||||
sigemptyset(&mask);
|
||||
sigaddset(&mask, SIGTERM);
|
||||
sigaddset(&mask, SIGCHLD);
|
||||
sigprocmask(SIG_BLOCK, &mask, NULL);
|
||||
|
||||
/* Use mmap for tracking structures to avoid glibc heap usage */
|
||||
struct leaf_info *leaves = mmap(NULL, n_leafs * sizeof(struct leaf_info),
|
||||
PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
|
||||
if (leaves == MAP_FAILED) {
|
||||
const char *msg = "mmap leaves array failed\n";
|
||||
(void)!write(2, msg, strlen(msg));
|
||||
_exit(1);
|
||||
}
|
||||
|
||||
for (int i = 0; i < n_leafs; i++) {
|
||||
size_t stack_size = 64 * 1024;
|
||||
void *stack = mmap(NULL, stack_size, PROT_READ | PROT_WRITE,
|
||||
MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
|
||||
if (stack == MAP_FAILED) {
|
||||
const char *msg = "mmap leaf stack failed\n";
|
||||
(void)!write(2, msg, strlen(msg));
|
||||
_exit(1);
|
||||
}
|
||||
|
||||
leaves[i].stack = stack;
|
||||
|
||||
pid_t pid = clone(leaf_child_fn, stack + stack_size,
|
||||
CLONE_VM | SIGCHLD, (void *)(uintptr_t)i);
|
||||
|
||||
if (pid < 0) {
|
||||
const char *msg = "clone (leaf child) failed\n";
|
||||
(void)!write(2, msg, strlen(msg));
|
||||
|
||||
/* Clean up successfully spawned children */
|
||||
for (int j = 0; j < i; j++) {
|
||||
kill(leaves[j].pid, SIGTERM);
|
||||
waitpid(leaves[j].pid, NULL, 0);
|
||||
munmap(leaves[j].stack, stack_size);
|
||||
}
|
||||
munmap(leaves, n_leafs * sizeof(struct leaf_info));
|
||||
|
||||
if (errno == EAGAIN)
|
||||
_exit(4);
|
||||
else
|
||||
_exit(1);
|
||||
}
|
||||
leaves[i].pid = pid;
|
||||
}
|
||||
|
||||
int failed = 0;
|
||||
|
||||
while (1) {
|
||||
int sig;
|
||||
|
||||
sigwait(&mask, &sig);
|
||||
|
||||
if (sig == SIGTERM) {
|
||||
break;
|
||||
} else if (sig == SIGCHLD) {
|
||||
int status;
|
||||
pid_t pid;
|
||||
|
||||
// Reap all dead children
|
||||
while ((pid = waitpid(-1, &status, WNOHANG)) > 0) {
|
||||
for (int i = 0; i < n_leafs; i++) {
|
||||
if (leaves[i].pid == pid) {
|
||||
leaves[i].pid = 0;
|
||||
break;
|
||||
}
|
||||
}
|
||||
if ((WIFEXITED(status) && WEXITSTATUS(status) != 0) ||
|
||||
WIFSIGNALED(status)) {
|
||||
char buf[128];
|
||||
int len = snprintf(buf, sizeof(buf),
|
||||
"[manager] child %d died unexpectedly (status %d)\n",
|
||||
pid, WEXITSTATUS(status));
|
||||
(void)!write(2, buf, len);
|
||||
failed = 1;
|
||||
}
|
||||
}
|
||||
if (failed)
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
// Terminate all leaf kids
|
||||
for (int i = 0; i < n_leafs; i++) {
|
||||
if (leaves[i].pid > 0)
|
||||
kill(leaves[i].pid, SIGTERM);
|
||||
}
|
||||
|
||||
for (int i = 0; i < n_leafs; i++) {
|
||||
if (leaves[i].pid > 0)
|
||||
waitpid(leaves[i].pid, NULL, 0);
|
||||
munmap(leaves[i].stack, 64 * 1024);
|
||||
}
|
||||
|
||||
munmap(leaves, n_leafs * sizeof(struct leaf_info));
|
||||
|
||||
_exit(failed ? 1 : 0);
|
||||
}
|
||||
|
||||
/* -- Membarrier hammer thread -- */
|
||||
static void *hammer_thread_fn(void *arg)
|
||||
{
|
||||
int target_cpu = *(int *)arg;
|
||||
long local_ok = 0;
|
||||
long local_err = 0;
|
||||
int count = 0;
|
||||
const int batch_size = 1024;
|
||||
|
||||
if (rseq_register_thread() < 0) {
|
||||
ksft_print_msg("[hammer] rseq_register failed: %s\n", strerror(errno));
|
||||
return NULL;
|
||||
}
|
||||
|
||||
membarrier_register_rseq_mm();
|
||||
|
||||
while (!atomic_load_explicit(&g_stop, memory_order_relaxed)) {
|
||||
int r = syscall(SYS_membarrier,
|
||||
MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ,
|
||||
MEMBARRIER_CMD_FLAG_CPU,
|
||||
target_cpu);
|
||||
if (__builtin_expect(r == 0, 1))
|
||||
local_ok++;
|
||||
else
|
||||
local_err++;
|
||||
|
||||
count++;
|
||||
if (__builtin_expect(count >= batch_size, 0)) {
|
||||
atomic_fetch_add_explicit(&g_mb_ok, local_ok, memory_order_relaxed);
|
||||
atomic_fetch_add_explicit(&g_mb_err, local_err, memory_order_relaxed);
|
||||
local_ok = 0;
|
||||
local_err = 0;
|
||||
count = 0;
|
||||
}
|
||||
}
|
||||
|
||||
/* Flush any remaining counts on exit */
|
||||
if (local_ok > 0)
|
||||
atomic_fetch_add_explicit(&g_mb_ok, local_ok, memory_order_relaxed);
|
||||
if (local_err > 0)
|
||||
atomic_fetch_add_explicit(&g_mb_err, local_err, memory_order_relaxed);
|
||||
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* -- Latency sentinel -- */
|
||||
static void *sentinel_thread_fn(void *arg)
|
||||
{
|
||||
(void)arg;
|
||||
struct sched_param sp = { .sched_priority = 20 };
|
||||
|
||||
if (sched_setscheduler(0, SCHED_FIFO, &sp) < 0)
|
||||
ksft_print_msg("WARN: no SCHED_FIFO for sentinel (less precise)\n");
|
||||
|
||||
while (!atomic_load_explicit(&g_test_ready, memory_order_relaxed) &&
|
||||
!atomic_load_explicit(&g_stop_sentinel, memory_order_relaxed)) {
|
||||
struct timespec ts = {0, 1000 * 1000}; /* 1ms */
|
||||
|
||||
clock_nanosleep(CLOCK_MONOTONIC, 0, &ts, NULL);
|
||||
}
|
||||
|
||||
uint64_t prev = monotonic_us();
|
||||
|
||||
while (!atomic_load_explicit(&g_stop_sentinel, memory_order_relaxed)) {
|
||||
struct timespec ts = {
|
||||
.tv_sec = 0,
|
||||
.tv_nsec = SENTINEL_INTERVAL_US * 1000L,
|
||||
};
|
||||
clock_nanosleep(CLOCK_MONOTONIC, 0, &ts, NULL);
|
||||
|
||||
uint64_t now = monotonic_us();
|
||||
long latency_us = (long)(now - prev) - SENTINEL_INTERVAL_US;
|
||||
|
||||
prev = now;
|
||||
|
||||
if (latency_us <= 0)
|
||||
continue;
|
||||
|
||||
update_max_latency(latency_us);
|
||||
|
||||
if (latency_us > LATENCY_CRITICAL_MS * 1000L) {
|
||||
ksft_print_msg("\n[SENTINEL] CRITICAL: %ld ms delay (lockup precursor!)\n",
|
||||
latency_us / 1000);
|
||||
} else if (latency_us > LATENCY_WARN_MS * 1000L) {
|
||||
ksft_print_msg("\n[SENTINEL] WARN: %ld ms latency spike\n",
|
||||
latency_us / 1000);
|
||||
}
|
||||
}
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* -- Progress reporter -- */
|
||||
static void *reporter_thread_fn(void *arg)
|
||||
{
|
||||
(void)arg;
|
||||
int elapsed = 0;
|
||||
|
||||
while (!atomic_load_explicit(&g_stop_sentinel, memory_order_relaxed)) {
|
||||
for (int i = 0; i < 5; i++) {
|
||||
sleep(1);
|
||||
if (atomic_load_explicit(&g_stop_sentinel, memory_order_relaxed))
|
||||
break;
|
||||
}
|
||||
if (atomic_load_explicit(&g_stop_sentinel, memory_order_relaxed))
|
||||
break;
|
||||
elapsed += 5;
|
||||
long interval_max = atomic_exchange_explicit(&g_interval_max_latency_us,
|
||||
0, memory_order_relaxed);
|
||||
|
||||
ksft_print_msg("[%3ds] mb: ok=%-10ld err=%-8ld | max_lat=%ld us\n",
|
||||
elapsed,
|
||||
atomic_load(&g_mb_ok),
|
||||
atomic_load(&g_mb_err),
|
||||
interval_max);
|
||||
}
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/* -- Main -- */
|
||||
int main(void)
|
||||
{
|
||||
ksft_print_header();
|
||||
#ifdef UNSUPPORTED_ARCH
|
||||
ksft_exit_skip("Unsupported architecture\n");
|
||||
#endif
|
||||
ksft_set_plan(1);
|
||||
|
||||
if (geteuid() != 0)
|
||||
ksft_exit_skip("Must run as root (cgroup + SCHED_FIFO)\n");
|
||||
|
||||
init_stress_cpus();
|
||||
|
||||
ksft_print_msg("=== membarrier rseq + CFS unthrottle stress ===\n");
|
||||
ksft_print_msg("Stressing CPUs: %d\n", g_ncpus_stress);
|
||||
ksft_print_msg("Quota: %d/%d us (~%d unthrottles/sec/CPU)\n",
|
||||
CFS_QUOTA_US, CFS_PERIOD_US,
|
||||
1000000 / CFS_PERIOD_US);
|
||||
ksft_print_msg("Hammer threads: %d per CPU (%d total)\n",
|
||||
N_HAMMER_PER_CPU, g_ncpus_stress * N_HAMMER_PER_CPU);
|
||||
ksft_print_msg("Duration: %d seconds\n\n", TEST_DURATION_SEC);
|
||||
|
||||
if (cgroup_setup() < 0) {
|
||||
cgroup_teardown();
|
||||
ksft_exit_skip("cgroup_setup failed (missing permissions or v2 ctrls?)\n");
|
||||
}
|
||||
|
||||
if (rseq_register_thread() < 0) {
|
||||
ksft_print_msg("rseq_register (%s) failed: %s\n", __func__, strerror(errno));
|
||||
cgroup_teardown();
|
||||
ksft_exit_skip("rseq syscall failed or not available\n");
|
||||
}
|
||||
if (membarrier_register_rseq_mm() < 0) {
|
||||
ksft_print_msg("MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ: %s\n"
|
||||
"Kernel >= 5.10 with CONFIG_RSEQ required.\n",
|
||||
strerror(errno));
|
||||
cgroup_teardown();
|
||||
ksft_exit_skip("membarrier register failed\n");
|
||||
}
|
||||
ksft_print_msg("rseq membarrier registered OK\n");
|
||||
|
||||
sigset_t sigmask;
|
||||
|
||||
sigemptyset(&sigmask);
|
||||
sigaddset(&sigmask, SIGTERM);
|
||||
sigprocmask(SIG_BLOCK, &sigmask, NULL);
|
||||
|
||||
void *stack = malloc(1024 * 1024);
|
||||
|
||||
if (!stack) {
|
||||
perror("malloc stack");
|
||||
cgroup_teardown();
|
||||
ksft_exit_fail_msg("Malloc stack failed\n");
|
||||
}
|
||||
pid_t child = clone(run_throttle_child, stack + 1024 * 1024, CLONE_VM | SIGCHLD, NULL);
|
||||
|
||||
if (child < 0) {
|
||||
perror("clone");
|
||||
cgroup_teardown();
|
||||
ksft_exit_fail_msg("Clone failed\n");
|
||||
}
|
||||
|
||||
sigprocmask(SIG_UNBLOCK, &sigmask, NULL);
|
||||
ksft_print_msg("Throttle child PID %d started\n", child);
|
||||
|
||||
int n_threads = g_ncpus_stress * N_HAMMER_PER_CPU + 2;
|
||||
pthread_t *threads = (pthread_t *)calloc(n_threads, sizeof(pthread_t));
|
||||
int *cpuargs = (int *)calloc(g_ncpus_stress * N_HAMMER_PER_CPU, sizeof(int));
|
||||
|
||||
if (!threads || !cpuargs) {
|
||||
perror("calloc");
|
||||
kill(child, SIGTERM);
|
||||
waitpid(child, NULL, 0);
|
||||
cgroup_teardown();
|
||||
ksft_exit_fail_msg("Thread allocation failed\n");
|
||||
}
|
||||
|
||||
int ti = 0, ai = 0;
|
||||
int r;
|
||||
|
||||
ksft_print_msg("Creating sentinel thread...\n");
|
||||
r = pthread_create(&threads[ti], NULL, sentinel_thread_fn, NULL);
|
||||
if (r != 0) {
|
||||
kill(child, SIGTERM);
|
||||
waitpid(child, NULL, 0);
|
||||
cgroup_teardown();
|
||||
free(threads);
|
||||
free(cpuargs);
|
||||
free(g_stress_cpus);
|
||||
ksft_exit_fail_msg("pthread_create (sentinel) failed: %s\n", strerror(r));
|
||||
}
|
||||
ti++;
|
||||
|
||||
ksft_print_msg("Creating reporter thread...\n");
|
||||
r = pthread_create(&threads[ti], NULL, reporter_thread_fn, NULL);
|
||||
if (r != 0) {
|
||||
atomic_store(&g_stop_sentinel, 1);
|
||||
pthread_join(threads[0], NULL);
|
||||
kill(child, SIGTERM);
|
||||
waitpid(child, NULL, 0);
|
||||
cgroup_teardown();
|
||||
free(threads);
|
||||
free(cpuargs);
|
||||
free(g_stress_cpus);
|
||||
ksft_exit_fail_msg("pthread_create (reporter) failed: %s\n", strerror(r));
|
||||
}
|
||||
ti++;
|
||||
|
||||
ksft_print_msg("Creating %d hammer threads...\n", g_ncpus_stress * N_HAMMER_PER_CPU);
|
||||
for (int i = 0; i < g_ncpus_stress; i++) {
|
||||
int cpu = g_stress_cpus[i];
|
||||
|
||||
for (int j = 0; j < N_HAMMER_PER_CPU; j++) {
|
||||
cpuargs[ai] = cpu;
|
||||
r = pthread_create(&threads[ti], NULL, hammer_thread_fn, &cpuargs[ai]);
|
||||
if (r != 0) {
|
||||
ksft_print_msg("pthread_create failed at thread %d: %s\n",
|
||||
ti, strerror(r));
|
||||
|
||||
atomic_store(&g_stop_sentinel, 1);
|
||||
pthread_join(threads[0], NULL);
|
||||
pthread_join(threads[1], NULL);
|
||||
|
||||
atomic_store(&g_stop, 1);
|
||||
for (int k = 2; k < ti; k++)
|
||||
pthread_join(threads[k], NULL);
|
||||
|
||||
kill(child, SIGTERM);
|
||||
waitpid(child, NULL, 0);
|
||||
cgroup_teardown();
|
||||
|
||||
free(threads);
|
||||
free(cpuargs);
|
||||
free(g_stress_cpus);
|
||||
|
||||
if (r == EAGAIN)
|
||||
ksft_exit_skip("Resource limits prevent threads\n");
|
||||
else
|
||||
ksft_exit_fail_msg("Failed to create hammer thread\n");
|
||||
}
|
||||
ti++;
|
||||
ai++;
|
||||
}
|
||||
}
|
||||
|
||||
ksft_print_msg("All threads running. Tip: monitor dmesg for lockups\n\n");
|
||||
|
||||
atomic_store_explicit(&g_test_ready, 1, memory_order_relaxed);
|
||||
int child_failed = 0;
|
||||
int child_status = 0;
|
||||
|
||||
for (int i = 0; i < TEST_DURATION_SEC; i++) {
|
||||
sleep(1);
|
||||
int r = waitpid(child, &child_status, WNOHANG);
|
||||
|
||||
if (r == child) {
|
||||
child_failed = 1;
|
||||
break;
|
||||
}
|
||||
}
|
||||
|
||||
atomic_store(&g_stop_sentinel, 1);
|
||||
pthread_join(threads[0], NULL);
|
||||
pthread_join(threads[1], NULL);
|
||||
|
||||
atomic_store(&g_stop, 1);
|
||||
|
||||
/* Unthrottle to allow children to exit quickly */
|
||||
cgroup_unthrottle();
|
||||
|
||||
if (!child_failed) {
|
||||
kill(child, SIGTERM);
|
||||
waitpid(child, NULL, 0);
|
||||
}
|
||||
for (int i = 2; i < ti; i++)
|
||||
pthread_join(threads[i], NULL);
|
||||
|
||||
long max_lat = atomic_load(&g_max_latency_us);
|
||||
long total_ok = atomic_load(&g_mb_ok);
|
||||
long total_err = atomic_load(&g_mb_err);
|
||||
|
||||
ksft_print_msg("\n=== RESULTS ===\n");
|
||||
ksft_print_msg("membarrier syscalls : %ld ok %ld errors\n", total_ok, total_err);
|
||||
ksft_print_msg("Max scheduler latency: %ld us (%ld ms)\n", max_lat, max_lat / 1000);
|
||||
cgroup_teardown();
|
||||
free(threads);
|
||||
free(cpuargs);
|
||||
free(g_stress_cpus);
|
||||
|
||||
if (child_failed) {
|
||||
if (WIFEXITED(child_status) && WEXITSTATUS(child_status) == 4)
|
||||
ksft_exit_skip("Manager child skipped (resource limits?)\n");
|
||||
ksft_test_result_fail("membarrier_rseq_stress: Manager child died early\n");
|
||||
ksft_exit_fail();
|
||||
} else if (total_ok == 0) {
|
||||
ksft_test_result_fail("membarrier_rseq_stress: No successful membarrier calls\n");
|
||||
ksft_exit_fail();
|
||||
} else if (total_err > 0) {
|
||||
ksft_test_result_fail("membarrier_rseq_stress: syscall errors\n");
|
||||
ksft_exit_fail();
|
||||
} else if (max_lat > LATENCY_CRITICAL_MS * 1000L) {
|
||||
ksft_test_result_fail("membarrier_rseq_stress: LOCKUP PRECURSOR\n");
|
||||
ksft_exit_fail();
|
||||
} else if (max_lat > LATENCY_WARN_MS * 1000L) {
|
||||
ksft_test_result_fail("membarrier_rseq_stress: significant latency spike\n");
|
||||
ksft_exit_fail();
|
||||
} else {
|
||||
ksft_test_result_pass("membarrier_rseq_stress\n");
|
||||
ksft_exit_pass();
|
||||
}
|
||||
|
||||
return 0;
|
||||
}
|
||||
Loading…
Reference in New Issue
Block a user