github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

coresight: cti: Add const to con_groups allocation type

Browse Source 
In preparation for making the devm_kmalloc family of allocators type
aware, we need to make sure that the returned type from the allocation
matches the type of the variable being assigned. (Before, the allocator
would always return "void *", which can be implicitly cast to any
pointer type.)

The assigned type is "const struct attribute_group **", but the
converted allocation type would be "struct attribute_group **", which is
the same type without the const qualifier. As there is no general way to
safely add const qualifiers, take the size from the assignment target
instead. No change in allocation size results.

Build tested ARCH=arm64 allmodconfig with GCC aarch64-linux-gnu 16.1.0:
drivers/hwtracing/coresight/coresight-cti-sysfs.o

Assisted-by: LLM coccinelle
Reviewed-by: Mike Leach <mike.leach@arm.com>
Reviewed-by: Leo Yan <leo.yan@arm.com>
Link: https://patch.msgid.link/20260917211428.i.947-kees@kernel.org
Signed-off-by: Kees Cook <kees+treewide@kernel.org>
This commit is contained in:
Kees Cook 2026-09-17 14:14:29 -07:00 committed by Kees Cook
parent e3f8dfafd7
commit 752ae52dcc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hwtracing/coresight/coresight-cti-sysfs.c
View File

@ -1132,7 +1132,7 @@ static int cti_create_cons_groups(struct device *dev, struct cti_device *ctidev)
/* nr groups = dynamic + static + NULL terminator */
nr_groups = ctidev->nr_trig_con + CORESIGHT_CTI_STATIC_GROUPS_MAX;
ctidev->con_groups = devm_kcalloc(dev, nr_groups,
sizeof(struct attribute_group *),
sizeof(*ctidev->con_groups),
GFP_KERNEL);
if (!ctidev->con_groups)
return -ENOMEM;