github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-24 06:24:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: light: tsl2583: remove tsl2583_set_pm_runtime_busy() helper

Browse Source 
tsl2583_set_pm_runtime_busy() just calls pm_runtime_resume_and_get()
or pm_runtime_put_autosuspend() depending on its bool argument. Call
them directly and remove the helper.

No functional change.

Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Signed-off-by: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
This commit is contained in:
Sang-Heon Jeon 2026-07-28 03:47:41 +09:00 committed by Jonathan Cameron
parent 7f61f41a3f
commit 75056737b6
1 changed files with 7 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/iio/light/tsl2583.c
View File

@ -639,14 +639,6 @@ static const struct iio_chan_spec tsl2583_channels[] = {
},
};
static int tsl2583_set_pm_runtime_busy(struct tsl2583_chip *chip, bool on)
{
if (on)
return pm_runtime_resume_and_get(&chip->client->dev);
return pm_runtime_put_autosuspend(&chip->client->dev);
}
static int tsl2583_read_raw(struct iio_dev *indio_dev,
struct iio_chan_spec const *chan,
int *val, int *val2, long mask)
@ -654,7 +646,7 @@ static int tsl2583_read_raw(struct iio_dev *indio_dev,
struct tsl2583_chip *chip = iio_priv(indio_dev);
int ret, pm_ret;
ret = tsl2583_set_pm_runtime_busy(chip, true);
ret = pm_runtime_resume_and_get(&chip->client->dev);
if (ret < 0)
return ret;
@ -722,16 +714,16 @@ static int tsl2583_read_raw(struct iio_dev *indio_dev,
mutex_unlock(&chip->als_mutex);
if (ret < 0) {
tsl2583_set_pm_runtime_busy(chip, false);
pm_runtime_put_autosuspend(&chip->client->dev);
return ret;
}
/*
* Preserve the ret variable if the call to
* tsl2583_set_pm_runtime_busy() is successful so the reading
* pm_runtime_put_autosuspend() is successful so the reading
* (if applicable) is returned to user space.
*/
pm_ret = tsl2583_set_pm_runtime_busy(chip, false);
pm_ret = pm_runtime_put_autosuspend(&chip->client->dev);
if (pm_ret < 0)
return pm_ret;
@ -745,7 +737,7 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev,
struct tsl2583_chip *chip = iio_priv(indio_dev);
int ret;
ret = tsl2583_set_pm_runtime_busy(chip, true);
ret = pm_runtime_resume_and_get(&chip->client->dev);
if (ret < 0)
return ret;
@ -786,11 +778,11 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev,
mutex_unlock(&chip->als_mutex);
if (ret < 0) {
tsl2583_set_pm_runtime_busy(chip, false);
pm_runtime_put_autosuspend(&chip->client->dev);
return ret;
}
ret = tsl2583_set_pm_runtime_busy(chip, false);
ret = pm_runtime_put_autosuspend(&chip->client->dev);
if (ret < 0)
return ret;