From 73a2f91bc2f6bd329d9c55d351809a139393307a Mon Sep 17 00:00:00 2001 From: Troy Mitchell Date: Fri, 8 May 2026 15:25:25 +0800 Subject: [PATCH] i2c: spacemit: drop warning when clock-frequency property is absent The clock-frequency property is optional according to the DT binding. Do not emit a warning when the property is missing and fall back to the default frequency instead. Reviewed-by: Alex Elder Signed-off-by: Troy Mitchell Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260508-k1-i2c-ilcr-v7-2-8c2dde5c3ed5@linux.spacemit.com --- drivers/i2c/busses/i2c-k1.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c index c6fe2052e479..7cf5c05a20d2 100644 --- a/drivers/i2c/busses/i2c-k1.c +++ b/drivers/i2c/busses/i2c-k1.c @@ -833,9 +833,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev) if (!i2c) return -ENOMEM; - ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); - if (ret && ret != -EINVAL) - dev_warn(dev, "failed to read clock-frequency property: %d\n", ret); + of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); /* For now, this driver doesn't support high-speed. */ if (i2c->clock_freq > SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ && @@ -844,7 +842,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev) } else if (i2c->clock_freq && i2c->clock_freq <= SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ) { i2c->mode = SPACEMIT_MODE_STANDARD; } else { - dev_warn(i2c->dev, "invalid clock-frequency, fallback to fast mode"); + dev_info(dev, "clock-frequency not set or out of range, using fast mode\n"); i2c->mode = SPACEMIT_MODE_FAST; i2c->clock_freq = SPACEMIT_I2C_MAX_FAST_MODE_FREQ; }