From 682d3772be807d1269fc0df071b93e86374f1d18 Mon Sep 17 00:00:00 2001 From: Alison Schofield Date: Thu, 3 Sep 2026 16:23:44 -0700 Subject: [PATCH] cxl/region: Warn on user region position mismatch User region creation includes a self-test that checks the assigned endpoint positions against the position calculation used by auto region creation. The result, matching or not, is reported with dev_dbg(). Promote that to a dev_warn() that fires only on a mismatch, so bugs in the auto region position calculation are easier to catch as that calculation is extended to support more region configurations. The matching case no longer prints, so dynamic debug on region.c no longer confirms that the self-test ran. Signed-off-by: Alison Schofield Reviewed-by: Jonathan Cameron Reviewed-by: Robert Richter Link: https://patch.msgid.link/1d662e3ea78ec8b05fceb500f04e69ee9f6d4a72.1788475206.git.alison.schofield@intel.com Signed-off-by: Dave Jiang --- drivers/cxl/core/region.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index 4f6069451fed..0f6a32e83601 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -2216,10 +2216,11 @@ static int cxl_region_attach(struct cxl_region *cxlr, int test_pos; test_pos = cxl_calc_interleave_pos(target, &cxlr->hpa_range); - dev_dbg(&target->cxld.dev, - "Test cxl_calc_interleave_pos(): %s test_pos:%d target->pos:%d\n", - (test_pos == target->pos) ? "success" : "fail", - test_pos, target->pos); + if (test_pos != target->pos) + dev_warn(&cxlr->dev, + "%s: position mismatch: calculated:%d assigned:%d\n", + dev_name(&target->cxld.dev), test_pos, + target->pos); } return 0;