mirror of
https://github.com/torvalds/linux.git
synced 2026-11-07 06:17:02 +01:00
fuse: fix GCC 8 build with CONFIG_PROFILE_ALL_BRANCHES
Commit25307ca50b("fuse: simplify logic in fuse_notify_store() and fuse_retrieve()") introduced a loff_t cursor and used it in place of outarg's offset field. In the min() expression this changed the second operand from unsigned to signed. With CONFIG_PROFILE_ALL_BRANCHES, GCC 8 does not propagate the range established by the preceding MAX_LFS_FILESIZE check through the branch profiling code. Consequently, min() cannot prove that the signed operand is nonnegative and rejects the mixed-signedness comparison: min(outarg.size, ((loff_t)((long long)(~0ULL >> 1))) - pos) signedness error This happens with GCC 8.1 on x86-64 and GCC 8.5 on arm and s390. GCC 8.1 remains the minimum supported compiler. Use umin(), which is intended for comparing an unsigned value with a signed value that is known to be nonnegative. The preceding bounds check guarantees that MAX_LFS_FILESIZE - pos is nonnegative, and outarg.size bounds the result to unsigned int. Fixes:25307ca50b("fuse: simplify logic in fuse_notify_store() and fuse_retrieve()") Cc: stable@vger.kernel.org # v7.1 Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
This commit is contained in:
parent
ab38882862
commit
6e887377a6
|
|
@ -155,7 +155,7 @@ static int fuse_notify_store(struct fuse_conn *fc, unsigned int size,
|
|||
|
||||
nodeid = outarg.nodeid;
|
||||
pos = outarg.offset;
|
||||
num = min(outarg.size, MAX_LFS_FILESIZE - pos);
|
||||
num = umin(outarg.size, MAX_LFS_FILESIZE - pos);
|
||||
|
||||
down_read(&fc->killsb);
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user