From 6dda9ad3149fe1e3704542767409cb8d92c18e8c Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Mon, 20 Jul 2026 14:37:37 +0800 Subject: [PATCH] hwmon: (lm90) Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_threaded_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Link: https://lore.kernel.org/r/20260720063745.309331-4-panchuang@vivo.com Signed-off-by: Guenter Roeck --- drivers/hwmon/lm90.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hwmon/lm90.c b/drivers/hwmon/lm90.c index c6186505661f..ae3b0a33d676 100644 --- a/drivers/hwmon/lm90.c +++ b/drivers/hwmon/lm90.c @@ -2918,10 +2918,8 @@ static int lm90_probe(struct i2c_client *client) err = devm_request_threaded_irq(dev, client->irq, NULL, lm90_irq_thread, IRQF_ONESHOT, "lm90", client); - if (err < 0) { - dev_err(dev, "cannot request IRQ %d\n", client->irq); + if (err < 0) return err; - } } return 0;