From 6d5c4deea04580a08ad1ed3a13c11fac0dbefa7b Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Thu, 9 Jul 2026 11:33:51 +0800 Subject: [PATCH] power: supply: bq24190_charger: Remove redundant dev_err()/dev_err_probe() The devm_request_threaded_irq() and devm_request_irq() now automatically log detailed error messages on failure. This eliminates the need for driver-specific dev_err() and dev_err_probe() calls that previously printed generic messages. Signed-off-by: Pan Chuang Link: https://patch.msgid.link/20260709033428.362970-13-panchuang@vivo.com Signed-off-by: Sebastian Reichel --- drivers/power/supply/bq24190_charger.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/supply/bq24190_charger.c b/drivers/power/supply/bq24190_charger.c index 6700d578a98f..2a1ea83898ae 100644 --- a/drivers/power/supply/bq24190_charger.c +++ b/drivers/power/supply/bq24190_charger.c @@ -2170,10 +2170,8 @@ static int bq24190_probe(struct i2c_client *client) bq24190_irq_handler_thread, IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "bq24190-charger", bdi); - if (ret < 0) { - dev_err(dev, "Can't set up irq handler\n"); + if (ret < 0) goto out_charger; - } ret = bq24190_register_vbus_regulator(bdi); if (ret < 0)