mirror of
https://github.com/torvalds/linux.git
synced 2026-11-06 21:58:01 +01:00
platform: arm64: drop the vacuous THERMAL dependency from EC_ASUS_GLYMUR
'depends on THERMAL || THERMAL=n' is always true and is semantically a no-op, but it couples NEW_LEDS, which is selected here, to THERMAL and closes a Kconfig dependency loop. The C tools stay silent because they fold the always-true expression to 'y' before running dependency loop detection; kconfiglib, used by the Yocto kernel config audit, does not fold and rejects the config at parse time. The loop is easy to expose with the in-tree tools, using the technique from commitb33a654a5b("drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER"), https://git.kernel.org/linus/b33a654a5bd6: temporarily make THERMAL tristate so the folding stops, then any config target reports it: $ sed -i 's/bool "Thermal drivers"/tristate "Thermal drivers"/' \ drivers/thermal/Kconfig $ make allnoconfig error: recursive dependency detected! symbol POWER_SUPPLY is selected by HID_ASUS symbol HID_ASUS depends on LEDS_CLASS symbol LEDS_CLASS depends on NEW_LEDS symbol NEW_LEDS is selected by EC_ASUS_GLYMUR symbol EC_ASUS_GLYMUR depends on THERMAL symbol THERMAL is selected by AB8500_BM symbol AB8500_BM depends on POWER_SUPPLY Drop the vacuous line to break the loop; the driver still builds both with and without THERMAL. Fixes:db3a9dddab("platform: arm64: Add a driver for the EC found on ASUS Glymur machines") Signed-off-by: Haiyue Wang <haiyuewa@163.com> Assisted-by: LLM Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Link: https://patch.msgid.link/20261029021330.460192-1-haiyuewa@163.com Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
This commit is contained in:
parent
c339f4010d
commit
6cea839b2d
|
|
@ -40,7 +40,6 @@ config EC_ASUS_GLYMUR
|
|||
depends on HWMON
|
||||
depends on INPUT
|
||||
depends on PM
|
||||
depends on THERMAL || THERMAL=n
|
||||
select NEW_LEDS
|
||||
select LEDS_CLASS
|
||||
help
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user