github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 14:04:54 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

usb: gadget: eem: fix wrong eem header operation

Browse Source 
commit 305f670846 upstream.

when skb_clone() or skb_copy_expand() fail,
it should pull skb with lengh indicated by header,
or not it will read network data and check it as header.

Cc: <stable@vger.kernel.org>
Signed-off-by: Linyu Yuan <linyyuan@codeaurora.com>
Link: https://lore.kernel.org/r/20210608233547.3767-1-linyyuan@codeaurora.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Linyu Yuan 2021-06-09 07:35:47 +08:00 committed by Greg Kroah-Hartman
parent 21bee94fb9
commit 6bf8ff7d05
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/gadget/function/f_eem.c
View File

@ -495,7 +495,7 @@ static int eem_unwrap(struct gether *port,
skb2 = skb_clone(skb, GFP_ATOMIC); skb2 = skb_clone(skb, GFP_ATOMIC);
if (unlikely(!skb2)) { if (unlikely(!skb2)) {
DBG(cdev, "unable to unframe EEM packet\n"); DBG(cdev, "unable to unframe EEM packet\n");
continue; goto next;
} }
skb_trim(skb2, len - ETH_FCS_LEN); skb_trim(skb2, len - ETH_FCS_LEN);
@ -505,7 +505,7 @@ static int eem_unwrap(struct gether *port,
GFP_ATOMIC); GFP_ATOMIC);
if (unlikely(!skb3)) { if (unlikely(!skb3)) {
dev_kfree_skb_any(skb2); dev_kfree_skb_any(skb2);
continue; goto next;
} }
dev_kfree_skb_any(skb2); dev_kfree_skb_any(skb2);
skb_queue_tail(list, skb3); skb_queue_tail(list, skb3);