github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-06 21:58:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ASoC: audio-graph-card: Free jack GPIOs on card remove

Browse Source 
graph_util_card_probe() sets up the headphone and microphone jacks,
which takes a reference on the jack detection GPIO and registers an IRQ,
a PM notifier, a delayed work and a sysfs export for it. audio-graph-card
has no card->remove() callback, so none of this is released when the card
is torn down.

This goes unnoticed while the card is only torn down together with its
platform device, because the devres cleanup registered by
snd_soc_jack_add_gpios() is tied to that platform device. It becomes a
problem once the card alone is unregistered and registered again while
the platform device stays bound - for example when a codec component is
unbound and bound again. card->probe() then runs a second time and
gpiod_get_optional() fails with -EBUSY, because the descriptor is still
held by the previous bind. The card is not registered again and audio
stays broken until the platform device itself is unbound.

Add graph_util_card_remove() as the counterpart of
graph_util_card_probe() and hook it to card->remove. It lives in
simple-card-utils.c so that audio-graph-card2 can use it as well.

Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://patch.msgid.link/20260913102502.2805912-4-chancel.liu@oss.nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Chancel Liu 2026-09-13 19:25:01 +09:00 committed by Mark Brown
parent b59a208087
commit 698fdd3152
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
3 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/sound/simple_card_utils.h
View File

@ -226,6 +226,7 @@ int simple_util_init_priv(struct simple_util_priv *priv,
void simple_util_remove(struct platform_device *pdev);
int graph_util_card_probe(struct snd_soc_card *card);
int graph_util_card_remove(struct snd_soc_card *card);
int graph_util_is_ports0(struct device_node *port);
int graph_util_parse_dai(struct simple_util_priv *priv, struct device_node *ep,
struct snd_soc_dai_link_component *dlc, int *is_single_link);

1
sound/soc/generic/audio-graph-card.c
View File

@ -629,6 +629,7 @@ static int graph_probe(struct platform_device *pdev)
card->dapm_widgets = graph_dapm_widgets;
card->num_dapm_widgets = ARRAY_SIZE(graph_dapm_widgets);
card->probe = graph_util_card_probe;
card->remove = graph_util_card_remove;
if (of_device_get_match_data(dev))
priv->dpcm_selectable = 1;

11
sound/soc/generic/simple-card-utils.c
View File

@ -1028,6 +1028,17 @@ int graph_util_card_probe(struct snd_soc_card *card)
}
EXPORT_SYMBOL_GPL(graph_util_card_probe);
int graph_util_card_remove(struct snd_soc_card *card)
{
struct simple_util_priv *priv = snd_soc_card_get_drvdata(card);
simple_util_remove_jack(&priv->hp_jack);
simple_util_remove_jack(&priv->mic_jack);
return 0;
}
EXPORT_SYMBOL_GPL(graph_util_card_remove);
int graph_util_is_ports0(struct device_node *np)
{
struct device_node *parent __free(device_node) = of_get_parent(np);