From 68dab5c14aaff17686df22ba1f1eea3b3433797a Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Sun, 20 Sep 2026 12:37:05 +0200 Subject: [PATCH] md: fix mddev_unlock() called without holding lock in lbs_store() lbs_store() jumped to the unlock label on mddev_lock() failure, calling mddev_unlock() on a mutex that was never acquired. Return directly instead. Fixes: 62ed1b582246 ("md: allow configuring logical block size") Signed-off-by: Jack Wang Link: https://patch.msgid.link/20260920103705.23191-1-jinpu.wang@ionos.com Signed-off-by: Yu Kuai --- drivers/md/md.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 154ee5a65cb7..1ae310e7fca5 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -6048,11 +6048,10 @@ lbs_store(struct mddev *mddev, const char *buf, size_t len) err = mddev_lock(mddev); if (err) - goto unlock; + return err; err = mddev_set_logical_block_size(mddev, lbs); -unlock: mddev_unlock(mddev); return err ?: len; }