github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-21 13:27:57 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: light: bh1745: Stop using iio_device_claim_direct_scoped()

Browse Source 
This complex cleanup.h use case of conditional guards has proved
to be more trouble that it is worth in terms of false positive compiler
warnings and hard to read code.

Move directly to the new claim/release_direct() that allow sparse
to check for unbalanced context.

Reviewed-by: Mudit Sharma <muditsharma.info@gmail.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250209180624.701140-27-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Jonathan Cameron 2025-02-09 18:06:23 +00:00
parent 0bee1bf85a
commit 668d7167fc
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/iio/light/bh1745.c
View File

@ -426,16 +426,16 @@ static int bh1745_read_raw(struct iio_dev *indio_dev,
switch (mask) {
case IIO_CHAN_INFO_RAW:
iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {
ret = regmap_bulk_read(data->regmap, chan->address,
&value, 2);
if (ret)
return ret;
*val = value;
if (!iio_device_claim_direct(indio_dev))
return -EBUSY;
return IIO_VAL_INT;
}
unreachable();
ret = regmap_bulk_read(data->regmap, chan->address, &value, 2);
iio_device_release_direct(indio_dev);
if (ret)
return ret;
*val = value;
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE: {
guard(mutex)(&data->lock);