github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 21:45:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

NFSD: prevent underflow in nfssvc_decode_writeargs()

Browse Source 
commit 184416d4b9 upstream.

Smatch complains:

	fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs()
	warn: no lower bound on 'args->len'

Change the type to unsigned to prevent this issue.

Cc: stable@vger.kernel.org
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter 2022-03-15 13:30:09 +03:00 committed by Greg Kroah-Hartman
parent b7b430104a
commit 65e21cc042
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/nfsd/nfsproc.c
View File

@ -223,7 +223,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)
unsigned long cnt = argp->len; unsigned long cnt = argp->len;
unsigned int nvecs; unsigned int nvecs;
dprintk("nfsd: WRITE %s %d bytes at %d\n", dprintk("nfsd: WRITE %s %u bytes at %d\n",
SVCFH_fmt(&argp->fh), SVCFH_fmt(&argp->fh),
argp->len, argp->offset); argp->len, argp->offset);

2
fs/nfsd/xdr.h
View File

@ -33,7 +33,7 @@ struct nfsd_readargs {
struct nfsd_writeargs { struct nfsd_writeargs {
svc_fh fh; svc_fh fh;
__u32 offset; __u32 offset;
int len; __u32 len;
struct kvec first; struct kvec first;
}; };