From 8a5d6c13cc7cf7f7f096094c5015c82b2fb36131 Mon Sep 17 00:00:00 2001 From: "Pawel Zalewski (The Capable Hub)" Date: Tue, 4 Aug 2026 12:17:45 +0100 Subject: [PATCH 1/3] cache: hisi_soc_hha: use named initializers for acpi_device_id Use a named initializer for the acpi_device_id fields which makes the code more readable and consistent with how lists are initialized in the rest of the kernel code base. Signed-off-by: Pawel Zalewski (The Capable Hub) Reviewed-by: Yushan Wang Acked-by: Jonathan Cameron Signed-off-by: Conor Dooley --- drivers/cache/hisi_soc_hha.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cache/hisi_soc_hha.c b/drivers/cache/hisi_soc_hha.c index 25ff0f5ae79b..939f42148a6f 100644 --- a/drivers/cache/hisi_soc_hha.c +++ b/drivers/cache/hisi_soc_hha.c @@ -171,7 +171,7 @@ static void hisi_soc_hha_remove(struct platform_device *pdev) } static const struct acpi_device_id hisi_soc_hha_ids[] = { - { "HISI0511", }, + { .id = "HISI0511" }, { } }; MODULE_DEVICE_TABLE(acpi, hisi_soc_hha_ids); From 75effa447550c6eeb1198942e6b55dabeeb2dc64 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Mon, 13 Jul 2026 19:29:46 +0800 Subject: [PATCH 2/3] cache: sifive_ccache: Remove redundant dev_err_probe() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() calls. Signed-off-by: Pan Chuang Signed-off-by: Conor Dooley --- drivers/cache/sifive_ccache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cache/sifive_ccache.c b/drivers/cache/sifive_ccache.c index 2acb8bdf06d5..71d3f94987fa 100644 --- a/drivers/cache/sifive_ccache.c +++ b/drivers/cache/sifive_ccache.c @@ -275,7 +275,7 @@ static int sifive_ccache_probe(struct platform_device *pdev) rc = devm_request_irq(dev, g_irq[i], ccache_int_handler, 0, "ccache_ecc", NULL); if (rc) - return dev_err_probe(dev, rc, "Could not request IRQ %d\n", g_irq[i]); + return rc; } return 0; From b2f3a170ae968fac6270e89ce5738685bd2e530c Mon Sep 17 00:00:00 2001 From: Bence Csokas Date: Thu, 1 Oct 2026 13:00:07 +0200 Subject: [PATCH 3/3] cache: Make cpu_cache_invalidate_memregion() error out if there are no handlers Currently, if there are no registered handlers, cpu_cache_invalidate_memregion() returns 0. Callers are expected to check cpu_cache_has_invalidate_memregion() and return -ENXIO themselves, instead of calling this function. If a caller forgets to do this, they may erroneously think the operation succeeded. This is in contrast to x86, where cpu_cache_invalidate_memregion() itself checks if the operation is supported, and returns -ENXIO if it is not. Reviewed-by: Jonathan Cameron Signed-off-by: Bence Csokas Signed-off-by: Conor Dooley --- lib/cache_maint.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cache_maint.c b/lib/cache_maint.c index 9256a9ffc34c..132d2816d6b1 100644 --- a/lib/cache_maint.c +++ b/lib/cache_maint.c @@ -59,12 +59,12 @@ static int cache_inval_done_one(struct cache_coherency_ops_inst *cci) static int cache_invalidate_memregion(phys_addr_t addr, size_t size) { - int ret; struct cache_coherency_ops_inst *cci; struct cc_inval_params params = { .addr = addr, .size = size, }; + int ret = -ENXIO; guard(rwsem_read)(&cache_ops_instance_list_lock); list_for_each_entry(cci, &cache_ops_instance_list, node) { @@ -78,7 +78,7 @@ static int cache_invalidate_memregion(phys_addr_t addr, size_t size) return ret; } - return 0; + return ret; } struct cache_coherency_ops_inst *