From 64f47fca95c307c569adb7fec48ffc2891e3b209 Mon Sep 17 00:00:00 2001 From: Johan Hovold Date: Thu, 5 Mar 2026 11:39:18 +0100 Subject: [PATCH] media: go7007-loader: drop redundant device reference Driver core holds a reference to the USB interface and its parent USB device while the interface is bound to a driver and there is no need to take additional references unless the structures are needed after disconnect. Drop the redundant device reference to reduce cargo culting, make it easier to spot drivers where an extra reference is needed, and reduce the risk of memory leaks when drivers fail to release it. Signed-off-by: Johan Hovold Signed-off-by: Hans Verkuil --- drivers/media/usb/go7007/go7007-loader.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/media/usb/go7007/go7007-loader.c b/drivers/media/usb/go7007/go7007-loader.c index 243aa0ad074c..5747e6e4f2d6 100644 --- a/drivers/media/usb/go7007/go7007-loader.c +++ b/drivers/media/usb/go7007/go7007-loader.c @@ -41,9 +41,7 @@ static int go7007_loader_probe(struct usb_interface *interface, int ret; int i; - usbdev = usb_get_dev(interface_to_usbdev(interface)); - if (!usbdev) - goto failed2; + usbdev = interface_to_usbdev(interface); if (usbdev->descriptor.bNumConfigurations != 1) { dev_err(&interface->dev, "can't handle multiple config\n"); @@ -96,7 +94,6 @@ static int go7007_loader_probe(struct usb_interface *interface, return 0; failed2: - usb_put_dev(usbdev); dev_err(&interface->dev, "probe failed\n"); return -ENODEV; } @@ -104,7 +101,6 @@ static int go7007_loader_probe(struct usb_interface *interface, static void go7007_loader_disconnect(struct usb_interface *interface) { dev_info(&interface->dev, "disconnect\n"); - usb_put_dev(interface_to_usbdev(interface)); usb_set_intfdata(interface, NULL); }