mirror of
https://github.com/torvalds/linux.git
synced 2026-11-07 06:17:02 +01:00
exfat: hold the invalidate lock while truncating
truncate_setsize() ends in truncate_inode_pages(), which is documented
as being "Called under (and serialised by) inode->i_rwsem and
mapping->invalidate_lock".
Hold invalidate_lock while executing truncate_setsize() to ensure that
truncate and mmap writes are mutually exclusive. This can simplify the
handling in exfat_page_mkwrite().
Fixes: 82a81a7352 ("exfat: add iomap buffered I/O support")
Cc: stable@vger.kernel.org
Signed-off-by: Chi Zhiling <chizhiling@kylinos.cn>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
This commit is contained in:
parent
b70ab40750
commit
646df471c3
|
|
@ -413,6 +413,7 @@ int exfat_setattr(const struct mnt_idmap *idmap, struct dentry *dentry,
|
|||
* about to be freed.
|
||||
*/
|
||||
inode_dio_wait(inode);
|
||||
filemap_invalidate_lock(inode->i_mapping);
|
||||
truncate_setsize(inode, attr->ia_size);
|
||||
|
||||
/*
|
||||
|
|
@ -420,6 +421,7 @@ int exfat_setattr(const struct mnt_idmap *idmap, struct dentry *dentry,
|
|||
* is already written by it, so mark_inode_dirty() is unneeded.
|
||||
*/
|
||||
exfat_truncate(inode);
|
||||
filemap_invalidate_unlock(inode->i_mapping);
|
||||
} else
|
||||
mark_inode_dirty(inode);
|
||||
|
||||
|
|
@ -784,8 +786,10 @@ static int exfat_extend_valid_size(struct inode *inode, loff_t new_valid_size)
|
|||
ret = exfat_zero_new_range(inode, gap_start, new_valid_size);
|
||||
filemap_invalidate_unlock(inode->i_mapping);
|
||||
if (ret) {
|
||||
filemap_invalidate_lock(inode->i_mapping);
|
||||
truncate_setsize(inode, old_valid_size);
|
||||
exfat_truncate(inode);
|
||||
filemap_invalidate_unlock(inode->i_mapping);
|
||||
return ret;
|
||||
}
|
||||
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user