github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-10-10 12:28:02 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: ath12k: Fix ath12k_wifi7_mac_op_tx() style issues

Browse Source 
Commit e47d6c9bb4 ("wifi: ath12k: Advertise multicast Ethernet
encapsulation offload support") introduced a few style issues.

ath12k-check reports:
drivers/net/wireless/ath/ath12k/wifi7/hw.c:1042: line length of 92 exceeds 90 columns

And automated review did not like one if/else that did not use braces
for a single statement that also included a block comment.

Fix these issues.

Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Link: https://patch.msgid.link/20260711-ath12k_wifi7_mac_op_tx-line-length-v1-1-10e4899b98ef@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
This commit is contained in:
Jeff Johnson 2026-07-11 08:31:10 -07:00
parent 01cc0f59aa
commit 6385fd09a3
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
drivers/net/wireless/ath/ath12k/wifi7/hw.c
View File

@ -1031,18 +1031,22 @@ static void ath12k_wifi7_mac_op_tx(struct ieee80211_hw *hw,
if (cb_flags & ATH12K_SKB_HW_80211_ENCAP) {
/*
* skb->data may be modified for the iova_mask devices.
* It is better to use skb_copy() for such devices
* to avoid any potential skb corruption related issues.
* skb->data may be modified for the
* iova_mask devices. It is better to
* use skb_copy() for such devices to
* avoid any potential skb corruption
* related issues.
*/
if (tmp_dp->hw_params->iova_mask)
if (tmp_dp->hw_params->iova_mask) {
msdu_copied = skb_copy(skb, GFP_ATOMIC);
else
} else {
/*
* ath12k_wifi7_dp_tx() should treat cloned HW-encap
* Ethernet multicast frames as read-only.
* ath12k_wifi7_dp_tx() should
* treat cloned HW-encap Ethernet
* multicast frames as read-only.
*/
msdu_copied = skb_clone(skb, GFP_ATOMIC);
}
if (!msdu_copied) {
ath12k_err(ar->ab,
"skb copy/clone failure link_id 0x%X vdevid 0x%X\n",