media: staging: max96712: Add support for 3-lane C-PHY

Add basic support for outputting the test patterns on a 3-lane CSI-2
C-PHY bus. As the driver only can output frames form its internal test
pattern generator, enabling C-PHY output is as simple as setting the
output mode to C-PHY instead of D-PHY.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
[Sakari Ailus: Wrap long lines.]
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Niklas Söderlund 2023-02-11 15:46:14 +01:00 committed by Hans Verkuil
parent 9f43234ef0
commit 6311a0d022

View File

@ -30,6 +30,7 @@ struct max96712_priv {
struct regmap *regmap;
struct gpio_desc *gpiod_pwdn;
bool cphy;
struct v4l2_mbus_config_mipi_csi2 mipi;
struct v4l2_subdev sd;
@ -127,10 +128,18 @@ static void max96712_mipi_configure(struct max96712_priv *priv)
/* Select 2x4 mode. */
max96712_write(priv, 0x8a0, 0x04);
/* Configure a 4-lane DPHY using PHY0 and PHY1. */
/* TODO: Add support for 2-lane and 1-lane configurations. */
/* TODO: Add support CPHY mode. */
max96712_write(priv, 0x94a, 0xc0);
if (priv->cphy) {
/* Configure a 3-lane C-PHY using PHY0 and PHY1. */
max96712_write(priv, 0x94a, 0xa0);
/* Configure C-PHY timings. */
max96712_write(priv, 0x8ad, 0x3f);
max96712_write(priv, 0x8ae, 0x7d);
} else {
/* Configure a 4-lane D-PHY using PHY0 and PHY1. */
max96712_write(priv, 0x94a, 0xc0);
}
/* Configure lane mapping for PHY0 and PHY1. */
/* TODO: Add support for lane swapping. */
@ -332,8 +341,9 @@ static int max96712_parse_dt(struct max96712_priv *priv)
{
struct fwnode_handle *ep;
struct v4l2_fwnode_endpoint v4l2_ep = {
.bus_type = V4L2_MBUS_CSI2_DPHY
.bus_type = V4L2_MBUS_UNKNOWN,
};
unsigned int supported_lanes;
int ret;
ep = fwnode_graph_get_endpoint_by_id(dev_fwnode(&priv->client->dev), 4,
@ -350,8 +360,24 @@ static int max96712_parse_dt(struct max96712_priv *priv)
return -EINVAL;
}
if (v4l2_ep.bus.mipi_csi2.num_data_lanes != 4) {
dev_err(&priv->client->dev, "Only 4 data lanes supported\n");
switch (v4l2_ep.bus_type) {
case V4L2_MBUS_CSI2_DPHY:
supported_lanes = 4;
priv->cphy = false;
break;
case V4L2_MBUS_CSI2_CPHY:
supported_lanes = 3;
priv->cphy = true;
break;
default:
dev_err(&priv->client->dev, "Unsupported bus-type %u\n",
v4l2_ep.bus_type);
return -EINVAL;
}
if (v4l2_ep.bus.mipi_csi2.num_data_lanes != supported_lanes) {
dev_err(&priv->client->dev, "Only %u data lanes supported\n",
supported_lanes);
return -EINVAL;
}