github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 01:55:51 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: most/net: remove dead code from skb_to_mamac() and skb_to_mep()

Browse Source 
The overflow checks in skb_to_mamac() and skb_to_mep() are always false:

  mdp_len = (skb->len - ETH_HLEN) + MDP_HDR_LEN = skb->len + 2
  mep_len = skb->len + MEP_HDR_LEN = skb->len + 8

Remove these checks to clean up the code.

Signed-off-by: Hadi Chokr <hadichokr@icloud.com>
Link: https://patch.msgid.link/20260401125711.80822-1-hadichokr@icloud.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Hadi Chokr 2026-04-01 14:57:11 +02:00 committed by Greg Kroah-Hartman
parent fde67f5b1f
commit 62cf6eb023
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/staging/most/net/net.c
View File

@ -80,11 +80,6 @@ static int skb_to_mamac(const struct sk_buff *skb, struct mbo *mbo)
unsigned int payload_len = skb->len - ETH_HLEN;
unsigned int mdp_len = payload_len + MDP_HDR_LEN;
if (mdp_len < skb->len) {
pr_err("drop: too large packet! (%u)\n", skb->len);
return -EINVAL;
}
if (mbo->buffer_length < mdp_len) {
pr_err("drop: too small buffer! (%d for %d)\n",
mbo->buffer_length, mdp_len);
@ -132,11 +127,6 @@ static int skb_to_mep(const struct sk_buff *skb, struct mbo *mbo)
u8 *buff = mbo->virt_address;
unsigned int mep_len = skb->len + MEP_HDR_LEN;
if (mep_len < skb->len) {
pr_err("drop: too large packet! (%u)\n", skb->len);
return -EINVAL;
}
if (mbo->buffer_length < mep_len) {
pr_err("drop: too small buffer! (%d for %d)\n",
mbo->buffer_length, mep_len);