github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 18:21:24 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

x86/vdso: Prepare for robust futex unlock support

Browse Source 
There will be a VDSO function to unlock non-contended robust futexes in
user space. The unlock sequence is racy vs. clearing the list_pending_op
pointer in the task's robust list head. To plug this race the kernel needs
to know the critical section window so it can clear the pointer when the
task is interrupted within that race window. The window is determined by
labels in the inline assembly.

Add these symbols to the vdso2c generator and use them in the VDSO VMA code
to update the critical section addresses in mm_struct::futex on (re)map().

The symbols are not exported to user space, but available in the debug
version of the vDSO.

Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
Link: https://patch.msgid.link/20260602090535.828312645@kernel.org
This commit is contained in:
Thomas Gleixner 2026-06-02 11:10:08 +02:00 committed by Peter Zijlstra
parent 7010c39d8f
commit 61cfc8e372
3 changed files with 43 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
arch/x86/entry/vdso/vma.c
View File

@ -6,6 +6,7 @@
*/
#include <linux/mm.h>
#include <linux/err.h>
#include <linux/futex.h>
#include <linux/sched.h>
#include <linux/sched/task_stack.h>
#include <linux/slab.h>
@ -73,6 +74,31 @@ static void vdso_fix_landing(const struct vdso_image *image,
regs->ip = new_vma->vm_start + ipoffset;
}
#ifdef CONFIG_FUTEX_ROBUST_UNLOCK
static void vdso_futex_robust_unlock_update_ips(void)
{
const struct vdso_image *image = current->mm->context.vdso_image;
unsigned long vdso = (unsigned long) current->mm->context.vdso;
struct futex_mm_data *fd = &current->mm->futex;
unsigned int idx = 0;
futex_reset_cs_ranges(fd);
#ifdef CONFIG_X86_64
futex_set_vdso_cs_range(fd, idx, vdso + image->sym___futex_list64_try_unlock_cs_start,
vdso + image->sym___futex_list64_try_unlock_cs_end, false);
idx++;
#endif /* CONFIG_X86_64 */
#if defined(CONFIG_X86_32) || defined(CONFIG_COMPAT)
futex_set_vdso_cs_range(fd, idx, vdso + image->sym___futex_list32_try_unlock_cs_start,
vdso + image->sym___futex_list32_try_unlock_cs_end, true);
#endif /* CONFIG_X86_32 || CONFIG_COMPAT */
}
#else
static inline void vdso_futex_robust_unlock_update_ips(void) { }
#endif
static int vdso_mremap(const struct vm_special_mapping *sm,
struct vm_area_struct *new_vma)
{
@ -80,6 +106,7 @@ static int vdso_mremap(const struct vm_special_mapping *sm,
vdso_fix_landing(image, new_vma);
current->mm->context.vdso = (void __user *)new_vma->vm_start;
vdso_futex_robust_unlock_update_ips();
return 0;
}
@ -185,6 +212,8 @@ static int map_vdso(const struct vdso_image *image, unsigned long addr)
current->mm->context.vdso = (void __user *)text_start;
current->mm->context.vdso_image = image;
vdso_futex_robust_unlock_update_ips();
up_fail:
mmap_write_unlock(mm);
return ret;

4
arch/x86/include/asm/vdso.h
View File

@ -24,6 +24,10 @@ struct vdso_image {
long sym_int80_landing_pad;
long sym_vdso32_sigreturn_landing_pad;
long sym_vdso32_rt_sigreturn_landing_pad;
long sym___futex_list64_try_unlock_cs_start;
long sym___futex_list64_try_unlock_cs_end;
long sym___futex_list32_try_unlock_cs_start;
long sym___futex_list32_try_unlock_cs_end;
};
extern const struct vdso_image vdso64_image;

16
arch/x86/tools/vdso2c.c
View File

@ -75,12 +75,16 @@ struct vdso_sym {
};
struct vdso_sym required_syms[] = {
{"__kernel_vsyscall", true},
{"__kernel_sigreturn", true},
{"__kernel_rt_sigreturn", true},
{"int80_landing_pad", true},
{"vdso32_rt_sigreturn_landing_pad", true},
{"vdso32_sigreturn_landing_pad", true},
{"__kernel_vsyscall", true},
{"__kernel_sigreturn", true},
{"__kernel_rt_sigreturn", true},
{"int80_landing_pad", true},
{"vdso32_rt_sigreturn_landing_pad", true},
{"vdso32_sigreturn_landing_pad", true},
{"__futex_list64_try_unlock_cs_start", true},
{"__futex_list64_try_unlock_cs_end", true},
{"__futex_list32_try_unlock_cs_start", true},
{"__futex_list32_try_unlock_cs_end", true},
};
__attribute__((format(printf, 1, 2))) __attribute__((noreturn))