github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 05:55:44 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iio: adc: ad4030: Switch to sparse friendly iio_device_claim/release_direct()

Browse Source 
These new functions allow sparse to find failures to release
direct mode reducing chances of bugs over the claim_direct_mode()
functions that are deprecated.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250217141630.897334-10-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
This commit is contained in:
Jonathan Cameron 2025-02-17 14:16:09 +00:00
parent e493763302
commit 5ff6b02d9b
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
drivers/iio/adc/ad4030.c
View File

@ -784,13 +784,12 @@ static int ad4030_read_raw(struct iio_dev *indio_dev,
if (info == IIO_CHAN_INFO_SCALE)
return ad4030_get_chan_scale(indio_dev, chan, val, val2);
ret = iio_device_claim_direct_mode(indio_dev);
if (ret)
return ret;
if (!iio_device_claim_direct(indio_dev))
return -EBUSY;
ret = ad4030_read_raw_dispatch(indio_dev, chan, val, val2, info);
iio_device_release_direct_mode(indio_dev);
iio_device_release_direct(indio_dev);
return ret;
}
@ -822,13 +821,12 @@ static int ad4030_write_raw(struct iio_dev *indio_dev,
{
int ret;
ret = iio_device_claim_direct_mode(indio_dev);
if (ret)
return ret;
if (!iio_device_claim_direct(indio_dev))
return -EBUSY;
ret = ad4030_write_raw_dispatch(indio_dev, chan, val, val2, info);
iio_device_release_direct_mode(indio_dev);
iio_device_release_direct(indio_dev);
return ret;
}
@ -839,16 +837,15 @@ static int ad4030_reg_access(struct iio_dev *indio_dev, unsigned int reg,
const struct ad4030_state *st = iio_priv(indio_dev);
int ret;
ret = iio_device_claim_direct_mode(indio_dev);
if (ret)
return ret;
if (!iio_device_claim_direct(indio_dev))
return -EBUSY;
if (readval)
ret = regmap_read(st->regmap, reg, readval);
else
ret = regmap_write(st->regmap, reg, writeval);
iio_device_release_direct_mode(indio_dev);
iio_device_release_direct(indio_dev);
return ret;
}