From 5fe1b9dfa5c3c51a9d4d68b407ad9c49096e4b3e Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Thu, 9 Jul 2026 11:34:00 +0800 Subject: [PATCH] power: supply: max14656_charger_detector: Remove redundant dev_err()/dev_err_probe() The devm_request_threaded_irq() and devm_request_irq() now automatically log detailed error messages on failure. This eliminates the need for driver-specific dev_err() and dev_err_probe() calls that previously printed generic messages. Signed-off-by: Pan Chuang Link: https://patch.msgid.link/20260709033428.362970-22-panchuang@vivo.com Signed-off-by: Sebastian Reichel --- drivers/power/supply/max14656_charger_detector.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/supply/max14656_charger_detector.c b/drivers/power/supply/max14656_charger_detector.c index b6c3bc0d9ec1..e36d0fe1846b 100644 --- a/drivers/power/supply/max14656_charger_detector.c +++ b/drivers/power/supply/max14656_charger_detector.c @@ -288,10 +288,8 @@ static int max14656_probe(struct i2c_client *client) ret = devm_request_irq(dev, chip->irq, max14656_irq, IRQF_TRIGGER_FALLING, MAX14656_NAME, chip); - if (ret) { - dev_err(dev, "request_irq %d failed\n", chip->irq); + if (ret) return -EINVAL; - } enable_irq_wake(chip->irq); schedule_delayed_work(&chip->irq_work, msecs_to_jiffies(2000));