github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-12 16:18:45 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

selftests: net: Remove unnecessary backslashes in fq_band_pktlimit.sh

Browse Source 
Address "grep: warning: stray \ before white space" warning from GNU
grep 3.12. This warns the misplaced backslashes before whitespaces
(e.g. \\' ' or '\ ') which leads to unspecified behavior [1].

We can just remove the backslashes before whitespaces as POSIX says:

  Enclosing characters in single-quotes ('') shall preserve the literal
  value of each character within the single-quotes.

and bourne-compatible shells behave so.

[1]: https://lists.gnu.org/r/bug-gnulib/2022-05/msg00057.html

Signed-off-by: Yohei Kojima <yk@y-koj.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/dd0bbd48cdf468da56ec34fd61cecd4d2111d7ba.1774372510.git.yk@y-koj.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Yohei Kojima 2026-03-25 02:20:28 +09:00 committed by Jakub Kicinski
parent e1877cf623
commit 5f70b0aa08
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tools/testing/selftests/net/fq_band_pktlimit.sh
View File

@ -32,19 +32,19 @@ tc qdisc replace dev dummy0 root handle 1: fq quantum 1514 initial_quantum 1514
DELAY=400000
./cmsg_sender -6 -p u -d "${DELAY}" -n 20 fdaa::2 8000
OUT1="$(tc -s qdisc show dev dummy0 | grep '^\ Sent')"
OUT1="$(tc -s qdisc show dev dummy0 | grep '^ Sent')"
./cmsg_sender -6 -p u -d "${DELAY}" -n 20 fdaa::2 8000
OUT2="$(tc -s qdisc show dev dummy0 | grep '^\ Sent')"
OUT2="$(tc -s qdisc show dev dummy0 | grep '^ Sent')"
./cmsg_sender -6 -p u -d "${DELAY}" -n 20 -P 7 fdaa::2 8000
OUT3="$(tc -s qdisc show dev dummy0 | grep '^\ Sent')"
OUT3="$(tc -s qdisc show dev dummy0 | grep '^ Sent')"
# Initial stats will report zero sent, as all packets are still
# queued in FQ. Sleep for at least the delay period and see that
# twenty are now sent.
sleep 0.6
OUT4="$(tc -s qdisc show dev dummy0 | grep '^\ Sent')"
OUT4="$(tc -s qdisc show dev dummy0 | grep '^ Sent')"
# Log the output after the test
echo "${OUT1}"
@ -53,7 +53,7 @@ echo "${OUT3}"
echo "${OUT4}"
# Test the output for expected values
echo "${OUT1}" | grep -q '0\ pkt\ (dropped\ 10' || die "unexpected drop count at 1"
echo "${OUT2}" | grep -q '0\ pkt\ (dropped\ 30' || die "unexpected drop count at 2"
echo "${OUT3}" | grep -q '0\ pkt\ (dropped\ 40' || die "unexpected drop count at 3"
echo "${OUT4}" | grep -q '20\ pkt\ (dropped\ 40' || die "unexpected accept count at 4"
echo "${OUT1}" | grep -q '0 pkt (dropped 10' || die "unexpected drop count at 1"
echo "${OUT2}" | grep -q '0 pkt (dropped 30' || die "unexpected drop count at 2"
echo "${OUT3}" | grep -q '0 pkt (dropped 40' || die "unexpected drop count at 3"
echo "${OUT4}" | grep -q '20 pkt (dropped 40' || die "unexpected accept count at 4"