From 5c3c385a68deb125d853ec9a25df901cfa2e4049 Mon Sep 17 00:00:00 2001 From: Shaleen Agrawal Date: Thu, 24 Jun 2021 14:57:44 -0700 Subject: [PATCH] sched: walt: Ensure only valid cpu selected Under FBT, we currently do not check if an active candidate is actually valid before setting it as part of the candidates mask. This can lead to page faults. Change-Id: I5aedb3bd1e076736270aa03b8889c67606c2a25d Signed-off-by: Shaleen Agrawal --- kernel/sched/walt/walt_cfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/walt/walt_cfs.c b/kernel/sched/walt/walt_cfs.c index 7e7649337611..d7c86df25308 100644 --- a/kernel/sched/walt/walt_cfs.c +++ b/kernel/sched/walt/walt_cfs.c @@ -448,7 +448,7 @@ static void walt_find_best_target(struct sched_domain *sd, if (unlikely(cpumask_empty(candidates))) { if (most_spare_cap_cpu != -1) cpumask_set_cpu(most_spare_cap_cpu, candidates); - else if (!cpu_active(prev_cpu)) + else if (!cpu_active(prev_cpu) && active_candidate != -1) cpumask_set_cpu(active_candidate, candidates); }