From 5b598ba5f3bf367944956cee59c6d078c53ca694 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ricardo=20B=2E=20Marli=C3=A8re=20=28SUSE=29?= Date: Tue, 20 Oct 2026 16:41:31 -0300 Subject: [PATCH] ktest: Accept quoted bad term in git bisect output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Git commit 0c0f93e7fa64 ("bisect: print bisect terms in single quotes") changed the completion message to put single quotes around the bisect term. run_git_bisect() only recognizes "is the first bad commit", so it misses completion and continues the bisect loop with newer Git. Accept both quoted and unquoted forms to retain compatibility with older Git versions. Link: https://git.kernel.org/pub/scm/git/git.git/commit/?id=0c0f93e7fa645c1058226a9bfde9e2b4441edf96 Assisted-by: LLM Signed-off-by: Ricardo B. Marlière (SUSE) Signed-off-by: Steven Rostedt --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index ad61f1ee2e7c..66fd98b6b04b 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -3030,7 +3030,7 @@ sub run_git_bisect { doprint "SUCCESS\n"; if ($output =~ m/^(Bisecting: .*\(roughly \d+ steps?\))\s+\[([[:xdigit:]]+)\]/) { doprint "$1 [$2]\n"; - } elsif ($output =~ m/^([[:xdigit:]]+) is the first bad commit/) { + } elsif ($output =~ m/^([[:xdigit:]]+) is the first (bad|'bad') commit/) { $bisect_bad_commit = $1; doprint "Found bad commit... $1\n"; return 0;