github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-22 22:22:08 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: gpib: Fix secondary address restriction

Browse Source 
GPIB secondary addresses have valid values between 0 and 31
inclusive. The Make Secondary Address function MSA, used to form
the protocol byte, was using the gpib_address_restrict function
erroneously restricting the address range to 0 through 30.

Remove the call to gpib_address_restrict and simply trim the
address to 5 bits.

Fixes: 2da03e7e31 ("staging: gpib: Add user api include files")
Signed-off-by: Dave Penkler <dpenkler@gmail.com>
Link: https://lore.kernel.org/r/20250520155100.5808-1-dpenkler@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dave Penkler 2025-05-20 17:51:00 +02:00 committed by Greg Kroah-Hartman
parent 7a7f07f248
commit 5aac95320d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/staging/gpib/uapi/gpib.h
View File

@ -136,7 +136,7 @@ static inline __u8 MTA(unsigned int addr)
static inline __u8 MSA(unsigned int addr)
{
return gpib_address_restrict(addr) | SAD;
return (addr & 0x1f) | SAD;
}
static inline __u8 PPE_byte(unsigned int dio_line, int sense)