arm64: dts: qcom: msm8998: Don't pull-up I2C pins by default in sleep

When the I2C controller is disabled, no communication is expected to
take place. Without traffic on the bus, the pull-up is unnecessary.

Both the vendor kernel for this platform and DTs of other SoCs in
upstream concur this logic. Change the default and clean up now-NOP
overrides.

Fixes: 0fee55fc0d ("arm64: dts: qcom: msm8998: Add I2C pinctrl and fix BLSP2_I2C naming")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260717-topic-june26_dts_fixes-v2-1-797cd46e5d9f@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
This commit is contained in:
Konrad Dybcio 2026-07-17 12:59:58 +02:00 committed by Bjorn Andersson
parent 882bb27c61
commit 58ce9a2b90
3 changed files with 12 additions and 21 deletions

View File

@ -229,10 +229,6 @@ rmi4-f11@11 {
};
};
&blsp1_i2c5_sleep {
bias-disable;
};
&blsp1_uart3 {
status = "okay";

View File

@ -217,11 +217,6 @@ rmi4-f1a@1a {
};
};
&blsp1_i2c5_sleep {
/delete-property/ bias-pull-up;
bias-disable;
};
&blsp1_uart3 {
status = "okay";

View File

@ -1183,7 +1183,7 @@ blsp1_i2c1_sleep: blsp1-i2c1-sleep-state-state {
pins = "gpio2", "gpio3";
function = "blsp_i2c1";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_i2c2_default: blsp1-i2c2-default-state {
@ -1197,7 +1197,7 @@ blsp1_i2c2_sleep: blsp1-i2c2-sleep-state-state {
pins = "gpio32", "gpio33";
function = "blsp_i2c2";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_i2c3_default: blsp1-i2c3-default-state {
@ -1211,7 +1211,7 @@ blsp1_i2c3_sleep: blsp1-i2c3-sleep-state {
pins = "gpio47", "gpio48";
function = "blsp_i2c3";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_i2c4_default: blsp1-i2c4-default-state {
@ -1225,7 +1225,7 @@ blsp1_i2c4_sleep: blsp1-i2c4-sleep-state {
pins = "gpio10", "gpio11";
function = "blsp_i2c4";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_i2c5_default: blsp1-i2c5-default-state {
@ -1239,7 +1239,7 @@ blsp1_i2c5_sleep: blsp1-i2c5-sleep-state {
pins = "gpio87", "gpio88";
function = "blsp_i2c5";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_i2c6_default: blsp1-i2c6-default-state {
@ -1253,7 +1253,7 @@ blsp1_i2c6_sleep: blsp1-i2c6-sleep-state {
pins = "gpio43", "gpio44";
function = "blsp_i2c6";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp1_spi_b_default: blsp1-spi-b-default-state {
@ -1318,7 +1318,7 @@ blsp2_i2c1_sleep: blsp2-i2c1-sleep-state {
pins = "gpio55", "gpio56";
function = "blsp_i2c7";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_i2c2_default: blsp2-i2c2-default-state {
@ -1332,7 +1332,7 @@ blsp2_i2c2_sleep: blsp2-i2c2-sleep-state {
pins = "gpio6", "gpio7";
function = "blsp_i2c8";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_i2c3_default: blsp2-i2c3-default-state {
@ -1346,7 +1346,7 @@ blsp2_i2c3_sleep: blsp2-i2c3-sleep-state {
pins = "gpio51", "gpio52";
function = "blsp_i2c9";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_i2c4_default: blsp2-i2c4-default-state {
@ -1360,7 +1360,7 @@ blsp2_i2c4_sleep: blsp2-i2c4-sleep-state {
pins = "gpio67", "gpio68";
function = "blsp_i2c10";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_i2c5_default: blsp2-i2c5-default-state {
@ -1374,7 +1374,7 @@ blsp2_i2c5_sleep: blsp2-i2c5-sleep-state {
pins = "gpio60", "gpio61";
function = "blsp_i2c11";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_i2c6_default: blsp2-i2c6-default-state {
@ -1388,7 +1388,7 @@ blsp2_i2c6_sleep: blsp2-i2c6-sleep-state {
pins = "gpio83", "gpio84";
function = "blsp_i2c12";
drive-strength = <2>;
bias-pull-up;
bias-disable;
};
blsp2_spi1_default: blsp2-spi1-default-state {