github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-11-07 06:17:02 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

selftests/configfs: fix the build on 32-bit architectures

Browse Source 
The fixture setup checks the result of mkdtemp() with ASSERT_NE(), which
hands the pointer to the harness. The harness casts both operands to
intmax_t to print them, and on 32-bit architectures gcc warns about the
cast from a pointer to an integer of a different size. The configfs
test builds with -Werror, so it fails to build there:

  kselftest_harness.h:797:49: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]

Compare the result against NULL inside ASSERT_TRUE(), so that the
harness only sees an int.

Fixes: a7fdcb2edd ("selftests/configfs: add tests for the userspace interface")
Signed-off-by: Sasha Levin <sashal@kernel.org>
Reviewed-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20261103141627.30838-1-sashal@kernel.org
Signed-off-by: Breno Leitao <leitao@debian.org>
This commit is contained in:
Sasha Levin 2026-11-03 09:16:27 -05:00 committed by Breno Leitao
parent 05441d697f
commit 57d94d26ed
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/testing/selftests/filesystems/configfs/configfs_test.c
View File

@ -122,7 +122,7 @@ FIXTURE_SETUP(configfs)
ASSERT_EQ(unshare(CLONE_NEWNS), 0);
ASSERT_EQ(mount(NULL, "/", NULL, MS_REC | MS_PRIVATE, NULL), 0);
ASSERT_NE(mkdtemp(tmpl), NULL);
ASSERT_TRUE(mkdtemp(tmpl) != NULL);
strcpy(self->mnt, tmpl);
ASSERT_EQ(mount("configfs", self->mnt, "configfs", 0, NULL), 0);