github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-25 23:52:08 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

usb: cdns3: fix static checker warning.

Browse Source 
The patch c450e48eb570: "usb: cdns3: add power lost support for
system resume" from Feb 18, 2021, leads to the following static
checker warning:

        drivers/usb/cdns3/core.c:551 cdns_resume()
        error: uninitialized symbol 'ret'.

drivers/usb/cdns3/core.c
544
545     if (!role_changed) {
546            if (cdns->role == USB_ROLE_HOST)
547                  ret = cdns_drd_host_on(cdns);
548     else if (cdns->role == USB_ROLE_DEVICE)
549            ret = cdns_drd_gadget_on(cdns);

"ret" is uninitialized at else branch.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Frank Li <frank.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@kernel.org>
This commit is contained in:
Frank Li 2021-03-10 10:01:25 -06:00 committed by Peter Chen
parent ef32e0513a
commit 575dd7ece6
No known key found for this signature in database
GPG Key ID: 4859298150D671BB
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/usb/cdns3/core.c
View File

@ -527,7 +527,7 @@ int cdns_resume(struct cdns *cdns, u8 set_active)
struct device *dev = cdns->dev;
enum usb_role real_role;
bool role_changed = false;
int ret;
int ret = 0;
if (cdns_power_is_lost(cdns)) {
if (cdns->role_sw) {