github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-27 09:36:22 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

psp: add a comment about a psp_dev add netlink notification

Browse Source 
In psp_dev_create(), the DEV_ADD_NTF netlink notification is sent
before the device is published to the netdev via rcu_assign_pointer().
IIRC this is intentional because a single PSP device is expected
to be shared with multiple netdevs. So we are trying to default to
not having the netdev info. We can change it if someone complains
but for now just add a comment that it's intentional.

Reviewed-by: Willem de Bruijn <willemb@google.com>
Link: https://patch.msgid.link/20260428205352.1247325-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jakub Kicinski 2026-04-28 13:53:51 -07:00
parent 28e71cb51c
commit 5637fcb11c
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/psp/psp_main.c
View File

@ -90,6 +90,10 @@ psp_dev_create(struct net_device *netdev,
mutex_lock(&psd->lock);
mutex_unlock(&psp_devs_lock);
/* notify before netdev assignment
* There's no strong reason for it, but thinking is to avoid creating
* implicit expectations about the PSP dev <> netdev relationship.
*/
psp_nl_notify_dev(psd, PSP_CMD_DEV_ADD_NTF);
rcu_assign_pointer(netdev->psp_dev, psd);