github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 01:53:29 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

gpio: sysfs: Fix an end of loop test in gpiod_unexport()

Browse Source 
The test for "if (!desc_data)" does not work correctly because the list
iterator in a list_for_each_entry() loop is always non-NULL. If we don't
exit via a break, then it points to invalid memory.  Instead, use a tmp
variable for the list iterator and only set the "desc_data" when we have
found a match.

Fixes: 1cd53df733 ("gpio: sysfs: don't look up exported lines as class devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/747545bf-05f0-4f89-ba77-cb96bf9041f1@sabinyo.mountain
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Dan Carpenter 2025-07-18 16:22:15 -05:00 committed by Bartosz Golaszewski
parent ae455b2494
commit 5607f5ed3c
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/gpio/gpiolib-sysfs.c
View File

@ -927,7 +927,7 @@ EXPORT_SYMBOL_GPL(gpiod_export_link);
*/
void gpiod_unexport(struct gpio_desc *desc)
{
struct gpiod_data *desc_data = NULL;
struct gpiod_data *tmp, *desc_data = NULL;
struct gpiodev_data *gdev_data;
struct gpio_device *gdev;
@ -945,9 +945,12 @@ void gpiod_unexport(struct gpio_desc *desc)
if (!gdev_data)
return;
list_for_each_entry(desc_data, &gdev_data->exported_lines, list)
if (gpiod_is_equal(desc, desc_data->desc))
list_for_each_entry(tmp, &gdev_data->exported_lines, list) {
if (gpiod_is_equal(desc, tmp->desc)) {
desc_data = tmp;
break;
}
}
if (!desc_data)
return;