github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 04:34:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

firmware: imx: scu: manage mailbox channels and global handle

Browse Source 
imx_scu_probe() requests mailbox channels with the non-managed
mbox_request_channel_byname() helper and then publishes sc_ipc through
the global imx_sc_ipc_handle.  Later probe failures, including child
population failure, can leave the channels and global handle live after
the probe has failed.

Register devres actions to free each mailbox channel and clear the global
handle.  Also depopulate partially created child devices when
devm_of_platform_populate() reports an error.

Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
This commit is contained in:
Pengpeng Hou 2026-06-16 08:59:01 +08:00 committed by Frank Li
parent 116165611d
commit 55c748d596
1 changed files with 24 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
drivers/firmware/imx/imx-scu.c
View File

@ -82,6 +82,17 @@ static int imx_sc_linux_errmap[IMX_SC_ERR_LAST] = {
static struct imx_sc_ipc *imx_sc_ipc_handle;
static void imx_scu_free_mbox_chan(void *data)
{
mbox_free_channel(data);
}
static void imx_scu_clear_handle(void *data)
{
if (imx_sc_ipc_handle == data)
imx_sc_ipc_handle = NULL;
}
static inline int imx_sc_to_linux_errno(int errno)
{
if (errno >= IMX_SC_ERR_NONE && errno < IMX_SC_ERR_LAST)
@ -321,6 +332,11 @@ static int imx_scu_probe(struct platform_device *pdev)
dev_dbg(dev, "request mbox chan %s\n", chan_name);
/* chan_name is not used anymore by framework */
kfree(chan_name);
ret = devm_add_action_or_reset(dev, imx_scu_free_mbox_chan,
sc_chan->ch);
if (ret)
return ret;
}
sc_ipc->dev = dev;
@ -330,6 +346,9 @@ static int imx_scu_probe(struct platform_device *pdev)
init_completion(&sc_ipc->done);
imx_sc_ipc_handle = sc_ipc;
ret = devm_add_action_or_reset(dev, imx_scu_clear_handle, sc_ipc);
if (ret)
return ret;
ret = imx_scu_soc_init(dev);
if (ret)
@ -342,7 +361,11 @@ static int imx_scu_probe(struct platform_device *pdev)
dev_info(dev, "NXP i.MX SCU Initialized\n");
return devm_of_platform_populate(dev);
ret = devm_of_platform_populate(dev);
if (ret)
of_platform_depopulate(dev);
return ret;
}
static const struct of_device_id imx_scu_match[] = {