github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-30 10:04:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

iommufd: Do not allow _iommufd_object_alloc_ucmd if abort op is set

Browse Source 
An abort op was introduced to allow its caller to invoke it within a lock
in the caller's function. On the other hand, _iommufd_object_alloc_ucmd()
would invoke the abort op in iommufd_object_abort_and_destroy() that must
be outside the caller's lock. So, these two cannot work together.

Add a validation in the _iommufd_object_alloc_ucmd(). Pick -EOPNOTSUPP to
reject the function call, indicating that the object allocator is buggy.

Link: https://patch.msgid.link/r/20250710202354.1658511-1-nicolinc@nvidia.com
Suggested-by: Xu Yilun <yilun.xu@linux.intel.com>
Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Xu Yilun <yilun.xu@linux.intel.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
This commit is contained in:
Nicolin Chen 2025-07-10 13:23:54 -07:00 committed by Jason Gunthorpe
parent 32b2d3a57e
commit 5510bd89da
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/iommu/iommufd/main.c
View File

@ -71,6 +71,15 @@ struct iommufd_object *_iommufd_object_alloc_ucmd(struct iommufd_ucmd *ucmd,
if (WARN_ON(ucmd->new_obj))
return ERR_PTR(-EBUSY);
/*
* An abort op means that its caller needs to invoke it within a lock in
* the caller. So it doesn't work with _iommufd_object_alloc_ucmd() that
* will invoke the abort op in iommufd_object_abort_and_destroy(), which
* must be outside the caller's lock.
*/
if (WARN_ON(iommufd_object_ops[type].abort))
return ERR_PTR(-EOPNOTSUPP);
new_obj = _iommufd_object_alloc(ucmd->ictx, size, type);
if (IS_ERR(new_obj))
return new_obj;