github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-06 05:27:07 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

scsi: ufs: host: Hold reference returned by of_parse_phandle()

Browse Source 
commit a3435afba8 upstream.

In ufshcd_populate_vreg(), we should hold the reference returned by
of_parse_phandle() and then use it to call of_node_put() for refcount
balance.

Link: https://lore.kernel.org/r/20220719071529.1081166-1-windhl@126.com
Fixes: aa49761309 ("ufs: Add regulator enable support")
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Liang He 2022-07-19 15:15:29 +08:00 committed by Greg Kroah-Hartman
parent 160f79561e
commit 54a73d6544
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/scsi/ufs/ufshcd-pltfrm.c
View File

@ -107,9 +107,20 @@ static int ufshcd_parse_clock_info(struct ufs_hba *hba)
return ret; return ret;
} }
static bool phandle_exists(const struct device_node *np,
const char *phandle_name, int index)
{
struct device_node *parse_np = of_parse_phandle(np, phandle_name, index);
if (parse_np)
of_node_put(parse_np);
return parse_np != NULL;
}
#define MAX_PROP_SIZE 32 #define MAX_PROP_SIZE 32
static int ufshcd_populate_vreg(struct device *dev, const char *name, static int ufshcd_populate_vreg(struct device *dev, const char *name,
struct ufs_vreg **out_vreg) struct ufs_vreg **out_vreg)
{ {
int ret = 0; int ret = 0;
char prop_name[MAX_PROP_SIZE]; char prop_name[MAX_PROP_SIZE];
@ -122,7 +133,7 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name,
} }
snprintf(prop_name, MAX_PROP_SIZE, "%s-supply", name); snprintf(prop_name, MAX_PROP_SIZE, "%s-supply", name);
if (!of_parse_phandle(np, prop_name, 0)) { if (!phandle_exists(np, prop_name, 0)) {
dev_info(dev, "%s: Unable to find %s regulator, assuming enabled\n", dev_info(dev, "%s: Unable to find %s regulator, assuming enabled\n",
__func__, prop_name); __func__, prop_name);
goto out; goto out;