github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-31 18:43:33 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: marvell: prestera: fix memory leak in prestera_rxtx_switch_init()

Browse Source 
When prestera_sdma_switch_init() failed, the memory pointed to by
sw->rxtx isn't released. Fix it. Only be compiled, not be tested.

Fixes: 501ef3066c ("net: marvell: prestera: Add driver for Prestera family ASIC devices")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: Vadym Kochan <vadym.kochan@plvision.eu>
Link: https://lore.kernel.org/r/20221108025607.338450-1-shaozhengchao@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Zhengchao Shao 2022-11-08 10:56:07 +08:00 committed by Jakub Kicinski
parent 2b01450328
commit 519b58bbfa
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/net/ethernet/marvell/prestera/prestera_rxtx.c
View File

@ -776,6 +776,7 @@ static netdev_tx_t prestera_sdma_xmit(struct prestera_sdma *sdma,
int prestera_rxtx_switch_init(struct prestera_switch *sw) int prestera_rxtx_switch_init(struct prestera_switch *sw)
{ {
struct prestera_rxtx *rxtx; struct prestera_rxtx *rxtx;
int err;
rxtx = kzalloc(sizeof(*rxtx), GFP_KERNEL); rxtx = kzalloc(sizeof(*rxtx), GFP_KERNEL);
if (!rxtx) if (!rxtx)
@ -783,7 +784,11 @@ int prestera_rxtx_switch_init(struct prestera_switch *sw)
sw->rxtx = rxtx; sw->rxtx = rxtx;
return prestera_sdma_switch_init(sw); err = prestera_sdma_switch_init(sw);
if (err)
kfree(rxtx);
return err;
} }
void prestera_rxtx_switch_fini(struct prestera_switch *sw) void prestera_rxtx_switch_fini(struct prestera_switch *sw)