github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-02 03:24:19 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

gpio: viperboard: Unlock on error in vprbrd_gpiob_direction_output()

Browse Source 
Unlock before returning if vprbrd_gpiob_setdir() fails.

Fixes: 55e2d1eec1 ("gpio: viperboard: use new GPIO line value setter callbacks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/9e72018c-e46e-4e55-83e4-503da4d022fc@sabinyo.mountain
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Dan Carpenter 2025-07-15 17:58:34 -05:00 committed by Bartosz Golaszewski
parent 0c0438d444
commit 5103fbb7b5
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-viperboard.c
View File

@ -378,15 +378,13 @@ static int vprbrd_gpiob_direction_output(struct gpio_chip *chip,
gpio->gpiob_out |= (1 << offset);
mutex_lock(&vb->lock);
ret = vprbrd_gpiob_setdir(vb, offset, 1);
mutex_unlock(&vb->lock);
if (ret) {
dev_err(chip->parent, "usb error setting pin to output\n");
return ret;
}
mutex_unlock(&vb->lock);
return vprbrd_gpiob_set(chip, offset, value);
}