github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-07 22:14:04 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

devtmpfs: fix placement of complete() call

Browse Source 
[ Upstream commit 38f087de89 ]

Calling complete() from within the __init function is wrong -
theoretically, the init process could proceed all the way to freeing
the init mem before the devtmpfsd thread gets to execute the return
instruction in devtmpfs_setup().

In practice, it seems to be harmless as gcc inlines devtmpfs_setup()
into devtmpfsd(). So the calls of the __init functions init_chdir()
etc. actually happen from devtmpfs_setup(), but the __ref on that one
silences modpost (it's all right, because those calls happen before
the complete()). But it does make the __init annotation of the setup
function moot, which we'll fix in a subsequent patch.

Fixes: bcbacc4909 ("devtmpfs: refactor devtmpfsd()")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20210312103027.2701413-1-linux@rasmusvillemoes.dk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Rasmus Villemoes 2021-03-12 11:30:26 +01:00 committed by Greg Kroah-Hartman
parent bac2031321
commit 501ba8bf8d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/base/devtmpfs.c
View File

@ -416,7 +416,6 @@ static int __init devtmpfs_setup(void *p)
init_chroot("."); init_chroot(".");
out: out:
*(int *)p = err; *(int *)p = err;
complete(&setup_done);
return err; return err;
} }
@ -429,6 +428,7 @@ static int __ref devtmpfsd(void *p)
{ {
int err = devtmpfs_setup(p); int err = devtmpfs_setup(p);
complete(&setup_done);
if (err) if (err)
return err; return err;
devtmpfs_work_loop(); devtmpfs_work_loop();