github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-09-22 12:44:03 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

dm vdo: don't read repair field in loop condition

Browse Source 
Respell the vio launch loop to use the existing vio_count
value. The repair completion is not guaranteed to persist
after all of the metadata_vios are launched. This can not
currently cause problems due to the way vio callbacks are
handled, but it is technically not safe to access those
fields.

Signed-off-by: Matthew Sakai <msakai@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
This commit is contained in:
Matthew Sakai 2026-07-17 12:01:11 -04:00 committed by Mikulas Patocka
parent 2df0fc042e
commit 4cf795dd0e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/md/dm-vdo/repair.c
View File

@ -1696,6 +1696,7 @@ void vdo_repair(struct vdo_completion *parent)
struct vdo *vdo = parent->vdo;
struct recovery_journal *journal = vdo->recovery_journal;
physical_block_number_t pbn = journal->origin;
block_count_t i;
block_count_t remaining = journal->size;
block_count_t vio_count = DIV_ROUND_UP(remaining, MAX_BLOCKS_PER_VIO);
page_count_t page_count = min_t(page_count_t,
@ -1749,9 +1750,8 @@ void vdo_repair(struct vdo_completion *parent)
remaining -= blocks;
}
for (vio_count = 0; vio_count < repair->vio_count;
vio_count++, pbn += MAX_BLOCKS_PER_VIO) {
vdo_submit_metadata_vio(&repair->vios[vio_count], pbn, read_journal_endio,
for (i = 0; i < vio_count; i++, pbn += MAX_BLOCKS_PER_VIO) {
vdo_submit_metadata_vio(&repair->vios[i], pbn, read_journal_endio,
handle_journal_load_error, REQ_OP_READ);
}
}