From 492b24b5b651a72ee83a8d481f70246b36192832 Mon Sep 17 00:00:00 2001 From: Ze Tan Date: Fri, 14 Aug 2026 13:51:43 +0000 Subject: [PATCH] smb/server: update session counter under sessions table lock KSMBD_COUNTER_SESSIONS tracks sessions published in sessions_table. Increment it while holding sessions_table_lock so publishing a session and updating the counter happen together. Fixes: b38f99c1217a ("ksmbd: add procfs interface for runtime monitoring and statistics") Signed-off-by: Ze Tan Reviewed-by: ChenXiaoSong Signed-off-by: Namjae Jeon --- fs/smb/server/mgmt/user_session.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/smb/server/mgmt/user_session.c b/fs/smb/server/mgmt/user_session.c index 6d1292243378..087cf968a320 100644 --- a/fs/smb/server/mgmt/user_session.c +++ b/fs/smb/server/mgmt/user_session.c @@ -740,11 +740,11 @@ static struct ksmbd_session *__session_create(int protocol) down_write(&sessions_table_lock); hash_add(sessions_table, &sess->hlist, sess->id); + ksmbd_counter_inc(KSMBD_COUNTER_SESSIONS); up_write(&sessions_table_lock); if (create_proc_session(sess)) pr_warn_ratelimited("Unable to create session %llu procfs entry\n", sess->id); - ksmbd_counter_inc(KSMBD_COUNTER_SESSIONS); return sess; error: