From 47eb05e731fbef11dc36e9a9a9a05e61d43480ae Mon Sep 17 00:00:00 2001 From: Randy Dunlap Date: Thu, 13 Aug 2026 16:29:33 -0700 Subject: [PATCH] fbdev: maxine: elide an unused function maxinefb_ims332_read_register() is not used, but since it describes a hardware interface, leave it in the source file as documentation and surround it inside an #if 0/#endif block. ../drivers/video/fbdev/maxinefb.c:74:21: warning: 'maxinefb_ims332_read_register' defined but not used [-Wunused-function] 74 | static unsigned int maxinefb_ims332_read_register(int regno) Signed-off-by: Randy Dunlap Acked-by: Maciej W. Rozycki Signed-off-by: Helge Deller --- drivers/video/fbdev/maxinefb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/fbdev/maxinefb.c b/drivers/video/fbdev/maxinefb.c index a9410a553113..10249a1cfc72 100644 --- a/drivers/video/fbdev/maxinefb.c +++ b/drivers/video/fbdev/maxinefb.c @@ -71,6 +71,8 @@ static void maxinefb_ims332_write_register(int regno, register unsigned int val) *((volatile unsigned short *) (wptr)) = val; } +#if 0 +/* dead code: leave here for hardware interface documentation */ static unsigned int maxinefb_ims332_read_register(int regno) { register unsigned char *regs = (char *) MAXINEFB_IMS332_ADDRESS; @@ -83,6 +85,7 @@ static unsigned int maxinefb_ims332_read_register(int regno) return (j & 0xffff) | ((k & 0xff00) << 8); } +#endif /* Set the palette */ static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green,