github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-28 10:09:10 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

ASoC: cs42l43: Move long delayed work on system_dfl_long_wq

Browse Source 
Move long delayed work on system_dfl_long_wq

Currently the code enqueue work items using {queue|mod}_delayed_work(),
using system_long_wq. This workqueue should be used when long works are
expected and it is a per-cpu workqueue.

The function(s) end up calling __queue_delayed_work(), which set a global
timer that could fire anywhere, enqueuing the work where the timer fired.

Unbound works could benefit from scheduler task placement, to optimize
performance and power consumption. Long work shouldn't stick to a single
CPU.

Recently, a new unbound workqueue specific for long running work has
been added:

    c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works")

Since the workqueue work doesn't rely on per-cpu variables, there is no
obvious reason that justify the use of a per-cpu workqueue. So change
system_long_wq with system_dfl_long_wq so that the work may benefit from
scheduler task placement.

Cc: David Rhodes <david.rhodes@cirrus.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Link: https://patch.msgid.link/20260508150327.351779-2-marco.crivellari@suse.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Marco Crivellari 2026-05-08 17:03:18 +02:00 committed by Mark Brown
parent 5d6919055d
commit 45f7d7af0e
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sound/soc/codecs/cs42l43-jack.c
View File

@ -805,7 +805,7 @@ irqreturn_t cs42l43_tip_sense(int irq, void *data)
if (priv->suspend_jack_debounce)
db_delay += priv->tip_fall_db_ms + priv->tip_rise_db_ms;
queue_delayed_work(system_long_wq, &priv->tip_sense_work,
queue_delayed_work(system_dfl_long_wq, &priv->tip_sense_work,
msecs_to_jiffies(db_delay));
return IRQ_HANDLED;
@ -932,7 +932,8 @@ int cs42l43_jack_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *u
snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF);
if (!override) {
queue_delayed_work(system_long_wq, &priv->tip_sense_work, 0);
queue_delayed_work(system_dfl_long_wq, &priv->tip_sense_work,
0);
} else {
override--;