From 45c6696215e47eeed7061d0c503f72e459003972 Mon Sep 17 00:00:00 2001 From: Pan Chuang Date: Mon, 20 Jul 2026 14:37:39 +0800 Subject: [PATCH] hwmon: (pwm-fan) Remove redundant dev_err() Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang Link: https://lore.kernel.org/r/20260720063745.309331-6-panchuang@vivo.com Signed-off-by: Guenter Roeck --- drivers/hwmon/pwm-fan.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c index 37f37813ea51..3b87f65bae05 100644 --- a/drivers/hwmon/pwm-fan.c +++ b/drivers/hwmon/pwm-fan.c @@ -628,12 +628,8 @@ static int pwm_fan_probe(struct platform_device *pdev) if (tach->irq > 0) { ret = devm_request_irq(dev, tach->irq, pulse_handler, IRQF_NO_THREAD, pdev->name, tach); - if (ret) { - dev_err(dev, - "Failed to request interrupt: %d\n", - ret); + if (ret) return ret; - } } if (!ctx->pulses_per_revolution[i]) {