github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-02 19:43:40 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

wifi: rtw89: usb: use ieee80211_free_txskb() where appropriate

Browse Source 
rtw89_usb_ops_tx_kick_off() may need to release skb if a failure occurs.
It operates mainly on skbs coming from the core wireless stack and the
ones containing firmware commands.

Use ieee80211_free_txskb() for the former case.

Suggested-by: Ping-Ke Shih <pkshih@realtek.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20251104135720.321110-4-pchelkin@ispras.ru
This commit is contained in:
Fedor Pchelkin 2025-11-04 16:57:10 +03:00 committed by Ping-Ke Shih
parent 7543818e97
commit 45a6a88f01
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/wireless/realtek/rtw89/usb.c
View File

@ -258,6 +258,15 @@ static int rtw89_usb_write_port(struct rtw89_dev *rtwdev, u8 ch_dma,
return ret;
}
static void rtw89_usb_tx_free_skb(struct rtw89_dev *rtwdev, u8 txch,
struct sk_buff *skb)
{
if (txch == RTW89_TXCH_CH12)
dev_kfree_skb_any(skb);
else
ieee80211_free_txskb(rtwdev->hw, skb);
}
static void rtw89_usb_ops_tx_kick_off(struct rtw89_dev *rtwdev, u8 txch)
{
struct rtw89_usb *rtwusb = rtw89_usb_priv(rtwdev);
@ -272,7 +281,7 @@ static void rtw89_usb_ops_tx_kick_off(struct rtw89_dev *rtwdev, u8 txch)
txcb = kmalloc(sizeof(*txcb), GFP_ATOMIC);
if (!txcb) {
dev_kfree_skb_any(skb);
rtw89_usb_tx_free_skb(rtwdev, txch, skb);
continue;
}
@ -291,7 +300,7 @@ static void rtw89_usb_ops_tx_kick_off(struct rtw89_dev *rtwdev, u8 txch)
skb_dequeue(&txcb->tx_ack_queue);
kfree(txcb);
dev_kfree_skb_any(skb);
rtw89_usb_tx_free_skb(rtwdev, txch, skb);
}
}
}