github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-07-31 19:47:08 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

sched/walt: choose best cpu based on spare cap

Browse Source 
When the placement code has to skip energy evaluation and quickly return
the best cpu amongst the candidates, the current code chooses the max
capacity cpu within them. This leads to overcrowding on the max cpu,
as we could be operating in the skip energy eval mode for a long time.

So instead of choosing max capacity cpu, choose a cpu with most spare
capacity.

Change-Id: I13e435cbfc802c5a1002703f928b5f56ef5d8e1f
Signed-off-by: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
This commit is contained in:
Abhijeet Dharmapurikar 2021-08-01 23:48:36 -07:00 committed by Rishabh Bhatnagar
parent 7bb38803c2
commit 452807ae7e
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
kernel/sched/walt/walt_cfs.c
View File

@ -670,6 +670,11 @@ static inline bool select_cpu_same_energy(int cpu, int best_cpu, int prev_cpu)
return available_idle_cpu(best_cpu);
}
static inline unsigned int capacity_spare_of(int cpu)
{
return capacity_orig_of(cpu) - cpu_util(cpu);
}
static DEFINE_PER_CPU(cpumask_t, energy_cpus);
int walt_find_energy_efficient_cpu(struct task_struct *p, int prev_cpu,
int sync, int sibling_count_hint)
@ -761,13 +766,13 @@ int walt_find_energy_efficient_cpu(struct task_struct *p, int prev_cpu,
}
if (!energy_eval_needed) {
int max_cap_cpu = first_cpu;
int max_spare_cpu = first_cpu;
for_each_cpu(cpu, candidates) {
if (capacity_orig_of(max_cap_cpu) < capacity_orig_of(cpu))
max_cap_cpu = cpu;
if (capacity_spare_of(max_spare_cpu) < capacity_spare_of(cpu))
max_spare_cpu = cpu;
}
best_energy_cpu = max_cap_cpu;
best_energy_cpu = max_spare_cpu;
goto unlock;
}