github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-05 13:06:59 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

net: pktgen: fix access outside of user given buffer in pktgen_thread_write()

Browse Source 
Honour the user given buffer size for the strn_len() calls (otherwise
strn_len() will access memory outside of the user given buffer).

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250219084527.20488-8-ps.report@gmx.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Peter Seiderer 2025-02-19 09:45:27 +01:00 committed by Jakub Kicinski
parent 1e5e511373
commit 425e64440a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
net/core/pktgen.c
View File

@ -1900,8 +1900,8 @@ static ssize_t pktgen_thread_write(struct file *file,
i = len;
/* Read variable name */
len = strn_len(&user_buffer[i], sizeof(name) - 1);
max = min(sizeof(name) - 1, count - i);
len = strn_len(&user_buffer[i], max);
if (len < 0)
return len;
@ -1931,7 +1931,8 @@ static ssize_t pktgen_thread_write(struct file *file,
if (!strcmp(name, "add_device")) {
char f[32];
memset(f, 0, 32);
len = strn_len(&user_buffer[i], sizeof(f) - 1);
max = min(sizeof(f) - 1, count - i);
len = strn_len(&user_buffer[i], max);
if (len < 0) {
ret = len;
goto out;