github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-05-23 06:31:58 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

remoteproc: imx_dsp_rproc: Wait for suspend ACK only if WAIT_FW_CONFIRMATION is set

Browse Source 
The DSP suspend path currently waits unconditionally for a suspend ack
from the firmware. This breaks firmwares that do not implement the
mailbox-based CONFIRMATION handshake, as the DSP never responds and
system suspend fails with -EBUSY.

The driver already uses the WAIT_FW_CONFIRMATION flag to indicate that
the firmware supports the CONFIRMATION handshake at boot. Apply the same
logic during suspend: only send the suspend message and wait for the
suspend ack when the firmware is expected to support it.

Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Link: https://lore.kernel.org/r/20251204122825.756106-3-iuliana.prodan@oss.nxp.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
This commit is contained in:
Iuliana Prodan 2025-12-04 14:28:25 +02:00 committed by Mathieu Poirier
parent 424f22b48c
commit 4200f873c4
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/remoteproc/imx_dsp_rproc.c
View File

@ -1251,6 +1251,12 @@ static int imx_dsp_suspend(struct device *dev)
goto out;
}
/* No fw confirmation expected, so trigger PM runtime suspend */
if (!(priv->flags & WAIT_FW_CONFIRMATION)) {
dev_dbg(dev, "No FW_CONFIRMATION needed, suspend directly.\n");
goto out;
}
reinit_completion(&priv->pm_comp);
/* Tell DSP that suspend is happening */