github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-03 03:53:37 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

pinctrl: cy8c95x0: Don't use cy8c95x0_set_mode() twice

Browse Source 
Instead, call it once in cy8c95x0_pinmux_mode() and if selector is 0,
shortcut the flow by returning 0 immediately.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20221018151223.80846-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Andy Shevchenko 2022-10-18 18:12:23 +03:00 committed by Linus Walleij
parent 1d66e37973
commit 417c326091
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/pinctrl/pinctrl-cy8c95x0.c
View File

@ -1107,13 +1107,13 @@ static int cy8c95x0_pinmux_mode(struct cy8c95x0_pinctrl *chip,
u8 bit = cypress_get_pin_mask(chip, group);
int ret;
if (selector == 0)
return cy8c95x0_set_mode(chip, group, false);
ret = cy8c95x0_set_mode(chip, group, true);
ret = cy8c95x0_set_mode(chip, group, selector);
if (ret < 0)
return ret;
if (selector == 0)
return 0;
/* Set direction to output & set output to 1 so that PWM can work */
ret = regmap_write_bits(chip->regmap, CY8C95X0_DIRECTION, bit, bit);
if (ret < 0)