github-mirror/linux
1
0
Fork 0
mirror of https://github.com/torvalds/linux.git synced 2026-06-02 03:24:19 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity Graph

staging: nvec: make keyboard init synchronous

Browse Source 
Currently, we are constantly sending commands to the EC without waiting for them to be
executed. This can lead to confusion, especially if we initialize several different devices
one after the other.
To avoid this, we are switching from asynchronous to synchronous command transmission.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Link: https://lore.kernel.org/r/20240406123123.37148-3-marvin24@gmx.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Marc Dietrich 2024-04-06 14:31:20 +02:00 committed by Greg Kroah-Hartman
parent 244b6e92bd
commit 41288dfaf1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/nvec/nvec_kbd.c
View File

@ -148,15 +148,16 @@ static int nvec_kbd_probe(struct platform_device *pdev)
nvec_register_notifier(nvec, &keys_dev.notifier, 0);
/* Enable keyboard */
nvec_write_async(nvec, enable_kbd, 2);
nvec_write_sync(nvec, enable_kbd, 2, NULL);
/* configures wake on special keys */
nvec_write_async(nvec, cnfg_wake, 4);
nvec_write_sync(nvec, cnfg_wake, 4, NULL);
/* enable wake key reporting */
nvec_write_async(nvec, cnfg_wake_key_reporting, 3);
nvec_write_sync(nvec, cnfg_wake_key_reporting, 3, NULL);
/* Disable caps lock LED */
nvec_write_async(nvec, clear_leds, sizeof(clear_leds));
nvec_write_sync(nvec, clear_leds, sizeof(clear_leds), NULL);
return 0;
}